View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18343 | Bug reports | Other | public | 2022-09-12 13:40 | 2023-06-01 17:44 |
Reporter | 2BITS_PL | Assigned To | adamzammit | ||
Priority | none | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.28.x | ||||
Summary | 18343: Problem with interpreting double slash in an URL (IIS) | ||||
Description | Hello, in our internal testing, we noticed that the app was showing us CHttpException errors when there is a double slash in the URL. This is the case if you run CKEditor while editing the notification template (inside the survey) as the question ID and group ID are NULL. So the URL in this case would be: "...gui//qid/" if ((string) (int) $ params ['iGroupId']! == (string) $ params ['iGroupId']) { The question is how to fix it? | ||||
Steps To Reproduce | Steps to reproduceAfter launching the project in IIS, when we call, for example, the URL: It mainly occurs when CKEditor is running as an inline or popup Expected resultIt should display the page linked to. Actual resultReturns CHttpException "Invalid group id" | ||||
Tags | No tags attached. | ||||
Bug heat | 14 | ||||
Complete LimeSurvey version number (& build) | Version 3.28.24+220816 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | SQL Server 2019 | ||||
Server OS (if known) | Microsoft Server 2019 | ||||
Webserver software & version (if known) | |||||
PHP Version | v7.4.15 NTS x64 | ||||
parent of | 18811 | closed | DenisChenu | Button that triggers HTML editor in pop-up window doesn't work |
related to | 18747 | closed | DenisChenu | general settings - user administration - reserved words |
In the following url
Isnt the GID missing actually? |
|
Yes, in fact both GID and QID are missing. I have provided a URL to make testing easier. But their absence can also be checked in the demo version (https://demo.limesurvey.org/), if we open the CKEditor (popup), the url shows that gid and qid do not have an id. In the case of IIS, this causes an error message (I haven't tested version 5.x in our environment, but I suppose the problem will be too). In a moment I will prepare screenshots of our local environment for version 3.28 and a description of how to invoke them. |
|
I can not reproduce
We check !empty at line 163 … |
|
Can not reproduce : are you sure your version is uptodate ? But right : js can be updated on email : …/admin/htmleditor_pop/sa/index/name/email_admin_notification_en/text/Basic admin notification email body:(en)/type/email_admin_notification_en/action/editemailtemplates/sid/574436/gid//qid//lang/en |
|
Oh need IIS + path format … How do you configure IIS and PATH format ? Maybe it's something that can be fixed with configuration ? (and then : i can check on my dev IIS server). |
|
No : i mean by default on IIS : rewrite is not activated : url is set to path All start by /index.php?r= Your url seems : /index.php/admin/htmleditor_pop https://manual.limesurvey.org/Optional_settings/en#URL_settings Maybe try to set url to |
|
I confirm that the problem is with the "path". But for us, this is not a solution as our top-down guidelines say that addresses must be user-friendly. |
|
OK : but need confirmation before. Then IIS allow path with showScriptName = false or only with showScriptName = true ? |
|
Yep : i think we must NOT send empty value (or send 0 if we can really not doing differently) |
|
He understands that when faced with the problem of the "path" it must be solved in a global context. |
|
PS: starting the web.config system on manual still a good idea :). You know how to deny access to ^/upload/surveys/./fu_[a-z0-9]$ files ? Denis |
|
@2BITS_PL : can you test https://github.com/LimeSurvey/LimeSurvey/pull/2630 please ? |
|
master version : https://github.com/LimeSurvey/LimeSurvey/pull/2639 |
|
Why you answer in private ? Usage of widget inside CKeditor is not fixed : maybe it must be reported as another issue soince it's surely happen with inline ckeditor. |
|
Private, because I am sending screenshots from our client's application, we don't want it to be public. The error is related to Limesurvey and not as suggested by CKEditor. The presented solution only applies to the popup options. However, there is also an inline embedding method for CKEditor that has a bug (lines 283 and 284): https://github.com/LimeSurvey/LimeSurvey/blob/15b3cfea6887465e4fbdddfcad1ddde332d96e5c/application/helpers/admin/htmleditor_helper.php#L283 |
|
Yes: but it's another issue … Can i set the Pull request to tested ? |
|
ANd clearly : here it's the inline editor … it's another issue |
|
The notification subject is for a double slash in CKEditor - it is not explicitly stated that it is just a popup. We wanted to solve the problem comprehensively, also inline. But do what you think is right (as comfortable for you) |
|
I will only add that if in the getEditor method (you set it at the beginning)
this will work for a popup and inline CKEditor, without applying the prepared patch (which changes the url structure) |
|
Yes, i know but i don't think it's the best way to do … qid is set even if it must not be set. Replacve is_empty by isset or !is_null : it broke again. |
|
I test this link locally on 5.X : No issue for me … seems only related to 3.X version … |
|
I tested version 5.4.0, IIS with the path setting for urlFormat and confirm that the problem is not. |
|
I tested the inline and popup options in v5.4, they both work fine. |
|
Yes, i report a confidentiality issue here :) test are not done … can be bad. |
|
Updated version with LimeFields |
|
I add LimeReplacementFieldsUrl on near the same way. |
|
Fixed in Release 6.0.5+230502 |
|
Still open |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34613 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34614 |
|
I fix the version.php for 5.X OK to merge ? (I can do it) |
|
Sure, go for it. |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34619 |
|
Thanks :) |
|
Fixed in Release 6.0.6+230508 |
|
Reopen for 3.28 Need to be reverted. Solution to fix 18811 are totally different and need more work … |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34645 |
|
Fixed in Release 3.28.59+230517 |
|
reopen to fix it on 3.X and 5.X |
|
Already fixed but with a more complete solution on 6.X and before, Use a more simple solution, just set 0 via intval. |
|
I have no idea on How to test … 3.X : https://github.com/LimeSurvey/LimeSurvey/pull/3154 |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34694 |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34695 |
|
Merged. |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34696 |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34757 |
|
LimeSurvey: master cea4f2ca 2023-04-27 11:56:07 Details Diff |
Fixed issue 18343: Problem with interpreting double slash in URL (IIS) Fixed issue 18747: user administration email - reserved words send 403 error |
Affected Issues 18343, 18747 |
|
mod - application/config/version.php | Diff File | ||
mod - application/controllers/LimereplacementfieldsController.php | Diff File | ||
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
mod - application/views/admin/survey/prepareEditorScript_view.php | Diff File | ||
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js | Diff File | ||
LimeSurvey: master 1be8c9f9 2023-04-27 11:59:26 Details Diff |
Revert "Fixed issue 18343: Problem with interpreting double slash in URL (IIS)" This reverts commit cea4f2ca5aae0daa33562a46da1fe563cdf15393. |
Affected Issues 18343 |
|
mod - application/config/version.php | Diff File | ||
mod - application/controllers/LimereplacementfieldsController.php | Diff File | ||
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
mod - application/views/admin/survey/prepareEditorScript_view.php | Diff File | ||
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js | Diff File | ||
LimeSurvey: master c4d672c7 2023-05-05 17:44:36 Committer: GitHub Details Diff |
Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#3087) * Fixed issue 18343: Problem with interpreting double slash in URL (IIS) Fixed issue 18747: user administration email - reserved words send 403 error * Dev: lowerCamelCase * Dev: CS |
Affected Issues 18343, 18747 |
|
mod - application/controllers/LimereplacementfieldsController.php | Diff File | ||
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
mod - application/views/admin/survey/prepareEditorScript_view.php | Diff File | ||
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js | Diff File | ||
LimeSurvey: master c4d672c7 2023-05-05 17:44:36 Committer: GitHub Details Diff |
Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#3087) * Fixed issue 18343: Problem with interpreting double slash in URL (IIS) Fixed issue 18747: user administration email - reserved words send 403 error * Dev: lowerCamelCase * Dev: CS |
Affected Issues 18343, 18747 |
|
mod - application/controllers/LimereplacementfieldsController.php | Diff File | ||
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
mod - application/views/admin/survey/prepareEditorScript_view.php | Diff File | ||
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js | Diff File | ||
LimeSurvey: 3.x-LTS ebb447a8 2023-05-06 12:27:59 Committer: GitHub Details Diff |
Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#2630) Dev: use PHP to construct the url Dev: check if non empty before adding it Dev: editorurl |
Affected Issues 18343 |
|
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
mod - application/views/admin/survey/prepareEditorScript_view.php | Diff File | ||
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js | Diff File | ||
LimeSurvey: 3.x-LTS 245a3594 2023-05-10 21:25:30 Committer: GitHub Details Diff |
Revert "Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#2630)" (#3130) This reverts commit ebb447a803af3a2c010437c69e92a66904a08ab8. |
Affected Issues 18343 |
|
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
mod - application/views/admin/survey/prepareEditorScript_view.php | Diff File | ||
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js | Diff File | ||
LimeSurvey: 3.x-LTS 5ad41fef 2023-05-19 13:04:43 Committer: GitHub Details Diff |
Fixed issue 18343: Problem with double slash in an URL(IIS) (#3154) * Fixed issue 18343: Problem with interpreting double slash in an URL (IIS) Dev: intval to get 0 in case of empty * Dev: one more for popup (group editor) |
Affected Issues 18343 |
|
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
LimeSurvey: 3.x-LTS 5ad41fef 2023-05-19 13:04:43 Committer: GitHub Details Diff |
Fixed issue 18343: Problem with double slash in an URL(IIS) (#3154) * Fixed issue 18343: Problem with interpreting double slash in an URL (IIS) Dev: intval to get 0 in case of empty * Dev: one more for popup (group editor) |
Affected Issues 18343 |
|
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
LimeSurvey: 5.x a7067937 2023-05-19 13:04:55 Committer: GitHub Details Diff |
Fixed issue 18343: Problem with double slash in an URL(IIS) (#3155) Dev: use intval Dev: most simple fix to avoid more commit (see mantis 18811) |
Affected Issues 18343 |
|
mod - application/helpers/admin/htmleditor_helper.php | Diff File | ||
mod - application/views/admin/htmleditor/pop_editor_view.php | Diff File | ||
LimeSurvey: 3.x-LTS 6cd2e8b8 2023-06-01 17:35:47 Committer: GitHub Details Diff |
Fixed issue 17491: Multiple Short Text subquestions missing from Export Printable Survey (#3134) * Fixed issue 17962: Export fails when called from a Cron process or console application (#2417) * Fixed issue 18074: Exit and clear survey doesn't work (#2397) * Fixed issue 17872: Answerfilters reset after pagination changed (#2403) * Fixed issue 17987 : quota url need to be decoded (#2395) * Fixed issue 17709: GUI setting for DB session lifetime does not apply (#2415) * Dev Automatic translation update * Release 3.28.12+220524 * Updated translation: Malay by lucas_encuesta.biz Updated translation: Maltese by gabrieljenik * Updated translation: Italian (Informal) by lucas_encuesta.biz * Fixed issue #18160: [security] Update jquery-ui to 1.13.1 * Release 3.28.13+220531 * Fixed issue 18029: Removed html tags in emails (#2411) * Fixed issue 18129 : potential 500 error in file upload (#2434) * Fixed issue 18043: Subquestion attributes shown in Short Free text quesiton type * Dev Update ComfortUpdate URL to get a trial key * Revert "Fixed issue 18043: Subquestion attributes shown in Short Free text quesiton type" This reverts commit 70bf2e78e3b33db16ee5cc6fb9a31fe94a5d9b82. * Fixed issue: Question organizer not working * Fixed issue 18128 : JS error on 1st survey page * Dev Updated language description for Sami * Dev: Avoid issue with ndebug set and null pageTailorInfo * Fixed issue 18140: cannot import vv file (with debug set) (#2453) Dev: remove uneeded unlink and add comment in function * Updated translation: French (France) by DenisChenu Updated translation: Uighur by walkingdead * Release 3.28.14+220608 * Fixed issue 18086: Custom 'other' label text not applied to Bootstrap button layout (#2422) * Fixed issue #18189: Fonts showing differently on mobile Vs desktop (#2467) * Updated translation: Czech by jelen1 Updated translation: Indonesian by ysulistya Updated translation: Czech (Informal) by jelen1 * Release 3.28.15+220616 * Updated translation: Catalan by qualitatuvic Updated translation: French (France) by DenisChenu, Xave Updated translation: Polish by elissa Updated translation: Polish (Informal) by elissa * Release 3.28.16+220621 * Fixed issue 18186: Language changer does not work in registration page (#2474) Fixed issue 18186: Language changer does not work in registration page Dev: same fix than master Dev: keyboard navigation OK Dev: submit button OK * Fixed issue: Error after user deletion * Release 3.28.17+220627 * Fixed issue #18189: Fonts showing differently on mobile Vs desktop (#2484) * Fixed issue [security] #18042: Path-relative stylesheet import (PRSSI) vulnerability (#2374) (#2495) * Fixed issue 18201: Unable to import LSA file with MSSQL and debug set (#2472) Dev: check if $result['CONTRAINT_NAME'] exist before using it * Fixed issue [security] #18200: User with only reponse export can export Survey + token (survey archive) (#2491) * Dev Automatic translation update * Revert "Fixed issue 18029: Removed html tags in emails (#2411)" This reverts commit 39705d571d21ff59c8aea85c6ceca4858ed48998. * Updated translation: German by c_schmitz Updated translation: Basque by zatarain Updated translation: Italian by lfanfoni, ritapas Updated translation: Kazakh by CenterOfExcellence Updated translation: Kannada by mahantesh19 Updated translation: Luxembourgish by Mazi Updated translation: Dutch by Han Updated translation: Slovak by jelen1 Updated translation: Ukrainian by olly Updated translation: Zulu by erik.lamontagne Updated translation: Italian (Informal) by lfanfoni Updated translation: Dutch (Informal) by Han Updated translation: Chinese (Simplified) by FangZhijian * Release 3.28.18+220706 * Fixed issue 17952: Command action try to open uneeded session (#2496) Dev: replace the get action on ConsoleHttpSession * Fixed issue 17488: Cannot view survey after updating to version 3.27.9 with custom twig extension (breaks survey) (#2360) * Updated translation: Hungarian by kkd * Release 3.28.19+220712 * Fixed issue #18183: Date filter at statistics is not applied correctly (#2493) * Fixed issue #18106: Missing survey ID replacements at registration screen * Updated translation: Basque by admin67 Updated translation: Japanese by nomoto Updated translation: German (Informal) by c_schmitz * Release 3.28.20+220719 * Fixed issue 17458: Check integrity broke with SQL error (#2312) Dev: add a try/cast Dev: happen if subquestion title are number only Dev: No need to check if integer, and don't throw exception … Dev: log it as info * Updated translation: Swedish by maxzomborszki * Release 3.28.21+220726 * Fixed issue 17972: events are dispatched if the plugin is deactivated (#2335) Dev: Add param to load init Dev: set it to false in PluginManagerController in all case Dev: active plugin are loaded via PluginManager->loadPlugins Dev: use plugin model active status in PluginManager Dev: init the plugin before activate * Updated translation: French (France) by c_schmitz, DenisChenu, eddylackmann, fradeff, frederic93190, Xave Updated translation: Thai by tomzt Updated translation: Turkish by kayazeren * Release 3.28.22+220802 * Updated translation: Lithuanian by c_schmitz, simasj * Release 3.28.23+220809 * Updated translation: Croatian by rovinj * Release 3.28.24+220816 * Fixed issue: Cannot load previously saved response to resume, instead the message "There is no matching saved response" is shown after entering identifier and password * Fixed issue 16795: typo in default text for confirmation email (in english) (#2572) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Dev Automatic translation update * Fixed issue 17485: The getAnswerQuery method cannot be used in the Answers model (#2569) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 18209: Missing RemoteControl function to get the field mapping (#2490) * Dev: Add validate command needed to validate extremely big email templates with expressions * Updated translation: Catalan by qualitatuvic Updated translation: Polish by elissa Updated translation: Polish (Informal) by elissa * Release 3.28.25+220822 * Updated translation: Czech by jelen1 Updated translation: Czech (Informal) by jelen1, slansky * Updated translation: Bengali by lucas_encuesta.biz Updated translation: German by c_schmitz Updated translation: Georgian by lucas_encuesta.biz Updated translation: German (Informal) by c_schmitz * Fixed issue: No response recorded when using registration Dev Revert "Fixed issue #18106: Missing survey ID replacements at registration screen" Dev This reverts commit f23a8a8a35afca6d64b595e20cb9a6f65facadcc. * Updated translation: German by c_schmitz Updated translation: Georgian by c_schmitz Updated translation: German (Informal) by c_schmitz * Release 3.28.26+220829 * Updated translation: Chinese (Simplified) by johnxan * Updated translation: Galician by Calidonia Updated translation: Italian by lfanfoni Updated translation: Swedish by maxzomborszki Updated translation: Thai by adzpire, tomzt Updated translation: Turkish by kayazeren Updated translation: Italian (Informal) by lfanfoni Updated translation: Valencian by joamuran, vbraque * Release 3.28.27+220905 * Updated translation: Dutch by Han Updated translation: Dutch (Informal) by Han * Release 3.28.28+220912 * Fixed issue 18344: Unable to download file in response list (IIS) * Fixed issue 18133: Set "Other" state has no clue about current state * Fixed issue 16697: «inherit everything» still not translated (#2609) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Updated translation: Polish by elissa Updated translation: Polish (Informal) by elissa * Release 3.28.29+220920 * Fixed issue 17870: Default value with line feed broke Expression Script * Fixed issue 18240: QuestioinTheme browserdetect, Show Platform information didn't work (#2596) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 18351: Extra token placeholder show as invalid in expression (#2601) Dev: add completed to fixed columns Dev: use all in expression validator since Script use all token->attributes * Updated translation: Italian by lfanfoni Updated translation: Italian (Informal) by lfanfoni * Updated translation: German by c_schmitz Updated translation: Khmer by lucas_encuesta.biz Updated translation: Urdu by lucas_encuesta.biz * Updated translation: German (Informal) by c_schmitz * Release 3.28.30+220927 * Updated translation: Polish by elissa Updated translation: Thai by tomzt Updated translation: Uighur by walkingdead Updated translation: Polish (Informal) by elissa * Release 3.28.31+221005 * Fixed issue 17950: is_int(false) returns true (#2431) Dev: false and '' disallowed * Fixed issue: HTML tags are not allowed for admins in participant attributes (#2626) * Fixed issue 15195: Expiration date can be set before start date (#2551) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 17117: 'Send invitations' button does nothing after failed send invitations (#2571) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 18134: Present subquestions/answer options in random order has no clue about current state (#2563) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 17173: Publication and access setting 'listed publicly' not displayed correctly (#2544) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 18141: changing display mode from extended to compact in survey responses windows causes freeze (#2499) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 14386: Pagination legend incorrect for Survey Groups (#2535) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Updated translation: Uighur by walkingdead * Release 3.28.32+221011 * Updated translation: Czech by jelen1 Updated translation: Czech (Informal) by jelen1 * Dev Text fixes * Dev Automatic translation update * Dev Text fixes * Dev Automatic translation update * Updated translation: German by c_schmitz Updated translation: German (Informal) by c_schmitz * Fixed issue: [security] Various major & minor security issues discovered by automated security tools * Updated translation: Polish by elissa Updated translation: Polish (Informal) by elissa * Release 3.28.33+221020 * Fixed issue: Missing files * Release 3.28.34+221021 * Fixed issue: Cannot edit file in theme editor * Updated translation: Czech by jelen1 Updated translation: Czech (Informal) by jelen1 * Release 3.28.35+221025 * Fixed issue: Cannot add participant to CPDB * Fixed issue 18430: Unable to ComfortUpdate * Dev Small fix * Updated translation: Italian by lfanfoni Updated translation: Italian (Informal) by lfanfoni * Dev Update to Yii 1.1.26 for better 8.1 compatibilty * Release 3.28.36+221102 * Fixed issue: ComfortUpdate is blocked by error/warning/notice when debug mode is active * Fixed issue 15310: Display dropdown boxes - Date/Time question type not working correctly if minimum date < 1900 (#2628) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Fixed issue 17883: QueXML formatting cannot be changed (#2561) Dev: Patch by 2BITS_PL * Dev Performance enhancement for survey list Dev Bumped updater version * Dev Performance enhancement for survey list * Dev Automatic translation update * Release 3.28.37+221108 * Fixed issue: Survey gets into a state where it seems to be active but isn't - to fix this run integrity check Partially reverting issue 15195. Similar to commit https://github.com/LimeSurvey/LimeSurvey/commit/dbc22fcbf4d3bc80c44b596ab99346f8f280bf81 * Updated translation: Catalan by qualitatuvic Updated translation: Czech by jelen1 Updated translation: Portuguese (Brazil) by educaticteced, effgarces, filhocf, josesiqueira, mauriciofurtado Updated translation: Czech (Informal) by jelen1 * Release 3.28.38+221115 * Fixed issue: ComfortUpdate should use SSL by default * Fixed issue 15195: Expiration date can be set before start date (#2727) * Fixed issue 18488: Conditions are not properly highlighted if they have additional spaces (#2736) * Updated translation: Hungarian by kkd Updated translation: Valencian by vbraque * Release 3.28.39+221122 * Fixed issue 16187: Cant Create Custom Survey ID (need proper error message) (#2725) Co-authored-by: lapiudevgit <devgit@lapiu.biz> * Fixed issue 18461 Survey groups at survey list screen should be listed alphabetically (#2723) Co-authored-by: lapiudevgit <devgit@lapiu.biz> * Fixed issue 14310: Google Analytics functionality doesn't work (#2643) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> * Updated translation: Italian by lfanfoni, ritapas Updated translation: Polish by elissa Updated translation: Italian (Informal) by lfanfoni, ritapas Updated translation: Polish (Informal) by elissa * Release 3.28.40+221129 * Fixed issue 17818: Copy a multiple choice question send a DB error (MSSQL) (#2593) Dev: switchMSSQLIdentityInsert when needed * Updated translation: French (France) by arnaud21, DenisChenu, Xave Updated translation: Italian by lfanfoni Updated translation: Dutch by c_schmitz, Han Updated translation: Polish by elissa Updated translation: Italian (Informal) by lfanfoni Updated translation: Dutch (Informal) by c_schmitz, Han Updated translation: Polish (Informal) by elissa * Release 3.28.41+221206 * Fixed issue [security] #18514 : no CSRF control when delete token table (#2760) Dev: move to POST action * Updated translation: Catalan by qualitatuvic Updated translation: Galician by Calidonia Updated translation: Japanese by c_schmitz, d_inoue, nomoto Updated translation: Portuguese (Brazil) by mauriciofurtado * Release 3.28.42+221213 * Updated translation: Azerbaijani by PawelAtroszko Updated translation: Bosnian by PawelAtroszko Updated translation: Galician by Calidonia Updated translation: Luxembourgish by Mazi * Fixed issue 18086: Custom "other" label text not applied to Bootstrap button layout (#2749) Co-authored-by: lapiudevgit <devgit@lapiu.biz> * Fixed issue 18338: For participants, expiration date can be set before start date (#2726) Co-authored-by: lapiudevgit <devgit@lapiu.biz> Co-authored-by: Olle Härstedt <olleharstedt@yahoo.com> * Updated translation: Bosnian by PawelAtroszko Updated translation: German by c_schmitz, eddylackmann * Dev: Fix CI * Dev: Fix CI * Dev: Fix CI * Dev: Fix CI * Dev: Debug index.php * Updated translation: Catalan by qualitatuvic * Dev: Missing mbstring in CI * Dev: Missing FF capabilities for local cert (CI) * Dev: Try with testdox (CI) * Dev: Insert authdb plugin row before running tests (CI) * Dev: Fix typo * Dev: Use -b limesurvey (CI) * Dev: testdox swallows errors :( (CI) * Dev: cat config.php (CI) * Dev: Wait longer at login screen (CI) * Dev: Test to sleep (CI) * Dev: Dump body (CI) * Dev: Add missing xml lib ext (CI) * Updated translation: Polish by elissa Updated translation: Polish (Informal) by elissa * Dev: Remove try-catch around index * Release 3.28.43+221221 * Dev Automatic translation update * Dev: Fix iframe bug in unit test * Updated translation: Czech by jelen1 Updated translation: Italian by lfanfoni Updated translation: Czech (Informal) by jelen1 Updated translation: Italian (Informal) by lfanfoni * Release 3.28.44+230110 * Updated translation: Afrikaans by c_schmitz Updated translation: Arabic by c_schmitz, Shatha Updated translation: Bulgarian by c_schmitz Updated translation: Danish by c_schmitz Updated translation: Greek by c_schmitz Updated translation: Spanish (Spain) by c_schmitz Updated translation: Spanish (Mexican) by c_schmitz Updated translation: Estonian by c_schmitz Updated translation: Hindi by c_schmitz Updated translation: Croatian by c_schmitz Updated translation: Hungarian by c_schmitz Updated translation: Indonesian by c_schmitz Updated translation: Korean by c_schmitz Updated translation: Luxembourgish by Mazi Updated translation: Lithuanian by c_schmitz Updated translation: Latvian by c_schmitz Updated translation: Mongolian by c_schmitz Updated translation: Norwegian (Bokmål) by c_schmitz Updated translation: Norwegian (Nynorsk) by c_schmitz Updated translation: Polish by c_schmitz, elissa Updated translation: Portuguese (Brazil) by c_schmitz Updated translation: Romanian by c_schmitz Updated translation: Russian by c_schmitz Updated translation: Slovenian by c_schmitz Updated translation: Swedish by c_schmitz Updated translation: Thai by c_schmitz Updated translation: Turkish by c_schmitz Updated translation: Ukrainian by c_schmitz Updated translation: Vietnamese by c_schmitz Updated translation: Spanish (Argentina) (Informal) by c_schmitz Updated translation: Polish (Informal) by elissa Updated translation: Chinese (Simplified) by c_schmitz * Release 3.28.45+230117 * Updated translation: Dutch by Han Updated translation: Dutch (Informal) by Han * Release 3.28.46+230124 * Updated translation: Bulgarian by c_schmitz Updated translation: Bosnian by DenisChenu Updated translation: French (France) by DenisChenu Updated translation: Hindi by lucas_encuesta.biz, PawelAtroszko Updated translation: Malay by PawelAtroszko Updated translation: Urdu by lucas_encuesta.biz * Fixed issue 18562: Upload question type partially broken (#2811) Co-authored-by: lapiudevgit <devgit@lapiu.biz> * Dev Automatic translation update * Release 3.28.47+230131 * Updated translation: Armenian by c_schmitz * Fixed issue: Unable to remove an expired ComfortUpdate key * Dev Raised updater version to 18 * Fixed issue: Unable to remove an expired ComfortUpdate key * Updated translation: Croatian by c_schmitz Updated translation: Swedish by c_schmitz Updated translation: Turkish by c_schmitz Updated translation: Chinese (Simplified) by c_schmitz * Updated translation: Filipino by TobyCarslake Updated translation: Maltese by PawelAtroszko Updated translation: Urdu by PawelAtroszko * Fixed issue: Unable to add an new ComfortUpdate key * Updated translation: Danish by c_schmitz Updated translation: German by c_schmitz Updated translation: Spanish (Mexican) by c_schmitz Updated translation: Hindi by c_schmitz Updated translation: Indonesian by c_schmitz Updated translation: Korean by c_schmitz Updated translation: Mongolian by c_schmitz Updated translation: Norwegian (Bokmål) by c_schmitz Updated translation: Portuguese (Brazil) by tamiel Updated translation: Romanian by c_schmitz Updated translation: Russian by c_schmitz Updated translation: Vietnamese by c_schmitz Updated translation: German (Informal) by c_schmitz, eddylackmann, moeller Updated translation: Chinese (Taiwan) (Traditional) by c_schmitz * Updated translation: Portuguese (Brazil) by c_schmitz * Updated translation: Portuguese (Portugal) by c_schmitz Updated translation: Portuguese (Brazil) by tamiel Updated translation: German (Easy) by c_schmitz * Release 3.28.48+230207 * Updated translation: Malay by c_schmitz Updated translation: Tagalog by c_schmitz * Fixed issue: Intermittent unstyled page when creating/copying a survey * Updated translation: Malay by c_schmitz * Updated translation: Bengali by PawelAtroszko * Release 3.28.49+230215 * Fixed issue #18492: [security] Updates for several JS libraries Dev Updated moment.js to version 2.29.4 * Fixed issue #18492: [security] Updates for several JS libraries Dev Updated jQuery UI to version v1.13.2 * Fixed issue #18492: [security] Updates for several JS libraries Dev Updated ckEditor to 4.20.2 * Fixed issue #18492: [security] Updates for several JS libraries Dev Updated Select2 to 4.0.13 * Release 3.28.50+230221 * Fixed issue 18407: On-page conditions not working when pre-filling question with equation on the same page (#2676) Dev: ASSIGN didn't work really with javascript, Dev: Minimal fix to don't throw JS error * Fixed issue 18532: Data entry screen incorrectly assigns 0 value to empty multiflex array checkbox values (PR #2755) Fixed issue 18532: Data entry screen incorrectly assigns 0 value to empty multiflex array checkbox values * Updated translation: Bosnian by amer.kurta Updated translation: Ukrainian by c_schmitz * Release 3.28.51+230228 * Renamed wrong "nameaccesskey" to "accesskey" * Updated translation: Basque by admin67 Updated translation: Valencian by vbraque * Fixed issue: Unable to run integrity check on databases with a big number of surveys * Updated translation: Russian by vipgroup * Release 3.28.52+230307 * Updated translation: Japanese by d_inoue Updated translation: Polish by elissa * Release 3.28.53+230314 * Fixed issue: $aFiles can be null * Feature 18197: Allow GA4 tracking (#2962) Co-authored-by: lapiudevgit <devgit@lapiu.biz> * Dev: Null coalesce operator is not available in PHP 5.6 * Release 3.28.54+230321 * Fixed issue 18071: Importing Qaestion through Remote Control may fail if the imported question already exists (#2972) Co-authored-by: Gabriel Jenik <gabriel.jenik@gmail.com> * Fixed issue: Division by Zero error when running statistics * Dev Automatic translation update * Release 3.28.55+230328 * Fixed issue: PCLZip error on last step of ComfortUpdate when trying to update from version 3 to latest version * Release 3.28.56+230404 * Fixed issue 18703: Upload files show error if not seen (using index) (#3014) * Dev Small test change * Dev Updated runner for Github actions * Updated translation: Norwegian (Bokmål) by pmonstad Updated translation: Turkish by kayazeren Updated translation: German (Easy) by c_schmitz * Release 3.28.57+230425 * Fixed issue 18603: Set Minimum number of files for File Upload not working (#2864) Dev: allow "" and max and min file * Fixed issue 18639: Token browse can be unusable with lot of data in attribute (#2915) Dev: wrap value inside in cell (and encode) Dev: PHP part, need a micro CSS art after Dev: css part, apply to .grid-view .table td .text-content Dev: PSR Dev: Move to CustomFormatter->formatLongText Dev: apply max-width and min-width with less than 50 caracter too * Updated translation: Norwegian (Bokmål) by pmonstad * Updated translation: Swedish by maxzomborszki * Dev: Spit out php version and modules in CI * Dev: More info in error message * Dev: Do MySQL service fixes before installation (CI) * Release 3.28.58+230504 * Dev: Dump available logs (CI) * Dev: Tail MySQL error log (CI) * Dev: Tail as background task (CI) * Dev: YML syntax error * Dev: More CI debugging * Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#2630) Dev: use PHP to construct the url Dev: check if non empty before adding it Dev: editorurl * Fixed issue 18634: Export single selected response can export a empty line (#2909) * Fixed issue 18634: Export single selected response can export a empty line Dev: id set in url, resonseId in POST (by session) Dev: remove session usage Dev: can move to window-location-href, but ready for POST * Dev: separator to , * Dev: oups, lost the allow separator in widget * Dev: Fixed new tab opens * Dev Automatic translation update * Dev: Must check PHP 5.6 syntax before anything else (CI) * Dev: Wrong ordering (CI) * Revert "Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#2630)" (#3130) This reverts commit ebb447a803af3a2c010437c69e92a66904a08ab8. * Fixed issue 17491: Multiple Short Text subquestions missing from Export Printable Survey --------- |
Affected Issues 14310, 14386, 15195, 15310, 16187, 16697, 16795, 17117, 17173, 17458, 17488, 17491, 17709, 17818, 17870, 17872, 17883, 17950, 17952, 17962, 17972, 17987, 18029, 18043, 18071, 18074, 18086, 18106, 18128, 18129, 18133, 18134, 18140, 18141, 18160, 18183, 18186, 18189, 18201, 18209, 18240, 18338, 18343, 18344, 18351, 18407, 18430, 18461, 18488, 18492, 18532, 18562, 18603, 18634, 18639, 18703 |
|
mod - application/controllers/admin/printablesurvey.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-09-12 13:40 | 2BITS_PL | New Issue | |
2022-09-12 14:02 | gabrieljenik | Note Added: 71674 | |
2022-09-12 14:02 | gabrieljenik | Bug heat | 0 => 2 |
2022-09-12 14:02 | gabrieljenik | Status | new => feedback |
2022-09-12 14:46 | 2BITS_PL | Note Added: 71677 | |
2022-09-12 14:46 | 2BITS_PL | Bug heat | 2 => 4 |
2022-09-12 14:46 | 2BITS_PL | Status | feedback => new |
2022-09-12 15:05 | DenisChenu | Note Added: 71678 | |
2022-09-12 15:05 | DenisChenu | Bug heat | 4 => 6 |
2022-09-12 15:11 | DenisChenu | Note Edited: 71678 | |
2022-09-12 15:11 | DenisChenu | Assigned To | => DenisChenu |
2022-09-12 15:11 | DenisChenu | Status | new => feedback |
2022-09-12 15:11 | DenisChenu | Note Added: 71680 | |
2022-09-12 15:13 | DenisChenu | Note Edited: 71680 | |
2022-09-12 16:41 | 2BITS_PL | Status | feedback => assigned |
2022-09-12 16:46 | DenisChenu | Note Added: 71682 | |
2022-09-12 18:04 | DenisChenu | Note Added: 71684 | |
2022-09-13 10:44 | 2BITS_PL | Note Added: 71700 | |
2022-09-13 12:01 | DenisChenu | Note Added: 71702 | |
2022-09-14 09:43 | DenisChenu | Note Added: 71707 | |
2022-09-14 09:44 | 2BITS_PL | Note Added: 71708 | |
2022-09-14 09:45 | DenisChenu | Note Added: 71709 | |
2022-09-22 18:44 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2022-09-22 18:44 | DenisChenu | Status | assigned => ready for code review |
2022-09-22 18:44 | DenisChenu | Note Added: 71897 | |
2022-09-23 15:12 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2022-09-23 15:12 | gabrieljenik | Status | ready for code review => ready for testing |
2022-09-23 17:49 | DenisChenu | Note Added: 71922 | |
2022-09-28 10:51 | DenisChenu | Assigned To | DenisChenu => |
2022-09-29 12:59 | DenisChenu | Note Added: 72015 | |
2022-10-03 18:02 | DenisChenu | Note Added: 72047 | |
2022-10-04 09:35 | 2BITS_PL | Note Added: 72056 | |
2022-10-04 09:42 | DenisChenu | Note Added: 72057 | |
2022-10-04 09:44 | DenisChenu | Note Added: 72058 | |
2022-10-04 10:07 | 2BITS_PL | Note Added: 72059 | |
2022-10-04 10:14 | 2BITS_PL | Note Added: 72060 | |
2022-10-04 14:28 | DenisChenu | Note Added: 72073 | |
2022-10-04 14:42 | DenisChenu | Note Added: 72075 | |
2022-10-04 14:56 | DenisChenu | Assigned To | => DenisChenu |
2022-10-04 14:56 | DenisChenu | Status | ready for testing => assigned |
2022-10-05 10:29 | 2BITS_PL | Note Added: 72093 | |
2022-10-05 10:32 | 2BITS_PL | Note Added: 72094 | |
2022-10-05 11:03 | DenisChenu | Note Added: 72095 | |
2022-10-05 11:10 | DenisChenu | Note Added: 72098 | |
2022-10-05 11:11 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2022-10-05 11:11 | DenisChenu | Status | assigned => ready for code review |
2022-10-05 11:11 | DenisChenu | Note Added: 72100 | |
2022-11-28 11:47 | DenisChenu | Issue Monitored: DenisChenu | |
2022-11-28 11:47 | DenisChenu | Bug heat | 6 => 8 |
2022-11-28 11:47 | DenisChenu | Assigned To | gabrieljenik => |
2022-11-28 16:31 | DenisChenu | Status | ready for code review => in testing |
2023-04-27 11:20 | DenisChenu | Relationship added | related to 18747 |
2023-04-27 11:56 | DenisChenu | Changeset attached | => LimeSurvey master cea4f2ca |
2023-04-27 11:56 | DenisChenu | Assigned To | => DenisChenu |
2023-04-27 11:56 | DenisChenu | Resolution | open => fixed |
2023-04-27 11:59 | DenisChenu | Changeset attached | => LimeSurvey master 1be8c9f9 |
2023-04-27 12:10 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2023-04-27 12:10 | DenisChenu | Status | in testing => ready for testing |
2023-05-02 10:20 | LimeBot | Note Added: 74740 | |
2023-05-02 10:20 | LimeBot | Status | ready for testing => closed |
2023-05-02 10:20 | LimeBot | Bug heat | 8 => 10 |
2023-05-02 10:33 | DenisChenu | Status | closed => ready for testing |
2023-05-02 10:33 | DenisChenu | Note Added: 74741 | |
2023-05-05 17:56 | DenisChenu | Changeset attached | => LimeSurvey master c4d672c7 |
2023-05-05 17:56 | DenisChenu | Changeset attached | => LimeSurvey master c4d672c7 |
2023-05-05 17:56 | DenisChenu | Note Added: 74866 | |
2023-05-05 17:56 | DenisChenu | Note Added: 74867 | |
2023-05-05 17:56 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2023-05-05 17:56 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2023-05-05 18:08 | DenisChenu | Note Added: 74872 | |
2023-05-05 18:09 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2023-05-05 18:31 | tibor.pacalat | Note Added: 74876 | |
2023-05-05 18:31 | tibor.pacalat | Bug heat | 10 => 12 |
2023-05-06 12:28 | DenisChenu | Changeset attached | => LimeSurvey 3.x-LTS ebb447a8 |
2023-05-06 12:28 | DenisChenu | Note Added: 74882 | |
2023-05-06 12:28 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2023-05-06 12:28 | DenisChenu | Note Added: 74883 | |
2023-05-08 11:59 | LimeBot | Note Added: 74887 | |
2023-05-08 11:59 | LimeBot | Status | ready for testing => closed |
2023-05-10 18:32 | DenisChenu | Relationship added | parent of 18811 |
2023-05-10 21:11 | DenisChenu | Status | closed => confirmed |
2023-05-10 21:11 | DenisChenu | Note Added: 74924 | |
2023-05-10 21:14 | DenisChenu | Status | confirmed => assigned |
2023-05-10 21:25 | DenisChenu | Changeset attached | => LimeSurvey 3.x-LTS 245a3594 |
2023-05-10 21:25 | DenisChenu | Note Added: 74925 | |
2023-05-15 12:33 | LimeBot | Note Added: 74967 | |
2023-05-15 12:33 | LimeBot | Status | assigned => closed |
2023-05-15 15:40 | DenisChenu | Status | closed => new |
2023-05-15 15:40 | DenisChenu | Resolution | fixed => reopened |
2023-05-15 15:44 | DenisChenu | Status | new => assigned |
2023-05-16 12:16 | DenisChenu | Note Added: 75007 | |
2023-05-18 18:44 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2023-05-18 18:44 | DenisChenu | Status | assigned => ready for code review |
2023-05-18 18:44 | DenisChenu | Note Added: 75097 | |
2023-05-18 19:57 | gabrieljenik | Assigned To | gabrieljenik => |
2023-05-18 19:57 | gabrieljenik | Status | ready for code review => ready for testing |
2023-05-19 12:05 | DenisChenu | Assigned To | => tibor.pacalat |
2023-05-19 12:09 | DenisChenu | Note Added: 75104 | |
2023-05-19 13:04 | DenisChenu | Changeset attached | => LimeSurvey 3.x-LTS 5ad41fef |
2023-05-19 13:04 | DenisChenu | Note Added: 75106 | |
2023-05-19 13:04 | DenisChenu | Changeset attached | => LimeSurvey 3.x-LTS 5ad41fef |
2023-05-19 13:04 | DenisChenu | Note Added: 75107 | |
2023-05-19 13:04 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2023-05-19 13:04 | DenisChenu | Resolution | reopened => fixed |
2023-05-19 13:04 | DenisChenu | Assigned To | tibor.pacalat => DenisChenu |
2023-05-19 13:04 | DenisChenu | Resolution | reopened => fixed |
2023-05-19 13:05 | tibor.pacalat | Status | ready for testing => closed |
2023-05-19 13:05 | tibor.pacalat | Note Added: 75108 | |
2023-05-19 13:14 | DenisChenu | Changeset attached | => LimeSurvey 5.x a7067937 |
2023-05-19 13:14 | DenisChenu | Note Added: 75110 | |
2023-06-01 17:44 | adamzammit | Changeset attached | => LimeSurvey 3.x-LTS 6cd2e8b8 |
2023-06-01 17:44 | adamzammit | Note Added: 75373 | |
2023-06-01 17:44 | adamzammit | Bug heat | 12 => 14 |
2023-06-01 17:44 | adamzammit | Assigned To | DenisChenu => adamzammit |