View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
18747Bug reportsSurvey editingpublic2023-04-14 13:442023-05-05 17:56
Reporterriqcles Assigned ToDenisChenu  
PriorityhighSeverityminor 
Status closedResolutionfixed 
Product Version6.0.x 
Summary18747: general settings - user administration - reserved words
Description

When you click to display the reserved words, the page freezes.
Forced to return to the previous page (browser button) to regain control.

Steps To Reproduce

Steps to reproduce

Go to <general settings>
user administration
Choose add reserved words

Expected result

windows popup

Actual result

nothing

TagsNo tags attached.
Attached Files
Administration utilisateur.png (48,718 bytes)   
Administration utilisateur.png (48,718 bytes)   
Bug heat8
Complete LimeSurvey version number (& build)version 6.0.1 +230411
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionPostgresql 15
Server OS (if known)centos 7.9
Webserver software & version (if known)
PHP VersionPHP 8.2.2

Relationships

Relationship GraphDependency Graph
related to 18343 closedadamzammit Problem with interpreting double slash in an URL (IIS) 

Users monitoring this issue

There are no users monitoring this issue.

Activities

tibor.pacalat

tibor.pacalat

2023-04-27 10:21

administrator   ~74674

@gabrieljenik @DenisChenu who can take this one?
DenisChenu

DenisChenu

2023-04-27 10:46

developer   ~74675

It's a major issue ?
Why priority is high ?
This don't really broke Public survey, and there are no real feature broken here.

I think this one : https://bugs.limesurvey.org/view.php?id=18725 (for example) are more dangerous.
DenisChenu

DenisChenu

2023-04-27 10:46

developer   ~74676

Or this one : 18787: Wrong default answers are loaded for multilingual surveys
https://bugs.limesurvey.org/view.php?id=18787
DenisChenu

DenisChenu

2023-04-27 10:47

developer   ~74677

I take a look to see if there are a quick solution before asign it to me.

Other seems to be worst in my opinion.
tibor.pacalat

tibor.pacalat

2023-04-27 10:52

administrator   ~74678

This is what Jory told me needs to be fixed.
DenisChenu

DenisChenu

2023-04-27 11:06

developer   ~74679

Seems related to another issue i fix in 5.X
DenisChenu

DenisChenu

2023-04-27 11:21

developer   ~74680

Related to https://bugs.limesurvey.org/view.php?id=18343
DenisChenu

DenisChenu

2023-04-27 11:56

developer   ~74682

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34558
DenisChenu

DenisChenu

2023-04-27 12:10

developer   ~74684

5.X have same issue, but wait the other needed fix to create new PR
DenisChenu

DenisChenu

2023-04-27 15:56

developer   ~74707

https://github.com/LimeSurvey/LimeSurvey/pull/3087
LimeBot

LimeBot

2023-05-02 10:20

administrator   ~74738

Fixed in Release 6.0.5+230502
tibor.pacalat

tibor.pacalat

2023-05-04 10:29

administrator   ~74801

why was this closed by LimeBot?
DenisChenu

DenisChenu

2023-05-04 10:32

developer   ~74803

Becaus ei made an error , pusgh to master, rvert just after …

https://github.com/LimeSurvey/LimeSurvey/commit/1be8c9f985fb71db63774ccd218a933f6d2014b9
tibor.pacalat

tibor.pacalat

2023-05-04 12:42

administrator   ~74806

Last edited: 2023-05-04 12:43

@DenisChenu it works now after the fix, but I am wondering why there are no vars. Do I need to do something (like define them somewhere) to see them?

Also, I am seeing this error in my dev console:
Uncaught TypeError: Cannot set properties of undefined (setting 'selectedIndex')
at Object.setup (limereplacementfields.js?t=N1FC:39:75)

Screenshot 2023-05-04 at 12.40.20.png (75,142 bytes)   
Screenshot 2023-05-04 at 12.40.20.png (75,142 bytes)   
DenisChenu

DenisChenu

2023-05-04 15:51

developer   ~74815

it works now after the fix, but I am wondering why there are no vars. Do I need to do something (like define them somewhere) to see them?

Because the var was not set : it was case since start. New feature to add it ?
Different fix , new issue.

Uncaught TypeError: Cannot set properties of undefined (setting 'selectedIndex')

I check
riqcles

riqcles

2023-05-05 15:31

reporter   ~74841

Sorry, but for me it still doesn't work. I have a page frozen after choosing to display reserved words.
I tried on Firefox and Edge.
riqcles

riqcles

2023-05-05 15:31

reporter   ~74842

test version 6.0.5+230502
riqcles

riqcles

2023-05-05 15:34

reporter   ~74844

No problem in the questions, just for the administration part.

Placeholder question.png (60,681 bytes)   
Placeholder question.png (60,681 bytes)   
DenisChenu

DenisChenu

2023-05-05 15:37

developer   ~74846

It still not merged

Else about "No reserved word" : it's not included in https://github.com/LimeSurvey/LimeSurvey/blob/de2add74498e14b17d3367faf1a4bd52f168e9fa/application/controllers/LimereplacementfieldsController.php#L230

can be include, but it's another issue (i n my opinion)
tibor.pacalat

tibor.pacalat

2023-05-05 16:30

administrator   ~74854

Last edited: 2023-05-05 16:31

@DenisChenu do you want me to open a separate ticket for "no reserved words"?

If so, we can close this, but I will test again on Firefox just to be sure.
tibor.pacalat

tibor.pacalat

2023-05-05 16:33

administrator   ~74855

Works on Firefox as well.
DenisChenu

DenisChenu

2023-05-05 16:43

developer   ~74858

@DenisChenu do you want me to open a separate ticket for "no reserved words"?

I think it's best :)

If you want i fix it here : why not, but take more time (and my English need correction)
tibor.pacalat

tibor.pacalat

2023-05-05 16:43

administrator   ~74859

I created a separate issue for "no reserved words" https://bugs.limesurvey.org/view.php?id=18805
tibor.pacalat

tibor.pacalat

2023-05-05 17:45

administrator   ~74864

Merged.
DenisChenu

DenisChenu

2023-05-05 17:56

developer   ~74868

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34613
DenisChenu

DenisChenu

2023-05-05 17:56

developer   ~74869

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34614

Related Changesets

LimeSurvey: master cea4f2ca

2023-04-27 13:56

DenisChenu


Details Diff		 Fixed issue 18343: Problem with interpreting double slash in URL (IIS)
Fixed issue 18747: user administration email - reserved words send 403 error		 Affected Issues
18343, 18747
mod - application/config/version.php Diff File
mod - application/controllers/LimereplacementfieldsController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/htmleditor/pop_editor_view.php Diff File
mod - application/views/admin/survey/prepareEditorScript_view.php Diff File
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js Diff File

LimeSurvey: master c4d672c7

2023-05-05 19:44

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#3087)

* Fixed issue 18343: Problem with interpreting double slash in URL (IIS)
Fixed issue 18747: user administration email - reserved words send 403 error

* Dev: lowerCamelCase

* Dev: CS		 Affected Issues
18343, 18747
mod - application/controllers/LimereplacementfieldsController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/htmleditor/pop_editor_view.php Diff File
mod - application/views/admin/survey/prepareEditorScript_view.php Diff File
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js Diff File

LimeSurvey: master c4d672c7

2023-05-05 19:44

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 18343: Problem with interpreting double slash in URL (IIS) (#3087)

* Fixed issue 18343: Problem with interpreting double slash in URL (IIS)
Fixed issue 18747: user administration email - reserved words send 403 error

* Dev: lowerCamelCase

* Dev: CS		 Affected Issues
18343, 18747
mod - application/controllers/LimereplacementfieldsController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/htmleditor/pop_editor_view.php Diff File
mod - application/views/admin/survey/prepareEditorScript_view.php Diff File
mod - assets/packages/ckeditor/plugins/limereplacementfields/dialogs/limereplacementfields.js Diff File

Issue History

Date Modified Username Field Change
2023-04-14 13:44 riqcles New Issue
2023-04-14 13:44 riqcles File Added: Administration utilisateur.png
2023-04-17 20:16 c_schmitz Priority none => high
2023-04-24 11:11 p_teichmann Status new => confirmed
2023-04-27 10:21 tibor.pacalat Note Added: 74674
2023-04-27 10:21 tibor.pacalat Bug heat 0 => 2
2023-04-27 10:44 DenisChenu Assigned To => DenisChenu
2023-04-27 10:44 DenisChenu Status confirmed => assigned
2023-04-27 10:46 DenisChenu Note Added: 74675
2023-04-27 10:46 DenisChenu Bug heat 2 => 4
2023-04-27 10:46 DenisChenu Note Added: 74676
2023-04-27 10:46 DenisChenu Assigned To DenisChenu =>
2023-04-27 10:46 DenisChenu Status assigned => new
2023-04-27 10:47 DenisChenu Note Added: 74677
2023-04-27 10:52 tibor.pacalat Note Added: 74678
2023-04-27 11:05 DenisChenu Assigned To => DenisChenu
2023-04-27 11:05 DenisChenu Status new => assigned
2023-04-27 11:06 DenisChenu Note Added: 74679
2023-04-27 11:20 DenisChenu Relationship added related to 18343
2023-04-27 11:21 DenisChenu Note Added: 74680
2023-04-27 11:56 DenisChenu Changeset attached => LimeSurvey master cea4f2ca
2023-04-27 11:56 DenisChenu Note Added: 74682
2023-04-27 11:56 DenisChenu Resolution open => fixed
2023-04-27 12:10 DenisChenu Status assigned => ready for testing
2023-04-27 12:10 DenisChenu Note Added: 74684
2023-04-27 12:10 DenisChenu Assigned To DenisChenu => gabrieljenik
2023-04-27 12:10 DenisChenu Status ready for testing => ready for code review
2023-04-27 15:43 gabrieljenik Bug heat 4 => 6
2023-04-27 15:44 gabrieljenik Bug heat 6 => 4
2023-04-27 15:56 DenisChenu Note Added: 74707
2023-05-02 10:20 LimeBot Note Added: 74738
2023-05-02 10:20 LimeBot Status ready for code review => closed
2023-05-02 10:20 LimeBot Bug heat 4 => 6
2023-05-04 10:29 tibor.pacalat Note Added: 74801
2023-05-04 10:32 DenisChenu Note Added: 74803
2023-05-04 10:32 DenisChenu Assigned To gabrieljenik => tibor.pacalat
2023-05-04 10:32 DenisChenu Status closed => ready for testing
2023-05-04 12:42 tibor.pacalat Note Added: 74806
2023-05-04 12:42 tibor.pacalat File Added: Screenshot 2023-05-04 at 12.40.20.png
2023-05-04 12:43 tibor.pacalat Note Edited: 74806
2023-05-04 15:51 DenisChenu Note Added: 74815
2023-05-05 15:31 riqcles Note Added: 74841
2023-05-05 15:31 riqcles Bug heat 6 => 8
2023-05-05 15:31 riqcles Note Added: 74842
2023-05-05 15:34 riqcles Note Added: 74844
2023-05-05 15:34 riqcles File Added: Placeholder question.png
2023-05-05 15:37 DenisChenu Note Added: 74846
2023-05-05 16:30 tibor.pacalat Note Added: 74854
2023-05-05 16:31 tibor.pacalat Note Edited: 74854
2023-05-05 16:33 tibor.pacalat Note Added: 74855
2023-05-05 16:43 DenisChenu Note Added: 74858
2023-05-05 16:43 tibor.pacalat Note Added: 74859
2023-05-05 17:45 tibor.pacalat Status ready for testing => closed
2023-05-05 17:45 tibor.pacalat Note Added: 74864
2023-05-05 17:56 DenisChenu Changeset attached => LimeSurvey master c4d672c7
2023-05-05 17:56 DenisChenu Changeset attached => LimeSurvey master c4d672c7
2023-05-05 17:56 DenisChenu Note Added: 74868
2023-05-05 17:56 DenisChenu Assigned To tibor.pacalat => DenisChenu
2023-05-05 17:56 DenisChenu Note Added: 74869