| ID | Project | Category | View Status | Date Submitted | Last Update |
|---|---|---|---|---|---|
| 17488 | Bug reports | Survey editing | public | 2021-08-01 14:56 | 2023-06-01 17:44 |
| Reporter | tpartner | Assigned To | adamzammit | ||
| Priority | low | Severity | crash | ||
| Status | closed | Resolution | fixed | ||
| Product Version | 3.25.19 | ||||
| Target Version | 3.x | ||||
| Summary | 17488: Cannot view survey after updating to version 3.27.9 (also in LS5) with custom twig extension (breaks survey) | ||||
| Description | A fresh pull from GIT (3.x-LTS), updating to version 3.27.9, results in an error "Property "LSETwigViewRenderer.user_extensions" is not defined." when trying to execute or preview a survey or editing a survey theme. For execute survey or edit theme, debug=0, see capture_2.png. | ||||
| Tags | No tags attached. | ||||
| Bug heat | 18 | ||||
| Complete LimeSurvey version number (& build) | LS5 | ||||
| I will donate to the project if issue is resolved | No | ||||
| Browser | n/a | ||||
| Database type & version | libmysql - mysqlnd 5.0.12-dev | ||||
| Server OS (if known) | Windows 10 | ||||
| Webserver software & version (if known) | Apache/2.4.39 (Win64) | ||||
| PHP Version | 7.3.7 | ||||
 |
accessible_vanilla ? |
|
|
https://gitlab.com/SondagesPro/SurveyThemes/accessible_vanilla ? |
 |
Reverting to release 3.26.3+210511 fixes it. |
|
|
All themes. |
 |
Debug = 2 and stacktrace? |
|
|
Oh, stacktrace was in other pic, sorry. |
|
|
No one reported this from our hosting. Strange. |
|
|
Can it be reproduced on a fresh install? |
|
|
No. The problem appears when I set 'use_custom_twig_extensions'=>true in config.php. Have we scrapped custom twig extensions? |
|
|
Uh, not that I know of. Denis? |
|
|
I never use this. Louis add it. |
|
|
I don't see any difference in the code between 3.x and master here. application/core/LSYii_Application.php: $aApplicationConfig['components']['twigRenderer']['user_extensions'][] = $extensionClass; |
|
|
Any ideas? Can you help us reproduce it? |
|
|
Did you try 'use_custom_twig_extensions'=>true in config.php, and testing a custom twig extension? Louis has some readme files in /upload/twig/extensions. |
|
|
How? |
|
|
Place this in a survey theme twig file - {{ helloWorld() }}. It will fire Louis' helloWorld() sample function and return "Hello world". Or, for a sample with a little HTML, upload the attached extension file to /upload/twig/extensions/ and add this to the twig file - {{ testFunction1() | raw }}. |
|
|
Got it, thanks! |
|
|
I confirm the error. However, I think the report should be "using custom twig extension breaks survey" since it does not happen for normal customization of themes without using twig extension. |
 |
any news on this? in YIIbase.php 227 is it crashing. Property "LSETwigViewRenderer.user_extensions, we make "new" there, for LSETwigViewRenderer. Mustn't the class have the property "user_extensions".? It does not! I can't find this in 3.26, too. |
|
|
That is your opinion, not mine! Are you just going to ignore the bug? |
|
|
There are more than 1000 bugs affecting 70% of all users. We do not have the resources to fix a bug that affects only 2% of our users and would take a lot of time to figure out. We are always happy to get a PR. |
|
|
Another one of my bugs ignored. If you cannot support it, the feature should probably be removed. Please don't condescendingly give me the gears about a pull request. I already spend A LOT of volunteer time for LimeSurvey. |
|
|
Correction : «If you cannot support it, the feature should probably never be added» I really think sometimes some feature was added without real idea of all work to be done to fix it, improve it and maintain at long term issue … |
|
|
Adding unit tests is really the only safe way to make sure a feature stays supported. @galads Interested in fixing this? |
|
|
Wait sorry, I mean @gabrieljenik, sorry ^^ |
 |
The ETwigViewRenderer class from yiiext/twig-renderer was already updated by Lime. Since that is a third-party, we applied the updated back but this time in LSETwigViewRenderer (which extends ETwigViewRenderer) so they don't get lost again. |
|
|
@tpartner : maybe you can test the commit ? |
|
|
@gabrieljenik, thanks. @DenisChenu, the commit fixes the problem in 3.28.18. It also fixes the problem when I apply it to application/core/LSETwigViewRenderer.php in 5.3.19. Should we open a new bug for that? |
|
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33633 |
|
|
Nope, we will create a new PR. Thanks |
|
|
@gabrieljenik, of course, no problem. |
|
|
Fixed in Release 3.28.19+220712 |
|
|
Why is this closed? Was it fixed in 5.x? |
|
|
It's automatically closed by our release tool if there's a commit phrased like "Fixed issue <bug number>". Is the issue reported for LS5 too? |
|
|
Please see the thread above. capture-3.png (41,595 bytes) |
|
|
@tpartner: Can I as for your help testing the patch for master? Thanks for the help! |
|
|
@gabrieljenik, sorry for the delay. Tested - all good! Thanks. |
|
|
Thanks @tpartner ! |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33699 |
|
|
Fixed in Release 5.3.30+220808 |
|
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34757 |
