View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18562 | Bug reports | Survey taking | public | 2022-12-19 14:58 | 2023-01-30 17:38 |
Reporter | DenisChenu | Assigned To | ollehar | ||
Priority | high | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.28.x | ||||
Summary | 18562: Upload question type : any image shown as invalid and Upload file disappear | ||||
Description | When try to upload fin question type : there are 2 issues
| ||||
Steps To Reproduce | Steps to reproduceImport included survey Expected result#1 : image are shown Actual result(Write here what happened instead) | ||||
Tags | No tags attached. | ||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | 3.28.2 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 18603 | ready for testing | Set Minimum number of files for File Upload not working |
User List | adamzammit |
---|
limesurvey_survey_UploadBroken.lss (15,003 bytes)
<?xml version="1.0" encoding="UTF-8"?> <document> <LimeSurveyDocType>Survey</LimeSurveyDocType> <DBVersion>366</DBVersion> <languages> <language>en</language> </languages> <groups> <fields> <fieldname>gid</fieldname> <fieldname>sid</fieldname> <fieldname>group_name</fieldname> <fieldname>group_order</fieldname> <fieldname>description</fieldname> <fieldname>language</fieldname> <fieldname>randomization_group</fieldname> <fieldname>grelevance</fieldname> </fields> <rows> <row> <gid><![CDATA[1]]></gid> <sid><![CDATA[136931]]></sid> <group_name><![CDATA[My first question group]]></group_name> <group_order><![CDATA[1]]></group_order> <description/> <language><![CDATA[en]]></language> <randomization_group/> <grelevance><![CDATA[1]]></grelevance> </row> </rows> </groups> <questions> <fields> <fieldname>qid</fieldname> <fieldname>parent_qid</fieldname> <fieldname>sid</fieldname> <fieldname>gid</fieldname> <fieldname>type</fieldname> <fieldname>title</fieldname> <fieldname>question</fieldname> <fieldname>preg</fieldname> <fieldname>help</fieldname> <fieldname>other</fieldname> <fieldname>mandatory</fieldname> <fieldname>question_order</fieldname> <fieldname>language</fieldname> <fieldname>scale_id</fieldname> <fieldname>same_default</fieldname> <fieldname>relevance</fieldname> <fieldname>modulename</fieldname> </fields> <rows> <row> <qid><![CDATA[1]]></qid> <parent_qid><![CDATA[0]]></parent_qid> <sid><![CDATA[136931]]></sid> <gid><![CDATA[1]]></gid> <type><![CDATA[T]]></type> <title><![CDATA[Q00]]></title> <question><![CDATA[A first example question. Please answer this question:]]></question> <preg/> <help><![CDATA[This is a question help text.]]></help> <other><![CDATA[N]]></other> <mandatory><![CDATA[Y]]></mandatory> <question_order><![CDATA[1]]></question_order> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> <same_default><![CDATA[0]]></same_default> <relevance><![CDATA[1]]></relevance> <modulename/> </row> <row> <qid><![CDATA[2]]></qid> <parent_qid><![CDATA[0]]></parent_qid> <sid><![CDATA[136931]]></sid> <gid><![CDATA[1]]></gid> <type><![CDATA[|]]></type> <title><![CDATA[Upload]]></title> <question><![CDATA[Upload a file : move next, file disappear]]></question> <preg/> <help/> <other><![CDATA[N]]></other> <mandatory><![CDATA[N]]></mandatory> <question_order><![CDATA[2]]></question_order> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> <same_default><![CDATA[0]]></same_default> <relevance><![CDATA[1]]></relevance> </row> </rows> </questions> <surveys> <fields> <fieldname>sid</fieldname> <fieldname>gsid</fieldname> <fieldname>admin</fieldname> <fieldname>expires</fieldname> <fieldname>startdate</fieldname> <fieldname>adminemail</fieldname> <fieldname>anonymized</fieldname> <fieldname>faxto</fieldname> <fieldname>format</fieldname> <fieldname>savetimings</fieldname> <fieldname>template</fieldname> <fieldname>language</fieldname> <fieldname>additional_languages</fieldname> <fieldname>datestamp</fieldname> <fieldname>usecookie</fieldname> <fieldname>allowregister</fieldname> <fieldname>allowsave</fieldname> <fieldname>autonumber_start</fieldname> <fieldname>autoredirect</fieldname> <fieldname>allowprev</fieldname> <fieldname>printanswers</fieldname> <fieldname>ipaddr</fieldname> <fieldname>refurl</fieldname> <fieldname>showsurveypolicynotice</fieldname> <fieldname>publicstatistics</fieldname> <fieldname>publicgraphs</fieldname> <fieldname>listpublic</fieldname> <fieldname>htmlemail</fieldname> <fieldname>sendconfirmation</fieldname> <fieldname>tokenanswerspersistence</fieldname> <fieldname>assessments</fieldname> <fieldname>usecaptcha</fieldname> <fieldname>usetokens</fieldname> <fieldname>bounce_email</fieldname> <fieldname>attributedescriptions</fieldname> <fieldname>emailresponseto</fieldname> <fieldname>emailnotificationto</fieldname> <fieldname>tokenlength</fieldname> <fieldname>showxquestions</fieldname> <fieldname>showgroupinfo</fieldname> <fieldname>shownoanswer</fieldname> <fieldname>showqnumcode</fieldname> <fieldname>bouncetime</fieldname> <fieldname>bounceprocessing</fieldname> <fieldname>bounceaccounttype</fieldname> <fieldname>bounceaccounthost</fieldname> <fieldname>bounceaccountpass</fieldname> <fieldname>bounceaccountencryption</fieldname> <fieldname>bounceaccountuser</fieldname> <fieldname>showwelcome</fieldname> <fieldname>showprogress</fieldname> <fieldname>questionindex</fieldname> <fieldname>navigationdelay</fieldname> <fieldname>nokeyboard</fieldname> <fieldname>alloweditaftercompletion</fieldname> <fieldname>googleanalyticsstyle</fieldname> <fieldname>googleanalyticsapikey</fieldname> </fields> <rows> <row> <sid><![CDATA[136931]]></sid> <gsid><![CDATA[1]]></gsid> <admin><![CDATA[Denis Chenu]]></admin> <adminemail><![CDATA[denis@sondages.pro]]></adminemail> <anonymized><![CDATA[N]]></anonymized> <faxto/> <format><![CDATA[G]]></format> <savetimings><![CDATA[N]]></savetimings> <template><![CDATA[fruity]]></template> <language><![CDATA[en]]></language> <additional_languages/> <datestamp><![CDATA[N]]></datestamp> <usecookie><![CDATA[N]]></usecookie> <allowregister><![CDATA[N]]></allowregister> <allowsave><![CDATA[Y]]></allowsave> <autonumber_start><![CDATA[0]]></autonumber_start> <autoredirect><![CDATA[N]]></autoredirect> <allowprev><![CDATA[N]]></allowprev> <printanswers><![CDATA[N]]></printanswers> <ipaddr><![CDATA[N]]></ipaddr> <refurl><![CDATA[N]]></refurl> <showsurveypolicynotice><![CDATA[0]]></showsurveypolicynotice> <publicstatistics><![CDATA[N]]></publicstatistics> <publicgraphs><![CDATA[N]]></publicgraphs> <listpublic><![CDATA[N]]></listpublic> <htmlemail><![CDATA[Y]]></htmlemail> <sendconfirmation><![CDATA[Y]]></sendconfirmation> <tokenanswerspersistence><![CDATA[N]]></tokenanswerspersistence> <assessments><![CDATA[N]]></assessments> <usecaptcha><![CDATA[N]]></usecaptcha> <usetokens><![CDATA[N]]></usetokens> <bounce_email><![CDATA[denis@sondages.pro]]></bounce_email> <emailresponseto/> <emailnotificationto/> <tokenlength><![CDATA[15]]></tokenlength> <showxquestions><![CDATA[Y]]></showxquestions> <showgroupinfo><![CDATA[B]]></showgroupinfo> <shownoanswer><![CDATA[N]]></shownoanswer> <showqnumcode><![CDATA[X]]></showqnumcode> <bounceprocessing><![CDATA[N]]></bounceprocessing> <showwelcome><![CDATA[Y]]></showwelcome> <showprogress><![CDATA[Y]]></showprogress> <questionindex><![CDATA[0]]></questionindex> <navigationdelay><![CDATA[0]]></navigationdelay> <nokeyboard><![CDATA[N]]></nokeyboard> <alloweditaftercompletion><![CDATA[N]]></alloweditaftercompletion> </row> </rows> </surveys> <surveys_languagesettings> <fields> <fieldname>surveyls_survey_id</fieldname> <fieldname>surveyls_language</fieldname> <fieldname>surveyls_title</fieldname> <fieldname>surveyls_description</fieldname> <fieldname>surveyls_welcometext</fieldname> <fieldname>surveyls_endtext</fieldname> <fieldname>surveyls_policy_notice</fieldname> <fieldname>surveyls_policy_error</fieldname> <fieldname>surveyls_policy_notice_label</fieldname> <fieldname>surveyls_url</fieldname> <fieldname>surveyls_urldescription</fieldname> <fieldname>surveyls_email_invite_subj</fieldname> <fieldname>surveyls_email_invite</fieldname> <fieldname>surveyls_email_remind_subj</fieldname> <fieldname>surveyls_email_remind</fieldname> <fieldname>surveyls_email_register_subj</fieldname> <fieldname>surveyls_email_register</fieldname> <fieldname>surveyls_email_confirm_subj</fieldname> <fieldname>surveyls_email_confirm</fieldname> <fieldname>surveyls_dateformat</fieldname> <fieldname>surveyls_attributecaptions</fieldname> <fieldname>email_admin_notification_subj</fieldname> <fieldname>email_admin_notification</fieldname> <fieldname>email_admin_responses_subj</fieldname> <fieldname>email_admin_responses</fieldname> <fieldname>surveyls_numberformat</fieldname> <fieldname>attachments</fieldname> </fields> <rows> <row> <surveyls_survey_id><![CDATA[136931]]></surveyls_survey_id> <surveyls_language><![CDATA[en]]></surveyls_language> <surveyls_title><![CDATA[Test upload file]]></surveyls_title> <surveyls_description/> <surveyls_welcometext/> <surveyls_endtext/> <surveyls_url/> <surveyls_urldescription/> <surveyls_email_invite_subj><![CDATA[Invitation to participate in a survey]]></surveyls_email_invite_subj> <surveyls_email_invite><![CDATA[Dear {FIRSTNAME},<br /> <br /> You have been invited to participate in a survey.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}<br /> <br /> If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:<br /> {OPTINURL}]]></surveyls_email_invite> <surveyls_email_remind_subj><![CDATA[Reminder to participate in a survey]]></surveyls_email_remind_subj> <surveyls_email_remind><![CDATA[Dear {FIRSTNAME},<br /> <br /> Recently we invited you to participate in a survey.<br /> <br /> We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}]]></surveyls_email_remind> <surveyls_email_register_subj><![CDATA[Survey registration confirmation]]></surveyls_email_register_subj> <surveyls_email_register><![CDATA[Dear {FIRSTNAME},<br /> <br /> You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.<br /> <br /> To complete this survey, click on the following URL:<br /> <br /> {SURVEYURL}<br /> <br /> If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.]]></surveyls_email_register> <surveyls_email_confirm_subj><![CDATA[Confirmation of your participation in our survey]]></surveyls_email_confirm_subj> <surveyls_email_confirm><![CDATA[Dear {FIRSTNAME},<br /> <br /> This email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.<br /> <br /> If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME}]]></surveyls_email_confirm> <surveyls_dateformat><![CDATA[1]]></surveyls_dateformat> <email_admin_notification_subj><![CDATA[Response submission for survey {SURVEYNAME}]]></email_admin_notification_subj> <email_admin_notification><![CDATA[Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}]]></email_admin_notification> <email_admin_responses_subj><![CDATA[Response submission for survey {SURVEYNAME} with results]]></email_admin_responses_subj> <email_admin_responses><![CDATA[Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}<br /> <br /> <br /> The following answers were given by the participant:<br /> {ANSWERTABLE}]]></email_admin_responses> <surveyls_numberformat><![CDATA[0]]></surveyls_numberformat> </row> </rows> </surveys_languagesettings> <themes> <theme> <sid>136931</sid> <template_name>fruity</template_name> <config> <options>inherit</options> </config> </theme> </themes> <themes_inherited> <theme> <sid>136931</sid> <template_name>fruity</template_name> <config> <options> <ajaxmode>off</ajaxmode> <brandlogo>on</brandlogo> <brandlogofile>./files/logo.png</brandlogofile> <container>on</container> <backgroundimage>off</backgroundimage> <animatebody>off</animatebody> <bodyanimation>fadeInRight</bodyanimation> <bodyanimationduration>500</bodyanimationduration> <animatequestion>off</animatequestion> <questionanimation>flipInX</questionanimation> <questionanimationduration>500</questionanimationduration> <animatealert>off</animatealert> <alertanimation>shake</alertanimation> <alertanimationduration>500</alertanimationduration> <font>noto</font> <bodybackgroundcolor>#ffffff</bodybackgroundcolor> <fontcolor>#444444</fontcolor> <questionbackgroundcolor>#ffffff</questionbackgroundcolor> <questionborder>on</questionborder> <questioncontainershadow>on</questioncontainershadow> <checkicon>f00c</checkicon> <animatecheckbox>on</animatecheckbox> <checkboxanimation>rubberBand</checkboxanimation> <checkboxanimationduration>500</checkboxanimationduration> <animateradio>on</animateradio> <radioanimation>zoomIn</radioanimation> <radioanimationduration>500</radioanimationduration> <zebrastriping>off</zebrastriping> <stickymatrixheaders>off</stickymatrixheaders> <greyoutselected>off</greyoutselected> <hideprivacyinfo>off</hideprivacyinfo> <crosshover>off</crosshover> <showpopups>1</showpopups> </options> </config> </theme> </themes_inherited> </document> |
|
git checkout f6ad186d2c6319642f189031d0a819696bb27333 : OK work as expected. This commit broke : https://github.com/LimeSurvey/LimeSurvey/commit/cc70269d03206cba6683367fa8e9a6e56c72a71a |
|
@gabrieljenik : can you find time for this issue ? All upload question type are broken currently |
|
Yes, I will review it |
|
Updated priority |
|
Oups sorry, i think i set Severity to partial_block |
|
Will upload something today.
Wasn't this. |
|
I check with checkout to f6ad186d2c6319642f189031d0a819696bb27333 (before) : it working good. I really test it |
|
A validation was added on the fieldname to make sure that fields from another survey cannot be accessed. But he added it even for "filegetcontents" requests, which don't use the field name. If the security fix was to validate that a file from another field (from another survey?) could not be displayed, you have to change it from the frontend, as to add the fieldname to the url. But I don't think that's the case. Apart from this, that controller needs a refactor. 1) Display the content of the upload modal |
|
|
|
@gabrieljenik : if you want i can take the image not shown issue (just create a mantis and assign it to me).
Yes, sure, but keep $_SESSION check must be done too :) |
|
Probably will. Let me dig a bit on that commit, as I believe there are some reversions involved. |
|
New code commited |
|
Tested OK |
|
limesurvey_survey_UploadBrokenWithPrevious.lss (15,889 bytes)
<?xml version="1.0" encoding="UTF-8"?> <document> <LimeSurveyDocType>Survey</LimeSurveyDocType> <DBVersion>366</DBVersion> <languages> <language>en</language> </languages> <groups> <fields> <fieldname>gid</fieldname> <fieldname>sid</fieldname> <fieldname>group_name</fieldname> <fieldname>group_order</fieldname> <fieldname>description</fieldname> <fieldname>language</fieldname> <fieldname>randomization_group</fieldname> <fieldname>grelevance</fieldname> </fields> <rows> <row> <gid><![CDATA[1]]></gid> <sid><![CDATA[136931]]></sid> <group_name><![CDATA[My first question group]]></group_name> <group_order><![CDATA[1]]></group_order> <description/> <language><![CDATA[en]]></language> <randomization_group/> <grelevance><![CDATA[1]]></grelevance> </row> <row> <gid><![CDATA[2]]></gid> <sid><![CDATA[136931]]></sid> <group_name><![CDATA[Next]]></group_name> <group_order><![CDATA[2]]></group_order> <description/> <language><![CDATA[en]]></language> <randomization_group/> <grelevance/> </row> </rows> </groups> <questions> <fields> <fieldname>qid</fieldname> <fieldname>parent_qid</fieldname> <fieldname>sid</fieldname> <fieldname>gid</fieldname> <fieldname>type</fieldname> <fieldname>title</fieldname> <fieldname>question</fieldname> <fieldname>preg</fieldname> <fieldname>help</fieldname> <fieldname>other</fieldname> <fieldname>mandatory</fieldname> <fieldname>question_order</fieldname> <fieldname>language</fieldname> <fieldname>scale_id</fieldname> <fieldname>same_default</fieldname> <fieldname>relevance</fieldname> <fieldname>modulename</fieldname> </fields> <rows> <row> <qid><![CDATA[1]]></qid> <parent_qid><![CDATA[0]]></parent_qid> <sid><![CDATA[136931]]></sid> <gid><![CDATA[1]]></gid> <type><![CDATA[T]]></type> <title><![CDATA[Q00]]></title> <question><![CDATA[A first example question. Please answer this question:]]></question> <preg/> <help><![CDATA[This is a question help text.]]></help> <other><![CDATA[N]]></other> <mandatory><![CDATA[Y]]></mandatory> <question_order><![CDATA[1]]></question_order> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> <same_default><![CDATA[0]]></same_default> <relevance><![CDATA[1]]></relevance> <modulename/> </row> <row> <qid><![CDATA[2]]></qid> <parent_qid><![CDATA[0]]></parent_qid> <sid><![CDATA[136931]]></sid> <gid><![CDATA[1]]></gid> <type><![CDATA[|]]></type> <title><![CDATA[Upload]]></title> <question><![CDATA[Upload a file : move next, file disappear]]></question> <preg/> <help/> <other><![CDATA[N]]></other> <mandatory><![CDATA[N]]></mandatory> <question_order><![CDATA[2]]></question_order> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> <same_default><![CDATA[0]]></same_default> <relevance><![CDATA[1]]></relevance> </row> <row> <qid><![CDATA[3]]></qid> <parent_qid><![CDATA[0]]></parent_qid> <sid><![CDATA[136931]]></sid> <gid><![CDATA[2]]></gid> <type><![CDATA[T]]></type> <title><![CDATA[Q01]]></title> <question/> <preg/> <help/> <other><![CDATA[N]]></other> <mandatory><![CDATA[N]]></mandatory> <question_order><![CDATA[1]]></question_order> <language><![CDATA[en]]></language> <scale_id><![CDATA[0]]></scale_id> <same_default><![CDATA[0]]></same_default> <relevance><![CDATA[1]]></relevance> </row> </rows> </questions> <surveys> <fields> <fieldname>sid</fieldname> <fieldname>gsid</fieldname> <fieldname>admin</fieldname> <fieldname>expires</fieldname> <fieldname>startdate</fieldname> <fieldname>adminemail</fieldname> <fieldname>anonymized</fieldname> <fieldname>faxto</fieldname> <fieldname>format</fieldname> <fieldname>savetimings</fieldname> <fieldname>template</fieldname> <fieldname>language</fieldname> <fieldname>additional_languages</fieldname> <fieldname>datestamp</fieldname> <fieldname>usecookie</fieldname> <fieldname>allowregister</fieldname> <fieldname>allowsave</fieldname> <fieldname>autonumber_start</fieldname> <fieldname>autoredirect</fieldname> <fieldname>allowprev</fieldname> <fieldname>printanswers</fieldname> <fieldname>ipaddr</fieldname> <fieldname>refurl</fieldname> <fieldname>showsurveypolicynotice</fieldname> <fieldname>publicstatistics</fieldname> <fieldname>publicgraphs</fieldname> <fieldname>listpublic</fieldname> <fieldname>htmlemail</fieldname> <fieldname>sendconfirmation</fieldname> <fieldname>tokenanswerspersistence</fieldname> <fieldname>assessments</fieldname> <fieldname>usecaptcha</fieldname> <fieldname>usetokens</fieldname> <fieldname>bounce_email</fieldname> <fieldname>attributedescriptions</fieldname> <fieldname>emailresponseto</fieldname> <fieldname>emailnotificationto</fieldname> <fieldname>tokenlength</fieldname> <fieldname>showxquestions</fieldname> <fieldname>showgroupinfo</fieldname> <fieldname>shownoanswer</fieldname> <fieldname>showqnumcode</fieldname> <fieldname>bouncetime</fieldname> <fieldname>bounceprocessing</fieldname> <fieldname>bounceaccounttype</fieldname> <fieldname>bounceaccounthost</fieldname> <fieldname>bounceaccountpass</fieldname> <fieldname>bounceaccountencryption</fieldname> <fieldname>bounceaccountuser</fieldname> <fieldname>showwelcome</fieldname> <fieldname>showprogress</fieldname> <fieldname>questionindex</fieldname> <fieldname>navigationdelay</fieldname> <fieldname>nokeyboard</fieldname> <fieldname>alloweditaftercompletion</fieldname> <fieldname>googleanalyticsstyle</fieldname> <fieldname>googleanalyticsapikey</fieldname> </fields> <rows> <row> <sid><![CDATA[136931]]></sid> <gsid><![CDATA[1]]></gsid> <admin><![CDATA[Denis Chenu]]></admin> <adminemail><![CDATA[denis@sondages.pro]]></adminemail> <anonymized><![CDATA[N]]></anonymized> <faxto/> <format><![CDATA[G]]></format> <savetimings><![CDATA[N]]></savetimings> <template><![CDATA[fruity]]></template> <language><![CDATA[en]]></language> <additional_languages/> <datestamp><![CDATA[N]]></datestamp> <usecookie><![CDATA[N]]></usecookie> <allowregister><![CDATA[N]]></allowregister> <allowsave><![CDATA[Y]]></allowsave> <autonumber_start><![CDATA[9]]></autonumber_start> <autoredirect><![CDATA[N]]></autoredirect> <allowprev><![CDATA[Y]]></allowprev> <printanswers><![CDATA[N]]></printanswers> <ipaddr><![CDATA[N]]></ipaddr> <refurl><![CDATA[N]]></refurl> <showsurveypolicynotice><![CDATA[0]]></showsurveypolicynotice> <publicstatistics><![CDATA[N]]></publicstatistics> <publicgraphs><![CDATA[N]]></publicgraphs> <listpublic><![CDATA[N]]></listpublic> <htmlemail><![CDATA[Y]]></htmlemail> <sendconfirmation><![CDATA[Y]]></sendconfirmation> <tokenanswerspersistence><![CDATA[N]]></tokenanswerspersistence> <assessments><![CDATA[N]]></assessments> <usecaptcha><![CDATA[N]]></usecaptcha> <usetokens><![CDATA[N]]></usetokens> <bounce_email><![CDATA[denis@sondages.pro]]></bounce_email> <emailresponseto/> <emailnotificationto/> <tokenlength><![CDATA[15]]></tokenlength> <showxquestions><![CDATA[Y]]></showxquestions> <showgroupinfo><![CDATA[B]]></showgroupinfo> <shownoanswer><![CDATA[N]]></shownoanswer> <showqnumcode><![CDATA[X]]></showqnumcode> <bounceprocessing><![CDATA[N]]></bounceprocessing> <showwelcome><![CDATA[Y]]></showwelcome> <showprogress><![CDATA[Y]]></showprogress> <questionindex><![CDATA[0]]></questionindex> <navigationdelay><![CDATA[0]]></navigationdelay> <nokeyboard><![CDATA[N]]></nokeyboard> <alloweditaftercompletion><![CDATA[N]]></alloweditaftercompletion> <googleanalyticsstyle/> <googleanalyticsapikey/> </row> </rows> </surveys> <surveys_languagesettings> <fields> <fieldname>surveyls_survey_id</fieldname> <fieldname>surveyls_language</fieldname> <fieldname>surveyls_title</fieldname> <fieldname>surveyls_description</fieldname> <fieldname>surveyls_welcometext</fieldname> <fieldname>surveyls_endtext</fieldname> <fieldname>surveyls_policy_notice</fieldname> <fieldname>surveyls_policy_error</fieldname> <fieldname>surveyls_policy_notice_label</fieldname> <fieldname>surveyls_url</fieldname> <fieldname>surveyls_urldescription</fieldname> <fieldname>surveyls_email_invite_subj</fieldname> <fieldname>surveyls_email_invite</fieldname> <fieldname>surveyls_email_remind_subj</fieldname> <fieldname>surveyls_email_remind</fieldname> <fieldname>surveyls_email_register_subj</fieldname> <fieldname>surveyls_email_register</fieldname> <fieldname>surveyls_email_confirm_subj</fieldname> <fieldname>surveyls_email_confirm</fieldname> <fieldname>surveyls_dateformat</fieldname> <fieldname>surveyls_attributecaptions</fieldname> <fieldname>email_admin_notification_subj</fieldname> <fieldname>email_admin_notification</fieldname> <fieldname>email_admin_responses_subj</fieldname> <fieldname>email_admin_responses</fieldname> <fieldname>surveyls_numberformat</fieldname> <fieldname>attachments</fieldname> </fields> <rows> <row> <surveyls_survey_id><![CDATA[136931]]></surveyls_survey_id> <surveyls_language><![CDATA[en]]></surveyls_language> <surveyls_title><![CDATA[Test upload file]]></surveyls_title> <surveyls_description/> <surveyls_welcometext/> <surveyls_endtext/> <surveyls_url/> <surveyls_urldescription/> <surveyls_email_invite_subj><![CDATA[Invitation to participate in a survey]]></surveyls_email_invite_subj> <surveyls_email_invite><![CDATA[Dear {FIRSTNAME},<br /> <br /> You have been invited to participate in a survey.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}<br /> <br /> If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:<br /> {OPTINURL}]]></surveyls_email_invite> <surveyls_email_remind_subj><![CDATA[Reminder to participate in a survey]]></surveyls_email_remind_subj> <surveyls_email_remind><![CDATA[Dear {FIRSTNAME},<br /> <br /> Recently we invited you to participate in a survey.<br /> <br /> We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.<br /> <br /> The survey is titled:<br /> "{SURVEYNAME}"<br /> <br /> "{SURVEYDESCRIPTION}"<br /> <br /> To participate, please click on the link below.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME} ({ADMINEMAIL})<br /> <br /> ----------------------------------------------<br /> Click here to do the survey:<br /> {SURVEYURL}<br /> <br /> If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br /> {OPTOUTURL}]]></surveyls_email_remind> <surveyls_email_register_subj><![CDATA[Survey registration confirmation]]></surveyls_email_register_subj> <surveyls_email_register><![CDATA[Dear {FIRSTNAME},<br /> <br /> You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.<br /> <br /> To complete this survey, click on the following URL:<br /> <br /> {SURVEYURL}<br /> <br /> If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.]]></surveyls_email_register> <surveyls_email_confirm_subj><![CDATA[Confirmation of your participation in our survey]]></surveyls_email_confirm_subj> <surveyls_email_confirm><![CDATA[Dear {FIRSTNAME},<br /> <br /> This email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.<br /> <br /> If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.<br /> <br /> Sincerely,<br /> <br /> {ADMINNAME}]]></surveyls_email_confirm> <surveyls_dateformat><![CDATA[1]]></surveyls_dateformat> <email_admin_notification_subj><![CDATA[Response submission for survey {SURVEYNAME}]]></email_admin_notification_subj> <email_admin_notification><![CDATA[Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}]]></email_admin_notification> <email_admin_responses_subj><![CDATA[Response submission for survey {SURVEYNAME} with results]]></email_admin_responses_subj> <email_admin_responses><![CDATA[Hello,<br /> <br /> A new response was submitted for your survey '{SURVEYNAME}'.<br /> <br /> Click the following link to see the individual response:<br /> {VIEWRESPONSEURL}<br /> <br /> Click the following link to edit the individual response:<br /> {EDITRESPONSEURL}<br /> <br /> View statistics by clicking here:<br /> {STATISTICSURL}<br /> <br /> <br /> The following answers were given by the participant:<br /> {ANSWERTABLE}]]></email_admin_responses> <surveyls_numberformat><![CDATA[0]]></surveyls_numberformat> </row> </rows> </surveys_languagesettings> <themes> <theme> <sid>136931</sid> <template_name>fruity</template_name> <config> <options>inherit</options> </config> </theme> </themes> <themes_inherited> <theme> <sid>136931</sid> <template_name>fruity</template_name> <config> <options> <ajaxmode>off</ajaxmode> <brandlogo>on</brandlogo> <brandlogofile>./files/logo.png</brandlogofile> <container>on</container> <backgroundimage>off</backgroundimage> <animatebody>off</animatebody> <bodyanimation>fadeInRight</bodyanimation> <bodyanimationduration>500</bodyanimationduration> <animatequestion>off</animatequestion> <questionanimation>flipInX</questionanimation> <questionanimationduration>500</questionanimationduration> <animatealert>off</animatealert> <alertanimation>shake</alertanimation> <alertanimationduration>500</alertanimationduration> <font>noto</font> <bodybackgroundcolor>#ffffff</bodybackgroundcolor> <fontcolor>#444444</fontcolor> <questionbackgroundcolor>#ffffff</questionbackgroundcolor> <questionborder>on</questionborder> <questioncontainershadow>on</questioncontainershadow> <checkicon>f00c</checkicon> <animatecheckbox>on</animatecheckbox> <checkboxanimation>rubberBand</checkboxanimation> <checkboxanimationduration>500</checkboxanimationduration> <animateradio>on</animateradio> <radioanimation>zoomIn</radioanimation> <radioanimationduration>500</radioanimationduration> <zebrastriping>off</zebrastriping> <stickymatrixheaders>off</stickymatrixheaders> <greyoutselected>off</greyoutselected> <hideprivacyinfo>off</hideprivacyinfo> <crosshover>off</crosshover> <showpopups>1</showpopups> </options> </config> </theme> </themes_inherited> </document> |
|
Same here |
|
@ollehar : i have client waiting this issue to be fixed. Can we merge it this week ? |
|
Tested or not tested? Github comments are not clear. |
|
I test (but i'm the reviewer) |
|
It's OK for code reviewer to also test. :) It just shouldn't be tested ONLY by the developer. Gabriel has hired people to help with testing, I think. |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34242 |
|
\o/ Yes ! |
|
Fixed in Release 3.28.47+230131 |
|
@DenisChenu is this also happening on master? I ask you as I believe you will know better. |
|
master seems OK, but unsure it was fixed on same way … for the previous issue (about EM update in same page). |
|
LimeSurvey: 3.x-LTS 2b24b710 2023-01-26 11:13:27 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 18562: Upload question type partially broken (#2811) Co-authored-by: lapiudevgit <devgit@lapiu.biz> |
Affected Issues 18562 |
|
mod - application/config/version.php | Diff File | ||
mod - application/controllers/UploaderController.php | Diff File | ||
mod - application/helpers/qanda_helper.php | Diff File | ||
mod - assets/scripts/modaldialog.js | Diff File | ||
mod - assets/scripts/uploader.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-12-19 14:58 | DenisChenu | New Issue | |
2022-12-19 14:58 | DenisChenu | File Added: Peek 19-12-2022 14-53.gif | |
2022-12-19 14:58 | DenisChenu | File Added: limesurvey_survey_UploadBroken.lss | |
2022-12-19 14:59 | DenisChenu | Note Added: 73184 | |
2022-12-19 14:59 | DenisChenu | Bug heat | 0 => 2 |
2022-12-19 14:59 | DenisChenu | Assigned To | => gabrieljenik |
2022-12-19 14:59 | DenisChenu | Status | new => assigned |
2022-12-21 19:02 | DenisChenu | Note Added: 73248 | |
2022-12-21 20:26 | gabrieljenik | Note Added: 73249 | |
2022-12-21 20:26 | gabrieljenik | Bug heat | 2 => 4 |
2022-12-21 20:27 | gabrieljenik | Priority | none => high |
2022-12-21 20:27 | gabrieljenik | Severity | minor => partial_block |
2022-12-21 20:27 | gabrieljenik | Note Added: 73250 | |
2022-12-21 23:12 | DenisChenu | Note Added: 73253 | |
2022-12-22 14:13 | gabrieljenik | Note Added: 73278 | |
2022-12-22 14:50 | DenisChenu | Note Added: 73280 | |
2022-12-22 17:24 | gabrieljenik | Assigned To | gabrieljenik => DenisChenu |
2022-12-22 17:24 | gabrieljenik | Status | assigned => ready for code review |
2022-12-22 17:25 | gabrieljenik | Note Added: 73285 | |
2022-12-22 17:29 | gabrieljenik | Note Added: 73286 | |
2022-12-22 18:05 | DenisChenu | Status | ready for code review => assigned |
2022-12-22 18:05 | DenisChenu | Note Added: 73288 | |
2022-12-22 18:10 | DenisChenu | Note Added: 73289 | |
2022-12-22 18:11 | DenisChenu | Note Edited: 73289 | |
2022-12-22 18:11 | gabrieljenik | Note Added: 73290 | |
2022-12-22 22:18 | gabrieljenik | Note Added: 73292 | |
2022-12-23 08:40 | DenisChenu | Summary | Upload question type partially broken => Upload question type : any image shown as invalid |
2022-12-23 08:41 | DenisChenu | Severity | partial_block => minor |
2022-12-23 08:48 | DenisChenu | Summary | Upload question type : any image shown as invalid => Upload question type : any image shown as invalid and Upload file disappear |
2022-12-23 19:26 | DenisChenu | Assigned To | DenisChenu => |
2022-12-23 19:26 | DenisChenu | Status | assigned => in testing |
2022-12-23 19:26 | DenisChenu | Note Added: 73308 | |
2022-12-23 19:30 | DenisChenu | Note Added: 73309 | |
2022-12-23 19:30 | DenisChenu | File Added: limesurvey_survey_UploadBrokenWithPrevious.lss | |
2022-12-23 20:35 | gabrieljenik | Assigned To | => ollehar |
2022-12-23 20:35 | gabrieljenik | Status | in testing => ready for merge |
2023-01-03 15:33 | gabrieljenik | Note Added: 73336 | |
2023-01-09 08:58 | DenisChenu | Note Added: 73382 | |
2023-01-09 11:27 | ollehar | Note Added: 73397 | |
2023-01-09 11:27 | ollehar | Bug heat | 4 => 6 |
2023-01-09 11:29 | DenisChenu | Note Added: 73398 | |
2023-01-09 11:30 | ollehar | Note Added: 73399 | |
2023-01-12 00:53 | adamzammit | Issue Monitored: adamzammit | |
2023-01-12 00:53 | adamzammit | Bug heat | 6 => 8 |
2023-01-25 15:14 | DenisChenu | Relationship added | related to 18603 |
2023-01-26 11:13 | Changeset attached | => LimeSurvey 3.x-LTS 2b24b710 | |
2023-01-26 11:13 | guest | Note Added: 73575 | |
2023-01-26 11:13 | guest | Bug heat | 8 => 10 |
2023-01-26 11:30 | DenisChenu | Note Added: 73576 | |
2023-01-30 13:51 | LimeBot | Note Added: 73604 | |
2023-01-30 13:51 | LimeBot | Status | ready for merge => closed |
2023-01-30 13:51 | LimeBot | Resolution | open => fixed |
2023-01-30 13:51 | LimeBot | Bug heat | 10 => 12 |
2023-01-30 15:03 | gabrieljenik | Note Added: 73605 | |
2023-01-30 15:04 | DenisChenu | Note Added: 73606 | |
2023-01-30 17:38 | duvemyster | Issue Monitored: duvemyster | |
2023-01-30 17:38 | duvemyster | Bug heat | 12 => 14 |
2023-01-30 17:38 | duvemyster | Issue End Monitor: duvemyster | |
2023-01-30 17:38 | duvemyster | Bug heat | 14 => 12 |