Please Ignore this - just figure out i was being an idiot - already had a survey with that ID.

Please Ignore this - just figure out i was being an idiot - already had a survey with that ID.

My opinion : in this cas : we must add an warning somewhere , no ?

I agree with Denis - there should be a clear error message.

To be added in LS4 imo

Unsure : it's a minor issue but a minoir fix too (adding a App()->addFlashMessage) , i can look at 3.X if you want.

PR Master: https://github.com/LimeSurvey/LimeSurvey/pull/2663
If good, will do also for LTS

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34012

Fixed in Release 5.4.10+221107

To be applied on LTS as well

LTS: https://github.com/LimeSurvey/LimeSurvey/pull/2725

Tested in Version 5.4.11 - Not working - Create a new Survey by copy, use an ID previously used. Result No Error and Random ID is assigned.
Tested in Version 3.28.38 - Not working - Create a new Survey by copy, use an ID previously used. Result No Error and Random ID is assigned.

Sorry, just realised its not in the master yet, will pull the code and test again

Ok Tested in both versions

LTS - New Message next to optional and Warning message on submit - but both fairly easy to miss IMHO.
LS5 - New Message next to optional - No error message after submitting as in LTS.

However, easy to mis and by this point the error has already occurred. I would suggest it is more user friendly to use an alert message on submit or an ajax listener on the field. I did try and code this in PHP with a JS alert - but TBH my coding skills are not upto it.

However in Pseudo Code:

if (NewID == AnExistingID) {
Alert Message ("ID XXXXX already exists, if you continue a random ID will be created!")
OK --> Create New Survey with Random ID
Cancel --> Return to enter New ID manually

Or this can be done via Ajax before submitting

I wouldn't bother doing this in LTS - but would be cleaner to have in LS5+

LS5 - New Message next to optional - No error message after submitting as in LTS.

You didn't get a warning message? Are you sure?

Retested in LS5 - sorry your correct it is there - missed it.

However, easy to mis and by this point the error has already occurred. I would suggest it is more user friendly to use an alert message on submit or an ajax listener on the field

I would say we need a new Feature Request for that.
Please, feel free to open one.
Sorry.

Gabriel: Noted and agreed

Tested LTS

Yes Tested in LTS.
LTS - New Message next to optional and Warning message on submit

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34053

Fixed in Release 3.28.40+221129

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34757