View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
18811Bug reportsQuestion editorpublic2023-05-10 16:062023-05-16 11:11
Reportertibor.pacalat Assigned ToDenisChenu  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version6.0.x 
Summary18811: Button that triggers HTML editor in pop-up window doesn't work
Description

Button that triggers HTML editor in pop-up window doesn't work.

When I click on it I am getting an error:
Uncaught ReferenceError: fieldname is not defined

Steps To Reproduce

Steps to reproduce

  1. In question editor select multiple choice for example
  2. Click the green edit button near the option

Expected result

HTML editor should pop-up.

Actual result

Nothing happens. Error in dev console: Uncaught ReferenceError: fieldname is not defined

(Write here what happened instead)

TagsNo tags attached.
Attached Files
Screenshot 2023-05-10 at 15.45.25.png (19,293 bytes)   
Screenshot 2023-05-10 at 15.45.25.png (19,293 bytes)   
Bug heat4
Complete LimeSurvey version number (& build)6.0.6+230508
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version7.4.10

Relationships

Relationship GraphDependency Graph
child of 18343 closedadamzammit Problem with interpreting double slash in an URL (IIS) 

Users monitoring this issue

There are no users monitoring this issue.

Activities

tibor.pacalat

tibor.pacalat

2023-05-10 16:14

administrator   ~74918

It worked until this commit https://github.com/LimeSurvey/LimeSurvey/commit/c4d672c7fe57702f3db313fc0163b8b321310ba6.

@DenisChenu can you look into it?
DenisChenu

DenisChenu

2023-05-10 16:15

developer   ~74919

Warranty : yes
DenisChenu

DenisChenu

2023-05-10 18:37

developer   ~74921

6.X : https://github.com/LimeSurvey/LimeSurvey/pull/3129
DenisChenu

DenisChenu

2023-05-10 18:41

developer   ~74922

Not checked Label …
DenisChenu

DenisChenu

2023-05-10 18:47

developer   ~74923

Label set in 6 didn't use same popup : OK for 6
tibor.pacalat

tibor.pacalat

2023-05-11 10:29

administrator   ~74928

@DenisChenu it works now, but the styling of the button is different from what it was. Now it is green, it was white on the green background before.

Screenshot 2023-05-11 at 10.20.11.png (15,669 bytes)   
Screenshot 2023-05-11 at 10.20.11.png (15,669 bytes)   
Screenshot 2023-05-11 at 10.12.19.png (19,602 bytes)   
Screenshot 2023-05-11 at 10.12.19.png (19,602 bytes)   
DenisChenu

DenisChenu

2023-05-11 10:46

developer   ~74929

I think i don't update style here ?
I check :)

Maybe still the BS3 class name
DenisChenu

DenisChenu

2023-05-12 18:44

developer   ~74957

With master version i still have the totally green button
I reset to master …
DenisChenu

DenisChenu

2023-05-12 18:47

developer   ~74958

OK :)
Sorry got it …
DenisChenu

DenisChenu

2023-05-12 18:51

developer   ~74959

PS : i think another solution is better, removing the uneeded i nBS5 input-group-addon
Let me test.
DenisChenu

DenisChenu

2023-05-14 19:50

developer   ~74960

To be checked with Patrick maybe ?
DenisChenu

DenisChenu

2023-05-15 18:40

developer   ~74993

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34657
DenisChenu

DenisChenu

2023-05-15 18:40

developer   ~74994

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34658

Related Changesets

LimeSurvey: master 6c9cc797

2023-05-15 20:40

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 18811: Button that triggers HTML editor in pop-up window doesn't work

Dev: Review questionEditor script
Dev: placeholder without url encoded character
Dev: use $tr, not $row
Fix: Add single subquestion or answer
Dev: Fix button decoration		 Affected Issues
18811
mod - application/controllers/QuestionAdministrationController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/survey/Question/subquestionsAndAnswers/_subquestion.twig Diff File
mod - application/views/admin/survey/prepareEditorScript_view.php Diff File
mod - application/views/admin/token/invite.php Diff File
mod - application/views/admin/token/remind.php Diff File
mod - application/views/questionAdministration/answerOptionRow.twig Diff File
mod - application/views/questionAdministration/subquestionRow.twig Diff File
mod - assets/scripts/admin/questionEditor.js Diff File

LimeSurvey: master 6c9cc797

2023-05-15 20:40

DenisChenu

Committer: GitHub


Details Diff		 Fixed issue 18811: Button that triggers HTML editor in pop-up window doesn't work

Dev: Review questionEditor script
Dev: placeholder without url encoded character
Dev: use $tr, not $row
Fix: Add single subquestion or answer
Dev: Fix button decoration		 Affected Issues
18811
mod - application/controllers/QuestionAdministrationController.php Diff File
mod - application/helpers/admin/htmleditor_helper.php Diff File
mod - application/views/admin/survey/Question/subquestionsAndAnswers/_subquestion.twig Diff File
mod - application/views/admin/survey/prepareEditorScript_view.php Diff File
mod - application/views/admin/token/invite.php Diff File
mod - application/views/admin/token/remind.php Diff File
mod - application/views/questionAdministration/answerOptionRow.twig Diff File
mod - application/views/questionAdministration/subquestionRow.twig Diff File
mod - assets/scripts/admin/questionEditor.js Diff File

Issue History

Date Modified Username Field Change
2023-05-10 16:06 tibor.pacalat New Issue
2023-05-10 16:06 tibor.pacalat File Added: Screenshot 2023-05-10 at 15.45.25.png
2023-05-10 16:14 tibor.pacalat Note Added: 74918
2023-05-10 16:14 tibor.pacalat Bug heat 0 => 2
2023-05-10 16:15 DenisChenu Note Added: 74919
2023-05-10 16:15 DenisChenu Bug heat 2 => 4
2023-05-10 16:15 DenisChenu Assigned To => DenisChenu
2023-05-10 16:15 DenisChenu Status new => assigned
2023-05-10 18:32 DenisChenu Relationship added child of 18343
2023-05-10 18:37 DenisChenu Note Added: 74921
2023-05-10 18:41 DenisChenu Note Added: 74922
2023-05-10 18:47 DenisChenu Note Added: 74923
2023-05-11 10:29 tibor.pacalat Note Added: 74928
2023-05-11 10:29 tibor.pacalat File Added: Screenshot 2023-05-11 at 10.20.11.png
2023-05-11 10:29 tibor.pacalat File Added: Screenshot 2023-05-11 at 10.12.19.png
2023-05-11 10:46 DenisChenu Note Added: 74929
2023-05-12 18:44 DenisChenu Note Added: 74957
2023-05-12 18:47 DenisChenu Note Added: 74958
2023-05-12 18:51 DenisChenu Note Added: 74959
2023-05-14 19:49 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-05-14 19:50 DenisChenu Note Added: 74960
2023-05-15 18:40 DenisChenu Changeset attached => LimeSurvey master 6c9cc797
2023-05-15 18:40 DenisChenu Note Added: 74993
2023-05-15 18:40 DenisChenu Changeset attached => LimeSurvey master 6c9cc797
2023-05-15 18:40 DenisChenu Note Added: 74994
2023-05-15 18:40 DenisChenu Assigned To tibor.pacalat => DenisChenu
2023-05-15 18:40 DenisChenu Resolution open => fixed
2023-05-15 18:40 DenisChenu Assigned To tibor.pacalat => DenisChenu
2023-05-15 18:40 DenisChenu Resolution open => fixed
2023-05-16 11:11 tibor.pacalat Status assigned => closed