View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
18338Bug reportsSurvey participants (Tokens)public2022-11-15 10:28
Reportergabrieljenik Assigned To 
PrioritynoneSeverityminor 
Status ready for testingResolutionfixed 
Product Version5.3.x 
Summary18338: For participants, expiration date can be set before start date
Description

The application must ensure that only logically valid data can be entered at the front end as well as directly to the server side of an application of system.

Caught while reviewing:
15195: Expiration date can be set before start date

Steps To Reproduce

Application does not validate start and expiration date of a survey properly, start date can be set after expiration date.

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)5.x
I will donate to the project if issue is resolvedNo
Browser
Database type & versionMySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version7.0

Relationships

related to 15195 closedgabrieljenik Expiration date can be set before start date 

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2022-10-19 16:34

manager   ~72367

https://github.com/LimeSurvey/LimeSurvey/pull/2679

gabrieljenik

gabrieljenik

2022-10-19 16:36

manager   ~72368

Survey Settings should be reviewed as well as there has been some related code movement.
(15195 and 18314.)

gabrieljenik

gabrieljenik

2022-10-21 14:35

manager   ~72375

Tested OK

gabrieljenik

gabrieljenik

2022-11-02 13:43

manager   ~72516

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34015

LimeBot

LimeBot

2022-11-07 11:31

administrator   ~72584

Fixed in Release 5.4.10+221107

gabrieljenik

gabrieljenik

2022-11-07 14:07

manager   ~72608

To be applied on LTS as well

gabrieljenik

gabrieljenik

2022-11-14 20:32

manager   ~72734

LTS: https://github.com/LimeSurvey/LimeSurvey/pull/2726

Related Changesets

LimeSurvey: master 42cfc2d9

2022-11-02 13:43:17

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 18338: For participants, expiration date can be set before start date (#2679)

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
18338
mod - application/views/admin/token/tokenform.php Diff File
mod - assets/packages/adminbasics/build/adminbasics.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.min.css Diff File
mod - assets/packages/adminbasics/src/parts/globalMethods.js Diff File
mod - assets/scripts/admin/surveysettings.js Diff File
mod - assets/scripts/admin/tokens.js Diff File

LimeSurvey: master 263cb01b

2022-11-08 13:08:20

c_schmitz

Details Diff
Revert "Fixed issue 18338: For participants, expiration date can be set before start date (#2679)"

This reverts commit 42cfc2d9c6f7eb0302a8bddefa24d2203cb84339.
Affected Issues
18338
mod - application/views/admin/token/tokenform.php Diff File
mod - assets/packages/adminbasics/build/adminbasics.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.min.js Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.css Diff File
mod - assets/packages/adminbasics/build/adminbasics.rtl.min.css Diff File
mod - assets/packages/adminbasics/src/parts/globalMethods.js Diff File
mod - assets/scripts/admin/surveysettings.js Diff File
mod - assets/scripts/admin/tokens.js Diff File

Issue History

Date Modified Username Field Change
2022-09-08 17:26 gabrieljenik New Issue
2022-09-08 17:26 gabrieljenik Issue generated from: 15195
2022-09-08 17:26 gabrieljenik Relationship added related to 15195
2022-09-08 17:27 gabrieljenik Status new => confirmed
2022-10-17 21:42 gabrieljenik Summary Expiration date can be set before start date => For participants, expiration date can be set before start date
2022-10-19 16:34 gabrieljenik Assigned To => DenisChenu
2022-10-19 16:34 gabrieljenik Status confirmed => ready for code review
2022-10-19 16:34 gabrieljenik Note Added: 72367
2022-10-19 16:34 gabrieljenik Bug heat 0 => 2
2022-10-19 16:36 gabrieljenik Note Added: 72368
2022-10-21 14:35 gabrieljenik Note Added: 72375
2022-10-25 08:53 DenisChenu Assigned To DenisChenu => gabrieljenik
2022-10-25 08:53 DenisChenu Status ready for code review => in code review
2022-11-02 13:43 gabrieljenik Changeset attached => LimeSurvey master 42cfc2d9
2022-11-02 13:43 gabrieljenik Note Added: 72516
2022-11-02 13:43 gabrieljenik Resolution open => fixed
2022-11-07 11:31 LimeBot Note Added: 72584
2022-11-07 11:31 LimeBot Status in code review => closed
2022-11-07 11:31 LimeBot Bug heat 2 => 4
2022-11-07 14:07 gabrieljenik Status closed => assigned
2022-11-07 14:07 gabrieljenik Note Added: 72608
2022-11-08 13:06 c_schmitz Bug heat 4 => 6
2022-11-08 13:08 c_schmitz Changeset attached => LimeSurvey master 263cb01b
2022-11-08 13:08 c_schmitz Assigned To gabrieljenik => c_schmitz
2022-11-08 13:10 c_schmitz Bug heat 6 => 4
2022-11-14 20:32 gabrieljenik Status assigned => ready for code review
2022-11-14 20:32 gabrieljenik Note Added: 72734
2022-11-14 20:32 gabrieljenik Assigned To c_schmitz => DenisChenu
2022-11-15 10:28 DenisChenu Assigned To DenisChenu =>
2022-11-15 10:28 DenisChenu Status ready for code review => ready for testing