Dependency Graph
View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18186 | Bug reports | Survey taking | public | 2022-06-09 14:16 | 2022-06-27 14:01 |
Reporter | ritapas | Assigned To | DenisChenu | ||
Priority | none | Severity | block | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.28.x | ||||
Fixed in Version | 3.28.x | ||||
Summary | 18186: Language changer does not work in registration page | ||||
Description | the language changer button does not work in survey registration page | ||||
Steps To Reproduce | Steps to reproducecreate a survey with at least two languages, add a participant table and allow participants to register themselves. Activate survey and head to survey page. Try to change the language. Expected resultPage language should be changed Actual resultLanguage only changes when using Mozilla Firefox. With edge, language is not changed and no error in js console. With Chrome, language is not changed and console reports errors as in image. | ||||
Tags | No tags attached. | ||||
Bug heat | 20 | ||||
Complete LimeSurvey version number (& build) | 3.28.13 (build 220531) | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome Versione 102.0.5005.63 (Build ufficiale) (a 64 bit), Edge Versione 100.0.1185.44 (Build ufficiale) (64 bit) | ||||
Database type & version | mariadb 5.5.60 | ||||
Server OS (if known) | Red Hat Enterprise Linux Server release 7.5 (Maipo) | ||||
Webserver software & version (if known) | httpd-2.4.6-80 | ||||
PHP Version | rh-php71 | ||||
related to | 16024 | closed | DenisChenu | Language changer dropdown autoupdated : keyboard navigation issue |
|
|
I think this could have already been solved by 18128. Thanks! |
|
Hello, I've tried version 3.28.14 again with Chrome and Edge and the problem is still there even though the javascript error have disappeared, sorry |
|
Hi all, I performed some debugging and the problem is in the javascript that registers a listener to the "click" event onthe language chooser select box. I implemented a simple fix that seems to work on both Edge and Chrome. It replaces the 'onclick' event on the option element with a 'change' event on the select box itself. The file is "assets/packages/limesurvey/survey.js" and the diff is the following: --- survey.js.ORIG 2022-06-17 15:50:06.000000000 +0200
Please, could you try it and in case apply it to the 3.x branch? Thanks for your support. |
|
Ooops... pasting the code did not work well... |
|
This is the proposed pull request for the 3.x-LTS: https://github.com/LimeSurvey/LimeSurvey/pull/2470 BTW, I just saw that on the master branch a similar fix is already present. |
|
There are another issue about JS solution here : token enable survey : we have the top menu Not with register.
(I report the issue for master) |
|
@seccanj This is your new PR, right? |
|
Yes Denis. |
|
I meant yes @gabrieljenik. |
|
I review + test and merge (if it's OK) |
|
Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33589 |
|
Fixed in Release 3.28.17+220627 |
|
LimeSurvey: 3.x-LTS 90cb999b 2022-06-22 11:29:39 Committer: GitHub Details Diff |
Fixed issue 18186: Language changer does not work in registration page (#2474) Fixed issue 18186: Language changer does not work in registration page Dev: same fix than master Dev: keyboard navigation OK Dev: submit button OK |
Affected Issues 18186 |
|
mod - assets/packages/limesurvey/survey.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2022-06-09 14:16 | ritapas | New Issue | |
2022-06-09 14:16 | ritapas | File Added: immagine.png | |
2022-06-09 18:12 | gabrieljenik | Assigned To | => gabrieljenik |
2022-06-09 18:12 | gabrieljenik | Status | new => feedback |
2022-06-09 18:12 | gabrieljenik | Note Added: 70318 | |
2022-06-09 18:12 | gabrieljenik | Bug heat | 0 => 2 |
2022-06-17 16:06 | ritapas | Note Added: 70403 | |
2022-06-17 16:06 | ritapas | Bug heat | 2 => 4 |
2022-06-17 16:06 | ritapas | Status | feedback => assigned |
2022-06-17 16:07 | guest | Bug heat | 4 => 10 |
2022-06-17 16:42 | seccanj | Note Added: 70404 | |
2022-06-17 16:42 | seccanj | Bug heat | 10 => 12 |
2022-06-17 16:45 | seccanj | Note Added: 70405 | |
2022-06-17 16:45 | seccanj | File Added: image.png | |
2022-06-17 18:29 | seccanj | Note Added: 70408 | |
2022-06-20 08:36 | DenisChenu | Note Added: 70412 | |
2022-06-20 08:36 | DenisChenu | File Added: Capture d’écran du 2022-06-20 08-34-10.png | |
2022-06-20 08:36 | DenisChenu | File Added: Capture d’écran du 2022-06-20 08-34-54.png | |
2022-06-20 08:36 | DenisChenu | File Added: survey_archive_TokenNoRegister.lsa | |
2022-06-20 08:36 | DenisChenu | File Added: survey_archive_TokenWithRegister.lsa | |
2022-06-20 08:36 | DenisChenu | Bug heat | 12 => 14 |
2022-06-20 08:42 | DenisChenu | Relationship added | related to 16024 |
2022-06-21 21:05 | gabrieljenik | Note Added: 70462 | |
2022-06-22 09:02 | DenisChenu | Assigned To | gabrieljenik => DenisChenu |
2022-06-22 09:23 | DenisChenu | Status | assigned => in code review |
2022-06-22 10:59 | seccanj | Note Added: 70480 | |
2022-06-22 11:03 | seccanj | Note Added: 70481 | |
2022-06-22 11:08 | DenisChenu | Note Added: 70482 | |
2022-06-22 11:27 | DenisChenu | Status | in code review => ready for merge |
2022-06-22 11:29 | seccanj | Changeset attached | => LimeSurvey 3.x-LTS 90cb999b |
2022-06-22 11:29 | guest | Note Added: 70483 | |
2022-06-22 11:29 | guest | Bug heat | 14 => 16 |
2022-06-22 11:32 | DenisChenu | Status | ready for merge => resolved |
2022-06-22 11:32 | DenisChenu | Resolution | open => fixed |
2022-06-22 11:32 | DenisChenu | Fixed in Version | => 3.28.x |
2022-06-22 15:00 | ritapas | Issue Monitored: ritapas | |
2022-06-22 15:00 | ritapas | Bug heat | 16 => 18 |
2022-06-27 14:01 | LimeBot | Note Added: 70554 | |
2022-06-27 14:01 | guest | Bug heat | 18 => 20 |
2022-06-27 14:01 | LimeBot | Bug heat | 20 => 18 |
2022-06-27 14:01 | LimeBot | Status | resolved => closed |
2022-06-27 14:01 | LimeBot | Bug heat | 18 => 20 |