@ollehar, there seem to be various regressions when it comes to defining theme options at the config.xml file, see related tickets.

Since Limesurvey 6.x is already the official, latest release, can you please coordinate with the development team who can look into this? Because currently it is nearly impossible to adjust 3.x or 5.x themes due to these missing features.

@tpartner, just pinging you here since you also work with custom themes a lot.

@Mazi : please add This bug affects you and 1 other person(s). ;)

@DenisChenu / @ollehar, which developer can best take care of these theme issues?

Currently @p_teichmann and @twilllig are working on finishing LS6 for cloud and CU release.

Wait is this a bug in 5 or 6?

@ollehar, would be happy to see these theme tickets assigned to one of them.

We noticed the issue when working on LS 6.x. But the same problem already seems to exist at 5.x. At that version the feature for theme settings at config.xml was introduced.

Wait is this a bug in 5 or 6?

Both

We're still busy finishing off the new survey theme. Maybe someone else has time to pick it up?

@ollehar, maybe you should fix broken stuff first before creating new features? Sometimes I wonder about how priorities are being set.
Currently we are not able to develop new 6.x question themes for our customers due to the config.xml issues mentioned at various bug tickets.

I don't decide priority, sooo. We have two designated bug fixers and one tester. We can always discuss if that's enough or not.

Any idea on the config.xml ?

new type in https://github.com/LimeSurvey/LimeSurvey/blob/6d4934a1fcad053dbf96ac2d69ddfc02d3f79abc/themes/survey/vanilla/config.xml#L69
new attribute in https://github.com/LimeSurvey/LimeSurvey/blob/6d4934a1fcad053dbf96ac2d69ddfc02d3f79abc/themes/survey/vanilla/config.xml#L69

or new element inside
<dropdownimages></dropdownimages>

Ps : i think we can have same issue for fonts : https://github.com/LimeSurvey/LimeSurvey/blob/6d4934a1fcad053dbf96ac2d69ddfc02d3f79abc/themes/survey/fruity/config.xml#L663

I will leave the implementation details to the experts, I can not contribute much here. But it should be possible to define more than one image to be shown. Using the options.twig this works fine, we did that for many custim themes. But the new feature of defining the theme options at config.xml should also support this.

I think <dropdownimages></dropdownimages> is more easy with current system

@ollehar : i can take this one : adding an optionnal <dropdownimages></dropdownimages> is OK or a new type or a new attribute ?

I prefer new type, but need a compatibility system for current brandlogofile and backgroundimagefile

I think @p_teichmann is better suited to leave feedback here.

Yeah if it is needed, i don't see why we couldn't do that. But this is a feature request as far as i see it and not a bug?

Regarding implementation i think defining a type for it would be a good idea.

@p_teichmann, since LS 5.x already support defining theme options not via options.twig but using the config.xml file, I do not consider this a bug. It seems like this concept was never fully tested.
While you could easily add a second logo by adding the needed code to options.twig, defining this at the config.xml file currently does not work. So I consider this a bug.

Maybe a feature (if we can still use options.twig ? )
But : create a system to allow external dev to do SurveyTheme but not usuable by external dev … clearly a broken implementation …

I looked a bit at the code regarding the xml options. This whole implementation with the xml file looks very incomplete in general, will need to discuss how we want fix this.

Thanks for looking into this, p_teichmann.

I had the same impression. The approach to use the config.xml is really great and it makes the whole template design process less error prone. But it seems the implementation is not complete, though this had become an official feature at LS 5.x.

@ollehar, can someone please look into it? At LS 3.x and 5.x we had the option to have multiple image files. Defining the same at the config.xml at LS 6.x does not work at all.

I'm currently not in the application team. Someone else should have a look.

@ollehar, could you then assign the ticket to "someone else", who ever that is...? This really is a show stopper for our templates.

Pinged the team. :)

@ollehar, @c_schmitz, any updates? This really is a show stopper for template development at version 6.x. Weeks are passing by and currently we can not really create custom templates for the new version for our customers which start switching to 6.x.

We are working on it. Have something to push next week

https://github.com/LimeSurvey/LimeSurvey/pull/3433

Some notes:

We were initially planning to convert the backgroundimagefile and brandlogofile options to the new option type (imagefile).
But I'm not sure about doing it in this ticket. Maybe it's best to leave it for later, especially due to possible implications for backward compatibility. And by converting them to the new type of option, that bug would disappear directly.

Some Bugs Found:

1) For options that have a switch, they are supposed to be disabled when set to “No”. It actually disables the field when you press it.
But when the page loads, the disabling is not applied, and it allows a value to be set even if the switch is set to “No”.

2) LS assumes that certain types of settings (ex: dropdown and duration) GOT to have a switch to activate them. Shouldn't tha be optional?

3) In the theme options of the survey, the preview does not work (it opens the modal but does not find the image).

4) If you set a background image with debug = 2, you can no longer enter the theme options.

But I'm not sure about doing it in this ticket. Maybe it's best to leave it for later, especially due to possible implications for backward compatibility. And by converting them to the new type of option, that bug would disappear directly.

Yes : need backward compatibility.

4) If you set a background image with debug = 2, you can no longer enter the theme options.

Fixed here. Included in the PR.
https://github.com/LimeSurvey/LimeSurvey/pull/3433/commits/6e722025eacfeabb4f46b6cfdbda2957e0ae64a2

1) For options that have a switch, they are supposed to be disabled when set to “No”. It actually disables the field when you press it.
But when the page loads, the disabling is not applied, and it allows a value to be set even if the switch is set to “No”.

Created https://bugs.limesurvey.org/view.php?id=19085

3) In the theme options of the survey, the preview does not work (it opens the modal but does not find the image).

Created https://bugs.limesurvey.org/view.php?id=19086

The only thing to follow up on is

2) LS assumes that certain types of settings (ex: dropdown and duration) GOT to have a switch to activate them. Shouldn't tha be optional?

Sorry, forgot to attach a test theme.
Please notice in there:

<footerimage type="buttons" category="Images" width="4" title="Footer image" options="on|off" optionlabels="Yes|No">on</footerimage>
<footerimagefile type="imagefile" category="Images" width="6" title="Footer image file" parent="footerimage">./files/poweredby.png</footerimagefile>

The first tag is the switch and the second tag (type=”image file”) is the dropdown.
It should also work without the switch (also removing the parent attribute)

@gabrieljenik this issue was originally reported for 5.x, don't we want to port the fix there as well?

Usually no developments are done to LTS

@tibor.pacalat / @gabrieljenik: Will this fix finalle be part of the next 6.x release?

@gabrieljenik, this is actually a bug fix I'd say, not a new feature.

@tibor.pacalat: This issue was reported 5 months ago. Can we finally have this available at the next release? We really need this for template development for our customers.

@c_schmitz: Will all Limesurvey 3 customers be force-updated to LS 6 in November?

@gabrieljenik, this is actually a bug fix I'd say, not a new feature.

Sorry. I understand what you say.
I was speaking from a more technical point of view.

On this one I would need a green light from Carsten, Olle o Tibor to backport it.

@gabrieljenik if you can make a PR for master fairly easily, we can include this in the next release.

I will

Master: https://github.com/LimeSurvey/LimeSurvey/pull/3621

Potential optimization, no ?

@tibor.pacalat Time to test? Code review is done.

@gabrieljenik I am getting an error when I upload the test_18880.zip. I am using php 8.1 and debug=2. But, otherwise this works.

Will review

Try now again please

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35794

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35793

Tested and merged.

Hi @Mazi, as stated here https://bugs.limesurvey.org/view.php?id=18880#c77049 the type should be imagefile and not dropdown. With this setting, it works for me. Please let me know if this has solved your issue or there is something else to do here.

@gabrieljenik can you also double check if there is something still buggy regarding this feature?

@gabrieljenik can you also double check if there is something still buggy regarding this feature?

I confirm what you say about "imagefile".
I don't see anything from my side.

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35931

Happy New Year everyone!
What is the current status of this ticket? I think when using "imagefile", everything should work as expected at LS 6.x?

@Mazi everything should work as expected on LS6 when using "imagefile".

In version 6.5 when using imagefile in stead of dropdown, you loose the possibility to upload files to the theme. This is a show stopper for people that do not have FTP access.

And, as Denis Chenu says on Discord: we only need one upload per tab where file access is needed....

Found it: the upload button only appears when there are imagefiles to be uploaded from the category (= tab in the interface) that is called "Images".

Please change this to: images can be uploaded from each category that has one or more "imagefile" types.

Thanking @DenisChenu !

Need a new Bug report/Feature requet.

I close this one again.