View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|18880||Bug reports||Theme editor||public||2023-06-13 16:23||2023-09-14 16:33|
|Status||ready for code review||Resolution||open|
|Summary||18880: Unable to add imagefile except brandlogofile and backgroundimagefile in option|
When create new theme : we need to have more image files. I skelvanilla i have 2 more, but i think too for favicon
|Steps To Reproduce|
Steps to reproduce
Try to create a template with 3 images files selector with
Have a way to do it (adding imagelist for type or add it in another way)
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||5.6.25|
|I will donate to the project if issue is resolved||No|
|Database type & version||not relevant|
|Server OS (if known)||not relevant|
|Webserver software & version (if known)||not relevant|
|PHP Version||not relevant|
|related to||18894||ready for code review||ollehar||Not able to add theme option text input|
|related to||18893||closed||file list do not show in dropdowns|
|related to||18895||confirmed||No way to add textarea with core config.xml|
|related to||19085||confirmed||Theme Options with an on/off switch are not disabled when page loads|
|related to||19086||confirmed||Survey Theme Options: image preview does not work|
@ollehar, there seem to be various regressions when it comes to defining theme options at the config.xml file, see related tickets.
Since Limesurvey 6.x is already the official, latest release, can you please coordinate with the development team who can look into this? Because currently it is nearly impossible to adjust 3.x or 5.x themes due to these missing features.
@tpartner, just pinging you here since you also work with custom themes a lot.
@Mazi : please add This bug affects you and 1 other person(s). ;)
Wait is this a bug in 5 or 6?
@ollehar, would be happy to see these theme tickets assigned to one of them.
We noticed the issue when working on LS 6.x. But the same problem already seems to exist at 5.x. At that version the feature for theme settings at config.xml was introduced.
We're still busy finishing off the new survey theme. Maybe someone else has time to pick it up?
@ollehar, maybe you should fix broken stuff first before creating new features? Sometimes I wonder about how priorities are being set.
I don't decide priority, sooo. We have two designated bug fixers and one tester. We can always discuss if that's enough or not.
Any idea on the config.xml ?
new type in https://github.com/LimeSurvey/LimeSurvey/blob/6d4934a1fcad053dbf96ac2d69ddfc02d3f79abc/themes/survey/vanilla/config.xml#L69
or new element inside
Ps : i think we can have same issue for fonts : https://github.com/LimeSurvey/LimeSurvey/blob/6d4934a1fcad053dbf96ac2d69ddfc02d3f79abc/themes/survey/fruity/config.xml#L663
I will leave the implementation details to the experts, I can not contribute much here. But it should be possible to define more than one image to be shown. Using the options.twig this works fine, we did that for many custim themes. But the new feature of defining the theme options at config.xml should also support this.
I think <dropdownimages></dropdownimages> is more easy with current system
@ollehar : i can take this one : adding an optionnal <dropdownimages></dropdownimages> is OK or a new type or a new attribute ?
I prefer new type, but need a compatibility system for current brandlogofile and backgroundimagefile
I think @p_teichmann is better suited to leave feedback here.
Yeah if it is needed, i don't see why we couldn't do that. But this is a feature request as far as i see it and not a bug?
Regarding implementation i think defining a type for it would be a good idea.
@p_teichmann, since LS 5.x already support defining theme options not via options.twig but using the config.xml file, I do not consider this a bug. It seems like this concept was never fully tested.
Maybe a feature (if we can still use options.twig ? )
I looked a bit at the code regarding the xml options. This whole implementation with the xml file looks very incomplete in general, will need to discuss how we want fix this.
Thanks for looking into this, p_teichmann.
I had the same impression. The approach to use the config.xml is really great and it makes the whole template design process less error prone. But it seems the implementation is not complete, though this had become an official feature at LS 5.x.
@ollehar, can someone please look into it? At LS 3.x and 5.x we had the option to have multiple image files. Defining the same at the config.xml at LS 6.x does not work at all.
I'm currently not in the application team. Someone else should have a look.
@ollehar, could you then assign the ticket to "someone else", who ever that is...? This really is a show stopper for our templates.
Pinged the team. :)
@ollehar, @c_schmitz, any updates? This really is a show stopper for template development at version 6.x. Weeks are passing by and currently we can not really create custom templates for the new version for our customers which start switching to 6.x.
We are working on it. Have something to push next week
We were initially planning to convert the backgroundimagefile and brandlogofile options to the new option type (imagefile).
Some Bugs Found:
1) For options that have a switch, they are supposed to be disabled when set to “No”. It actually disables the field when you press it.
2) LS assumes that certain types of settings (ex: dropdown and duration) GOT to have a switch to activate them. Shouldn't tha be optional?
3) In the theme options of the survey, the preview does not work (it opens the modal but does not find the image).
4) If you set a background image with debug = 2, you can no longer enter the theme options.
Yes : need backward compatibility.
Fixed here. Included in the PR.
The only thing to follow up on is
Sorry, forgot to attach a test theme.
The first tag is the switch and the second tag (type=”image file”) is the dropdown.
test_18880.zip (109,164 bytes)
|2023-06-13 16:23||DenisChenu||New Issue|
|2023-06-16 15:08||DenisChenu||Relationship added||related to 18893|
|2023-06-19 08:24||DenisChenu||Relationship added||related to 18895|
|2023-06-19 08:31||DenisChenu||Relationship added||related to 18894|
|2023-06-19 08:32||DenisChenu||Severity||minor => partial_block|
|2023-06-19 09:54||Mazi||Note Added: 75696|
|2023-06-19 09:54||Mazi||Bug heat||0 => 2|
|2023-06-19 09:54||Mazi||Issue Monitored: Mazi|
|2023-06-19 09:54||Mazi||Bug heat||2 => 4|
|2023-06-19 09:55||Mazi||Note Added: 75697|
|2023-06-19 10:23||DenisChenu||Note Added: 75702|
|2023-06-19 10:23||DenisChenu||Bug heat||4 => 6|
|2023-06-19 10:36||Mazi||Bug heat||6 => 12|
|2023-06-28 11:03||Mazi||Note Added: 75883|
|2023-06-28 11:52||ollehar||Note Added: 75887|
|2023-06-28 11:52||ollehar||Bug heat||12 => 14|
|2023-06-28 11:52||ollehar||Note Edited: 75887|
|2023-06-28 11:52||ollehar||Note Edited: 75887|
|2023-06-28 11:53||ollehar||Note Added: 75888|
|2023-06-28 12:35||Mazi||Note Added: 75891|
|2023-06-28 12:37||DenisChenu||Note Added: 75892|
|2023-06-29 12:55||ollehar||Note Added: 75902|
|2023-07-11 12:17||Mazi||Note Added: 76031|
|2023-07-11 14:06||ollehar||Note Added: 76037|
|2023-07-11 16:58||DenisChenu||Note Added: 76051|
|2023-07-11 17:00||DenisChenu||Note Added: 76052|
|2023-07-11 19:06||Mazi||Note Added: 76053|
|2023-07-12 08:11||DenisChenu||Note Added: 76055|
|2023-07-12 10:27||ollehar||Note Added: 76057|
|2023-07-12 19:54||p_teichmann||Note Added: 76066|
|2023-07-12 19:54||p_teichmann||Bug heat||14 => 16|
|2023-07-12 20:34||Mazi||Note Added: 76067|
|2023-07-13 07:38||DenisChenu||Note Added: 76070|
|2023-07-13 12:00||p_teichmann||Note Added: 76073|
|2023-07-13 12:08||p_teichmann||Note Edited: 76073|
|2023-07-13 13:24||Mazi||Note Added: 76076|
|2023-08-24 21:51||Mazi||Note Added: 76703|
|2023-08-25 00:51||guest||Bug heat||16 => 22|
|2023-08-25 10:37||ollehar||Note Added: 76707|
|2023-08-25 10:42||Mazi||Note Added: 76709|
|2023-08-25 10:51||ollehar||Note Added: 76710|
|2023-09-07 22:19||Mazi||Note Added: 76911|
|2023-09-08 21:20||gabrieljenik||Assigned To||=> gabrieljenik|
|2023-09-08 21:20||gabrieljenik||Status||new => assigned|
|2023-09-08 21:30||gabrieljenik||Note Added: 76932|
|2023-09-08 21:30||gabrieljenik||Bug heat||22 => 24|
|2023-09-11 16:17||gabrieljenik||Assigned To||gabrieljenik => ollehar|
|2023-09-11 16:17||gabrieljenik||Status||assigned => ready for code review|
|2023-09-11 16:17||gabrieljenik||Note Added: 76938|
|2023-09-11 16:18||gabrieljenik||Assigned To||ollehar => p_teichmann|
|2023-09-11 16:39||gabrieljenik||Note Added: 76940|
|2023-09-11 16:43||DenisChenu||Note Added: 76941|
|2023-09-11 17:59||gabrieljenik||Note Added: 76944|
|2023-09-14 14:46||gabrieljenik||Issue cloned: 19085|
|2023-09-14 14:46||gabrieljenik||Relationship added||related to 19085|
|2023-09-14 14:49||gabrieljenik||Issue cloned: 19086|
|2023-09-14 14:49||gabrieljenik||Relationship added||related to 19086|
|2023-09-14 14:51||gabrieljenik||Note Added: 77037|
|2023-09-14 16:31||gabrieljenik||Note Added: 77049|
|2023-09-14 16:31||gabrieljenik||File Added: test_18880.zip|
|2023-09-14 16:32||gabrieljenik||Note Edited: 77049|
|2023-09-14 16:33||gabrieljenik||Note Edited: 77049|