View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19086 | Bug reports | Theme editor | public | 2023-09-14 14:49 | 2023-11-13 15:43 |
Reporter | gabrieljenik | Assigned To | mfavetti | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.6.x | ||||
Summary | 19086: Survey Theme Options: image preview does not work | ||||
Description | When working with options... In the theme options of the survey, the image preview does not work (it opens the modal but does not find the image). Caught while reviewing 18880 | ||||
Tags | No tags attached. | ||||
Bug heat | 20 | ||||
Complete LimeSurvey version number (& build) | 5.6.25 6.3.1 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 18880 | closed | gabrieljenik | Unable to add imagefile except brandlogofile and backgroundimagefile in option |
related to | 19183 | closed | mfavetti | No editing possible after setting the survey background |
related to | 19085 | closed | mfavetti | Theme Options with an on/off switch are not disabled when page loads |
We are facing this issue at LS 5.x and 6.x as well. |
|
I need to be more specific here: At LS 6.x the problem only exists when trying to use multiple images. In this case the dropdown is not showing any images and thus the preview doesn't work. |
|
I can confirm that this is still present. |
|
@tibor.pacalat, more users/customers complained about this. Can we assign the ticket to a developer please? |
|
Sorry, but we have limited capacity for bug fixing at the moment. I could assign someone, but it doesn't mean that it will be picked up soon. |
|
i'll pick this up |
|
Great, thanks a lot @mfavetti! |
|
theme fruity_twentythree in 6.x and fruity in 5.x specifies a background image which does not exist in the repository (./files/pattern.png) and the theme options did not handle missing files I accounted for this possibility in the frontend of the theme options by disabling the preview image button and adding an is-invalid/has-error class to the select. The backend happily accepts the path to the missing image (no check for valid image on save?) And maybe the application needs to have this as part of the validation when loading a theme's config.xml in the first place? |
|
5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3562 please note there will be merge conflicts between these PRs and the PRs for 19183 i have no way of knowing which will be merged first, so just ping me when they pop up and I will take care of it |
|
In general : i do one by one (wit merge of the orther) |
|
This needs code review first. |
|
To reproduce: |
|
after fix: |
|
updated PRs to fix conflicts from 19183 |
|
added comment in PR |
|
i looked on both prs, but didn't see any comments from you, maybe it didn't get added somehow |
|
@mfavetti you are right forgot to submit it :) |
|
ty!! replied on that pr, if its okay now, I can fix 5.x branch pr also |
|
updated 5.x pr also |
|
@mfavetti I think something is off here, the new field validation is not working as expected. |
|
ok, I will look again |
|
@tibor.pacalat can you check again with the latest commit? I think your screen shot is the same problem that @p_teichman caught during code review. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35720 |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35739 |
|
@tibor.pacalat, will this be included at the next release? |
|
Fixed in Release 6.3.5+231113 |
|
LimeSurvey: master 6c102006 2023-11-06 16:42 Committer: GitHub Details Diff |
Fixed issue 19086: Survey Theme Options - image preview does not work (03557) |
Affected Issues 19086 |
|
mod - application/views/themeOptions/options_core.php | Diff File | ||
mod - assets/packages/themeoptions-core/themeoptions-core.js | Diff File | ||
LimeSurvey: 5.x 09edd85f 2023-11-09 21:25 Committer: GitHub Details Diff |
Fixed issue 19086: Survey Theme Options - image preview does not work (#3562) |
Affected Issues 19086 |
|
mod - application/views/themeOptions/options_core.php | Diff File | ||
mod - assets/packages/themeoptions-core/themeoptions-core.js | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-09-14 14:49 | gabrieljenik | New Issue | |
2023-09-14 14:49 | gabrieljenik | Issue generated from: 18880 | |
2023-09-14 14:49 | gabrieljenik | Relationship added | related to 18880 |
2023-09-18 15:07 | gabrieljenik | Severity | partial_block => minor |
2023-09-18 15:07 | gabrieljenik | Status | new => confirmed |
2023-09-27 10:43 | guest | Bug heat | 0 => 6 |
2023-09-27 13:34 | Mazi | Note Added: 77363 | |
2023-09-27 13:34 | Mazi | Bug heat | 6 => 8 |
2023-09-27 13:36 | Mazi | Note Added: 77364 | |
2023-10-05 16:53 | tibor.pacalat | Note Added: 77525 | |
2023-10-05 16:53 | tibor.pacalat | Bug heat | 8 => 10 |
2023-10-11 14:44 | Mazi | Note Added: 77626 | |
2023-10-11 15:34 | tibor.pacalat | Note Added: 77630 | |
2023-10-19 10:34 | mfavetti | Note Added: 77778 | |
2023-10-19 10:34 | mfavetti | Bug heat | 10 => 12 |
2023-10-19 10:34 | mfavetti | Assigned To | => mfavetti |
2023-10-19 10:34 | mfavetti | Status | confirmed => assigned |
2023-10-19 23:17 | Mazi | Note Added: 77796 | |
2023-10-20 22:00 | mfavetti | Relationship added | related to 19183 |
2023-10-20 22:23 | mfavetti | Relationship added | related to 19085 |
2023-10-21 04:36 | mfavetti | Note Added: 77825 | |
2023-10-21 23:47 | mfavetti | Note Edited: 77825 | |
2023-10-22 00:27 | mfavetti | Note Added: 77834 | |
2023-10-22 01:33 | mfavetti | Note Edited: 77834 | |
2023-10-22 01:35 | mfavetti | Note Edited: 77825 | |
2023-10-22 01:37 | mfavetti | Assigned To | mfavetti => DenisChenu |
2023-10-22 01:37 | mfavetti | Status | assigned => ready for code review |
2023-10-23 11:43 | DenisChenu | Note Added: 77861 | |
2023-10-23 11:43 | DenisChenu | Bug heat | 12 => 14 |
2023-10-23 11:43 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2023-10-23 11:43 | DenisChenu | Status | ready for code review => ready for testing |
2023-10-23 20:49 | mfavetti | Issue Monitored: mfavetti | |
2023-10-23 20:49 | mfavetti | Bug heat | 14 => 16 |
2023-10-24 16:47 | tibor.pacalat | Assigned To | tibor.pacalat => p_teichmann |
2023-10-24 16:47 | tibor.pacalat | Status | ready for testing => ready for code review |
2023-10-24 16:47 | tibor.pacalat | Note Added: 77925 | |
2023-10-25 00:20 | mfavetti | Note Added: 77948 | |
2023-10-25 00:20 | mfavetti | File Added: LimeSurvey - Google Chrome 2023-10-24 15-17-55_720p.mp4 | |
2023-10-25 00:23 | mfavetti | Note Added: 77949 | |
2023-10-25 00:23 | mfavetti | File Added: LimeSurvey - Google Chrome 2023-10-24 15-21-38_720p.mp4 | |
2023-10-26 01:10 | mfavetti | Note Added: 78024 | |
2023-10-30 10:27 | p_teichmann | Status | ready for code review => in code review |
2023-10-30 12:39 | p_teichmann | Assigned To | p_teichmann => mfavetti |
2023-10-30 12:39 | p_teichmann | Status | in code review => assigned |
2023-10-30 12:39 | p_teichmann | Complete LimeSurvey version number (& build) | 5.6.25 => 5.6.25 6.3.1 |
2023-10-30 12:39 | p_teichmann | Note Added: 78133 | |
2023-10-30 12:39 | p_teichmann | Bug heat | 16 => 18 |
2023-10-30 19:06 | mfavetti | Note Added: 78152 | |
2023-11-01 10:53 | p_teichmann | Note Added: 78198 | |
2023-11-01 10:54 | p_teichmann | Note Edited: 78198 | |
2023-11-02 08:51 | mfavetti | Note Added: 78207 | |
2023-11-02 13:37 | p_teichmann | Status | assigned => ready for testing |
2023-11-02 13:38 | p_teichmann | Assigned To | mfavetti => tibor.pacalat |
2023-11-03 08:00 | mfavetti | Note Added: 78221 | |
2023-11-03 17:53 | tibor.pacalat | Note Added: 78258 | |
2023-11-03 17:53 | tibor.pacalat | File Added: Screenshot 2023-11-03 at 17.51.30.png | |
2023-11-03 17:53 | tibor.pacalat | File Added: Screenshot 2023-11-03 at 17.51.50.png | |
2023-11-03 17:54 | tibor.pacalat | Note Edited: 78258 | |
2023-11-03 19:55 | mfavetti | Note Added: 78263 | |
2023-11-04 05:29 | mfavetti | Note Added: 78267 | |
2023-11-06 15:42 | mfavetti | Changeset attached | => LimeSurvey master 6c102006 |
2023-11-06 15:42 | mfavetti | Note Added: 78287 | |
2023-11-06 15:42 | mfavetti | Assigned To | tibor.pacalat => mfavetti |
2023-11-06 15:42 | mfavetti | Resolution | open => fixed |
2023-11-09 20:26 | tibor.pacalat | Status | ready for testing => resolved |
2023-11-09 20:34 | mfavetti | Changeset attached | => LimeSurvey 5.x 09edd85f |
2023-11-09 20:34 | mfavetti | Note Added: 78371 | |
2023-11-13 09:59 | Mazi | Note Added: 78403 | |
2023-11-13 15:43 | LimeBot | Note Added: 78430 | |
2023-11-13 15:43 | LimeBot | Status | resolved => closed |
2023-11-13 15:43 | LimeBot | Bug heat | 18 => 20 |