View Issue Details

This bug affects 2 person(s).
 20
IDProjectCategoryView StatusLast Update
19086Bug reportsTheme editorpublic2023-11-13 15:43
Reportergabrieljenik Assigned Tomfavetti  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version5.6.x 
Summary19086: Survey Theme Options: image preview does not work
Description

When working with options...

In the theme options of the survey, the image preview does not work (it opens the modal but does not find the image).

Caught while reviewing 18880

TagsNo tags attached.
Bug heat20
Complete LimeSurvey version number (& build)5.6.25 6.3.1
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

related to 18880 closedgabrieljenik Unable to add imagefile except brandlogofile and backgroundimagefile in option 
related to 19183 closedmfavetti No editing possible after setting the survey background 
related to 19085 closedmfavetti Theme Options with an on/off switch are not disabled when page loads 

Users monitoring this issue

mfavetti

Activities

Mazi

Mazi

2023-09-27 13:34

updater   ~77363

We are facing this issue at LS 5.x and 6.x as well.

Mazi

Mazi

2023-09-27 13:36

updater   ~77364

I need to be more specific here: At LS 6.x the problem only exists when trying to use multiple images. In this case the dropdown is not showing any images and thus the preview doesn't work.
So this is probably related to https://bugs.limesurvey.org/view.php?id=18880.

tibor.pacalat

tibor.pacalat

2023-10-05 16:53

administrator   ~77525

I can confirm that this is still present.

Mazi

Mazi

2023-10-11 14:44

updater   ~77626

@tibor.pacalat, more users/customers complained about this. Can we assign the ticket to a developer please?

tibor.pacalat

tibor.pacalat

2023-10-11 15:34

administrator   ~77630

Sorry, but we have limited capacity for bug fixing at the moment. I could assign someone, but it doesn't mean that it will be picked up soon.

mfavetti

mfavetti

2023-10-19 10:34

developer   ~77778

i'll pick this up

Mazi

Mazi

2023-10-19 23:17

updater   ~77796

Great, thanks a lot @mfavetti!

mfavetti

mfavetti

2023-10-21 04:36

developer   ~77825

Last edited: 2023-10-22 01:35

theme fruity_twentythree in 6.x and fruity in 5.x specifies a background image which does not exist in the repository (./files/pattern.png) and the theme options did not handle missing files

I accounted for this possibility in the frontend of the theme options by disabling the preview image button and adding an is-invalid/has-error class to the select. The backend happily accepts the path to the missing image (no check for valid image on save?) And maybe the application needs to have this as part of the validation when loading a theme's config.xml in the first place?

mfavetti

mfavetti

2023-10-22 00:27

developer   ~77834

Last edited: 2023-10-22 01:33

5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3562
master: https://github.com/LimeSurvey/LimeSurvey/pull/3557

please note there will be merge conflicts between these PRs and the PRs for 19183

i have no way of knowing which will be merged first, so just ping me when they pop up and I will take care of it

DenisChenu

DenisChenu

2023-10-23 11:43

developer   ~77861

i have no way of knowing which will be merged first, so just ping me when they pop up and I will take care of it

In general : i do one by one (wit merge of the orther)
Or i do both i one commit (multiple fix in one commit)

tibor.pacalat

tibor.pacalat

2023-10-24 16:47

administrator   ~77925

This needs code review first.

mfavetti

mfavetti

2023-10-25 00:20

developer   ~77948

To reproduce:

mfavetti

mfavetti

2023-10-25 00:23

developer   ~77949

after fix:

mfavetti

mfavetti

2023-10-26 01:10

developer   ~78024

updated PRs to fix conflicts from 19183

p_teichmann

p_teichmann

2023-10-30 12:39

administrator   ~78133

added comment in PR

mfavetti

mfavetti

2023-10-30 19:06

developer   ~78152

@p_teichmann

i looked on both prs, but didn't see any comments from you, maybe it didn't get added somehow

p_teichmann

p_teichmann

2023-11-01 10:53

administrator   ~78198

Last edited: 2023-11-01 10:54

@mfavetti you are right forgot to submit it :)
https://github.com/LimeSurvey/LimeSurvey/pull/3557

mfavetti

mfavetti

2023-11-02 08:51

developer   ~78207

ty!! replied on that pr, if its okay now, I can fix 5.x branch pr also

mfavetti

mfavetti

2023-11-03 08:00

developer   ~78221

updated 5.x pr also

tibor.pacalat

tibor.pacalat

2023-11-03 17:53

administrator   ~78258

Last edited: 2023-11-03 17:54

@mfavetti I think something is off here, the new field validation is not working as expected.

mfavetti

mfavetti

2023-11-03 19:55

developer   ~78263

ok, I will look again

mfavetti

mfavetti

2023-11-04 05:29

developer   ~78267

@tibor.pacalat can you check again with the latest commit?

I think your screen shot is the same problem that @p_teichman caught during code review.

mfavetti

mfavetti

2023-11-06 15:42

developer   ~78287

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35720

mfavetti

mfavetti

2023-11-09 20:34

developer   ~78371

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35739

Mazi

Mazi

2023-11-13 09:59

updater   ~78403

@tibor.pacalat, will this be included at the next release?

LimeBot

LimeBot

2023-11-13 15:43

administrator   ~78430

Fixed in Release 6.3.5+231113

Related Changesets

LimeSurvey: master 6c102006

2023-11-06 16:42

mfavetti

Committer: GitHub


Details Diff
Fixed issue 19086: Survey Theme Options - image preview does not work (03557) Affected Issues
19086
mod - application/views/themeOptions/options_core.php Diff File
mod - assets/packages/themeoptions-core/themeoptions-core.js Diff File

LimeSurvey: 5.x 09edd85f

2023-11-09 21:25

mfavetti

Committer: GitHub


Details Diff
Fixed issue 19086: Survey Theme Options - image preview does not work (#3562) Affected Issues
19086
mod - application/views/themeOptions/options_core.php Diff File
mod - assets/packages/themeoptions-core/themeoptions-core.js Diff File

Issue History

Date Modified Username Field Change
2023-09-14 14:49 gabrieljenik New Issue
2023-09-14 14:49 gabrieljenik Issue generated from: 18880
2023-09-14 14:49 gabrieljenik Relationship added related to 18880
2023-09-18 15:07 gabrieljenik Severity partial_block => minor
2023-09-18 15:07 gabrieljenik Status new => confirmed
2023-09-27 10:43 guest Bug heat 0 => 6
2023-09-27 13:34 Mazi Note Added: 77363
2023-09-27 13:34 Mazi Bug heat 6 => 8
2023-09-27 13:36 Mazi Note Added: 77364
2023-10-05 16:53 tibor.pacalat Note Added: 77525
2023-10-05 16:53 tibor.pacalat Bug heat 8 => 10
2023-10-11 14:44 Mazi Note Added: 77626
2023-10-11 15:34 tibor.pacalat Note Added: 77630
2023-10-19 10:34 mfavetti Note Added: 77778
2023-10-19 10:34 mfavetti Bug heat 10 => 12
2023-10-19 10:34 mfavetti Assigned To => mfavetti
2023-10-19 10:34 mfavetti Status confirmed => assigned
2023-10-19 23:17 Mazi Note Added: 77796
2023-10-20 22:00 mfavetti Relationship added related to 19183
2023-10-20 22:23 mfavetti Relationship added related to 19085
2023-10-21 04:36 mfavetti Note Added: 77825
2023-10-21 23:47 mfavetti Note Edited: 77825
2023-10-22 00:27 mfavetti Note Added: 77834
2023-10-22 01:33 mfavetti Note Edited: 77834
2023-10-22 01:35 mfavetti Note Edited: 77825
2023-10-22 01:37 mfavetti Assigned To mfavetti => DenisChenu
2023-10-22 01:37 mfavetti Status assigned => ready for code review
2023-10-23 11:43 DenisChenu Note Added: 77861
2023-10-23 11:43 DenisChenu Bug heat 12 => 14
2023-10-23 11:43 DenisChenu Assigned To DenisChenu => tibor.pacalat
2023-10-23 11:43 DenisChenu Status ready for code review => ready for testing
2023-10-23 20:49 mfavetti Issue Monitored: mfavetti
2023-10-23 20:49 mfavetti Bug heat 14 => 16
2023-10-24 16:47 tibor.pacalat Assigned To tibor.pacalat => p_teichmann
2023-10-24 16:47 tibor.pacalat Status ready for testing => ready for code review
2023-10-24 16:47 tibor.pacalat Note Added: 77925
2023-10-25 00:20 mfavetti Note Added: 77948
2023-10-25 00:20 mfavetti File Added: LimeSurvey - Google Chrome 2023-10-24 15-17-55_720p.mp4
2023-10-25 00:23 mfavetti Note Added: 77949
2023-10-25 00:23 mfavetti File Added: LimeSurvey - Google Chrome 2023-10-24 15-21-38_720p.mp4
2023-10-26 01:10 mfavetti Note Added: 78024
2023-10-30 10:27 p_teichmann Status ready for code review => in code review
2023-10-30 12:39 p_teichmann Assigned To p_teichmann => mfavetti
2023-10-30 12:39 p_teichmann Status in code review => assigned
2023-10-30 12:39 p_teichmann Complete LimeSurvey version number (& build) 5.6.25 => 5.6.25 6.3.1
2023-10-30 12:39 p_teichmann Note Added: 78133
2023-10-30 12:39 p_teichmann Bug heat 16 => 18
2023-10-30 19:06 mfavetti Note Added: 78152
2023-11-01 10:53 p_teichmann Note Added: 78198
2023-11-01 10:54 p_teichmann Note Edited: 78198
2023-11-02 08:51 mfavetti Note Added: 78207
2023-11-02 13:37 p_teichmann Status assigned => ready for testing
2023-11-02 13:38 p_teichmann Assigned To mfavetti => tibor.pacalat
2023-11-03 08:00 mfavetti Note Added: 78221
2023-11-03 17:53 tibor.pacalat Note Added: 78258
2023-11-03 17:53 tibor.pacalat File Added: Screenshot 2023-11-03 at 17.51.30.png
2023-11-03 17:53 tibor.pacalat File Added: Screenshot 2023-11-03 at 17.51.50.png
2023-11-03 17:54 tibor.pacalat Note Edited: 78258
2023-11-03 19:55 mfavetti Note Added: 78263
2023-11-04 05:29 mfavetti Note Added: 78267
2023-11-06 15:42 mfavetti Changeset attached => LimeSurvey master 6c102006
2023-11-06 15:42 mfavetti Note Added: 78287
2023-11-06 15:42 mfavetti Assigned To tibor.pacalat => mfavetti
2023-11-06 15:42 mfavetti Resolution open => fixed
2023-11-09 20:26 tibor.pacalat Status ready for testing => resolved
2023-11-09 20:34 mfavetti Changeset attached => LimeSurvey 5.x 09edd85f
2023-11-09 20:34 mfavetti Note Added: 78371
2023-11-13 09:59 Mazi Note Added: 78403
2023-11-13 15:43 LimeBot Note Added: 78430
2023-11-13 15:43 LimeBot Status resolved => closed
2023-11-13 15:43 LimeBot Bug heat 18 => 20