View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18895 | Bug reports | Theme editor | public | 2023-06-19 08:24 | 2024-11-19 18:14 |
Reporter | DenisChenu | Assigned To | tibor.pacalat | ||
Priority | none | Severity | partial_block | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.6.x | ||||
Summary | 18895: No way to add textarea with core config.xml | ||||
Description | There are no textarea available for core config.xml | ||||
Steps To Reproduce | Steps to reproduceTry to add a textarea via options.xml Expected resultHave a way : Actual resultNo way | ||||
Tags | No tags attached. | ||||
Bug heat | 28 | ||||
Complete LimeSurvey version number (& build) | 6.1.4 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | not relevant | ||||
Database type & version | not relevant | ||||
Server OS (if known) | not relevant | ||||
Webserver software & version (if known) | not relevant | ||||
PHP Version | not relevant | ||||
related to | 18880 | closed | gabrieljenik | Unable to add imagefile except brandlogofile and backgroundimagefile in option |
related to | 19049 | closed | tibor.pacalat | Cannot export LSS from survey where theme is set to one extended from 'bootswatch' |
related to | 18894 | closed | tibor.pacalat | Not able to add theme option text input |
@DenisChenu, we are using a textarea for defining the template footer details at our themes via a theme option. That works fine using this code: OPTIONS.TWIG: CONFIG.XML: |
|
In option.twig : yes, but not by config.xml only. I mean : i already have a options.twig : https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/tree/master/options?ref_type=heads Update the description : options.xml |
|
You are right, at config.xml this is missing. I have adjusted the ticket title since it was mentioning options.xml. |
|
@gabrieljenik, I hope you don't mind if we assign this one to you as well since this is also affecting setting theme options at config.xml so this is similar to your tickets |
|
@DenisChenu, we already have a solution for text inputs at https://bugs.limesurvey.org/view.php?id=18894. Would you be able to extend this for textareas as well? I think we really need this feature for LS 6.x templates. |
|
@ollehar: This issue is confirmed, but what are the next steps for fixing it? We already have a solution for text inputs at https://bugs.limesurvey.org/view.php?id=18894. Can we add support for textareas in a similar way? |
|
Hm I'm not in the application team anymore, maybe ping @p_teichmann? |
|
@p_teichmann, @tibor.pacalat, what can we do to get this bug fixed similar to the fix for text inputs at 18894? |
|
@c_schmitz: At options.twig it was a piece of cake to use a textarea as theme option. When defining theme options at the config.xml, this is not doable which is a big disadvantage. |
|
I didn't mind for this place, interesting too. If you use textearea : https://github.com/LimeSurvey/LimeSurvey/pull/3521 must be tested. |
|
@gabrieljenik You unassigned yourself from this? At 2023-09-13. |
|
@tibor.pacalat, I was told to only annoy you as product owner with my questions, so here we go: What is the current status? When can we assume to get this fixed? @c_schmitz, I'd appreciate to get some feedback to my question above (https://bugs.limesurvey.org/view.php?id=18895#c78212). Thanks! |
|
@DenisChenu can you work on this? @Mazi when Denis fixes it and I test it, it will be deployed on the next Monday as usual. |
|
https://github.com/LimeSurvey/LimeSurvey/pull/3703 Theme for test vanilla_style : include inline style in vanilla. |
|
I think it's OK for 6 only since theme for 3 are compatible until 5. But can be done for 5 |
|
Thanks for working on this, DeniChenu. |
|
@DenisChenu I tried adding a second textarea but it just shows one. |
|
Need 2 diffrent name style and style2 : attribute name give the final name. Test with : https://bin.shnoulle.net/?014940627087a583#2XNEG2KTz4Ce9xXDL97PddwGSBhrra15pF75oBGzUn3e |
|
Ok, it works now! Is this documented in the Manual as well? |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36003 |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36002 |
|
It's the same for ALL other options. I don't choose xml for options in config.xml. I only found this for documentation : https://manual.limesurvey.org/Template_config.xml Nothing at https://manual.limesurvey.org/Theme_editor |
|
Fixed in Release 6.4.4+240130 |
|
LimeSurvey: master bace49aa 2024-01-29 17:51 Committer: GitHub Details Diff |
Fixed issue 18895: No way to add textarea with core config.xml (#3703) |
Affected Issues 18895 |
|
mod - application/models/TemplateManifest.php | Diff File | ||
mod - application/views/themeOptions/options_core.php | Diff File | ||
LimeSurvey: master bace49aa 2024-01-29 17:51 Committer: GitHub Details Diff |
Fixed issue 18895: No way to add textarea with core config.xml (#3703) |
Affected Issues 18895 |
|
mod - application/models/TemplateManifest.php | Diff File | ||
mod - application/views/themeOptions/options_core.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-06-19 08:24 | DenisChenu | New Issue | |
2023-06-19 08:24 | DenisChenu | Relationship added | related to 18894 |
2023-06-19 08:24 | DenisChenu | Relationship added | related to 18880 |
2023-06-19 10:37 | tibor.pacalat | Bug heat | 0 => 6 |
2023-08-25 00:51 | guest | Bug heat | 6 => 12 |
2023-09-12 09:35 | Mazi | Note Added: 76954 | |
2023-09-12 09:35 | Mazi | Bug heat | 12 => 14 |
2023-09-12 10:32 | DenisChenu | Note Added: 76955 | |
2023-09-12 10:32 | DenisChenu | Bug heat | 14 => 16 |
2023-09-12 10:33 | DenisChenu | Summary | No way to add textarea with core options.twig => No way to add textarea with core options.xml |
2023-09-12 10:33 | DenisChenu | Description Updated | |
2023-09-12 10:33 | DenisChenu | Steps to Reproduce Updated | |
2023-09-12 10:33 | DenisChenu | Note Edited: 76955 | |
2023-09-12 10:52 | Mazi | Summary | No way to add textarea with core options.xml => No way to add textarea with core config.xml |
2023-09-12 10:52 | Mazi | Description Updated | |
2023-09-12 10:53 | Mazi | Note Added: 76956 | |
2023-09-12 10:53 | Mazi | Assigned To | => gabrieljenik |
2023-09-12 10:53 | Mazi | Status | new => assigned |
2023-09-12 10:54 | Mazi | Note Added: 76957 | |
2023-09-13 14:36 | gabrieljenik | Assigned To | gabrieljenik => |
2023-09-13 14:36 | gabrieljenik | Status | assigned => confirmed |
2023-09-13 15:26 | Mazi | Note Added: 76990 | |
2023-09-18 13:40 | Mazi | Note Added: 77110 | |
2023-09-18 13:59 | ollehar | Note Added: 77115 | |
2023-09-18 13:59 | ollehar | Bug heat | 16 => 18 |
2023-10-11 14:46 | Mazi | Note Added: 77628 | |
2023-11-02 12:00 | Mazi | Note Added: 78212 | |
2023-11-02 12:18 | DenisChenu | Note Added: 78213 | |
2023-11-02 12:19 | DenisChenu | Relationship added | related to 19049 |
2023-11-28 09:26 | ollehar | Note Added: 78759 | |
2024-01-16 10:23 | guest | Bug heat | 18 => 24 |
2024-01-16 17:36 | Mazi | Note Added: 79189 | |
2024-01-16 17:49 | tibor.pacalat | Note Added: 79190 | |
2024-01-16 17:49 | tibor.pacalat | Bug heat | 24 => 26 |
2024-01-16 17:49 | DenisChenu | Assigned To | => DenisChenu |
2024-01-16 17:49 | DenisChenu | Status | confirmed => assigned |
2024-01-18 16:09 | DenisChenu | Note Added: 79218 | |
2024-01-18 16:09 | DenisChenu | File Added: Capture d’écran du 2024-01-18 16-09-00.png | |
2024-01-18 16:09 | DenisChenu | File Added: vanilla_style.zip | |
2024-01-18 16:11 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2024-01-18 16:11 | DenisChenu | Status | assigned => ready for code review |
2024-01-18 16:11 | DenisChenu | Complete LimeSurvey version number (& build) | 5.6.25 and 6.1.3 => 6.1.4 |
2024-01-18 16:11 | DenisChenu | Note Added: 79219 | |
2024-01-24 00:08 | gabrieljenik | Assigned To | gabrieljenik => tibor.pacalat |
2024-01-24 00:08 | gabrieljenik | Status | ready for code review => ready for testing |
2024-01-24 11:16 | Mazi | Note Added: 79307 | |
2024-01-29 16:24 | tibor.pacalat | Note Added: 79325 | |
2024-01-29 16:24 | tibor.pacalat | File Added: Screenshot 2024-01-29 at 16.23.57.png | |
2024-01-29 16:25 | tibor.pacalat | Note Added: 79326 | |
2024-01-29 16:25 | tibor.pacalat | File Added: Screenshot 2024-01-29 at 16.25.20.png | |
2024-01-29 16:25 | tibor.pacalat | Note Edited: 79325 | |
2024-01-29 16:34 | DenisChenu | Note Added: 79328 | |
2024-01-29 16:50 | tibor.pacalat | Note Added: 79330 | |
2024-01-29 16:51 | DenisChenu | Changeset attached | => LimeSurvey master bace49aa |
2024-01-29 16:51 | DenisChenu | Changeset attached | => LimeSurvey master bace49aa |
2024-01-29 16:51 | DenisChenu | Note Added: 79331 | |
2024-01-29 16:51 | DenisChenu | Note Added: 79332 | |
2024-01-29 17:32 | DenisChenu | Note Added: 79338 | |
2024-01-30 10:18 | LimeBot | Note Added: 79345 | |
2024-01-30 10:19 | Mazi | Bug heat | 26 => 28 |
2024-01-31 15:25 | tibor.pacalat | Status | ready for testing => resolved |
2024-01-31 15:25 | tibor.pacalat | Resolution | open => fixed |
2024-11-19 18:14 | c_schmitz | Status | resolved => closed |