View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19183 | Bug reports | Theme editor | public | 2023-10-20 13:22 | 2023-10-30 10:54 |
Reporter | 2BITS_PL | Assigned To | mfavetti | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 5.6.x | ||||
Summary | 19183: No editing possible after setting the survey background | ||||
Description | In the theme edit level, I imported the survey background and then selected it. After saving, entering the theme edition (in the survey) returns an error: The problem is here: https://github.com/LimeSurvey/LimeSurvey/blob/5.x/application/views/themeOptions/options_core.php#L25 Undefined variable:
| ||||
Tags | No tags attached. | ||||
Bug heat | 12 | ||||
Complete LimeSurvey version number (& build) | 5.x last | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | SQL Server 2019 | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | v8.0.27 NTS x64 | ||||
Does this happen with debug => 0 too? |
|
You mean this setting? Some screenshots might help. |
|
This is exactly what this option is about, but for the imported file. The error appears in debug mode. |
|
@ollehar this is the same area I'm working on for 19086. Do you want to give this one to me and I can fix them together? |
|
also 19085 |
|
Ok I can reproduce on latest 5.x, PHP 8.0. Minimal steps from clean install:
I would definitely change this from block to minor. It only happens with debug > 0 and its only a php warning, not an error. Also it doesn't break user workflow at all. Definitely fixable but not urgent. When i do the 5.x PRs for the related issues, I have to touch that line of code anyways. So I'll address it then. Sorry @ollehar, I'm stealing it :P Also reproduced on 6.x (latest master) |
|
5.x: https://github.com/LimeSurvey/LimeSurvey/pull/3559 Please also see: Basically this is the same as the fix on develop, backported to master and 5.x branches Please note there will be merge conflicts between these PRs and the PRs for 19086 i have no way of knowing which will be merged first, so just ping me when they pop up and I will take care of it |
|
to reproduce: |
|
after fix: |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35666 |
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35667 |
|
Tested and merged. |
|
Fixed in Release 5.6.43+231030 |
|
LimeSurvey: master e5396298 2023-10-25 16:53 Committer: GitHub Details Diff |
Fixed issue 19183: No editing possible after setting the survey background (#3560) |
Affected Issues 19183 |
|
mod - application/views/themeOptions/options_core.php | Diff File | ||
LimeSurvey: 5.x e6a76695 2023-10-25 17:13 Committer: GitHub Details Diff |
Fixed issue 19183: No editing possible after setting the survey background (#3559) |
Affected Issues 19183 |
|
mod - application/views/themeOptions/options_core.php | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-10-20 13:22 | 2BITS_PL | New Issue | |
2023-10-20 15:19 | ollehar | Note Added: 77811 | |
2023-10-20 15:19 | ollehar | Bug heat | 0 => 2 |
2023-10-20 15:28 | ollehar | Note Added: 77813 | |
2023-10-20 15:28 | ollehar | File Added: LimeSurvey.png | |
2023-10-20 15:28 | ollehar | Assigned To | => ollehar |
2023-10-20 15:28 | ollehar | Status | new => feedback |
2023-10-20 16:06 | 2BITS_PL | Note Added: 77814 | |
2023-10-20 16:06 | 2BITS_PL | Bug heat | 2 => 4 |
2023-10-20 16:06 | 2BITS_PL | Status | feedback => assigned |
2023-10-20 22:00 | mfavetti | Relationship added | related to 19086 |
2023-10-20 22:02 | mfavetti | Note Added: 77819 | |
2023-10-20 22:02 | mfavetti | Bug heat | 4 => 6 |
2023-10-20 22:19 | mfavetti | Relationship added | related to 19085 |
2023-10-20 22:20 | mfavetti | Note Added: 77824 | |
2023-10-20 22:23 | mfavetti | Relationship added | related to 18880 |
2023-10-21 05:06 | mfavetti | Note Added: 77828 | |
2023-10-21 05:07 | mfavetti | Assigned To | ollehar => mfavetti |
2023-10-21 05:07 | mfavetti | Status | assigned => confirmed |
2023-10-21 05:07 | mfavetti | Severity | block => minor |
2023-10-21 23:45 | mfavetti | Note Added: 77830 | |
2023-10-21 23:45 | mfavetti | Assigned To | mfavetti => DenisChenu |
2023-10-21 23:45 | mfavetti | Status | confirmed => ready for code review |
2023-10-21 23:52 | mfavetti | Issue Monitored: mfavetti | |
2023-10-21 23:52 | mfavetti | Bug heat | 6 => 8 |
2023-10-22 01:36 | mfavetti | Note Edited: 77830 | |
2023-10-22 01:36 | mfavetti | Note Edited: 77828 | |
2023-10-23 11:42 | DenisChenu | Assigned To | DenisChenu => tibor.pacalat |
2023-10-23 11:42 | DenisChenu | Status | ready for code review => ready for testing |
2023-10-25 00:32 | mfavetti | File Deleted: LimeSurvey - Google Chrome 2023-10-24 15-25-50-converted.mp4 | |
2023-10-25 00:36 | mfavetti | Note Added: 77951 | |
2023-10-25 00:36 | mfavetti | File Added: LimeSurvey - Google Chrome 2023-10-24 15-34-44-converted.mp4 | |
2023-10-25 00:36 | mfavetti | Note Added: 77952 | |
2023-10-25 00:36 | mfavetti | File Added: LimeSurvey - Google Chrome 2023-10-24 15-35-33-converted.mp4 | |
2023-10-25 00:37 | mfavetti | Note Edited: 77951 | |
2023-10-25 14:53 | mfavetti | Changeset attached | => LimeSurvey master e5396298 |
2023-10-25 14:53 | mfavetti | Note Added: 77975 | |
2023-10-25 14:53 | mfavetti | Assigned To | tibor.pacalat => mfavetti |
2023-10-25 14:53 | mfavetti | Resolution | open => fixed |
2023-10-25 15:13 | mfavetti | Changeset attached | => LimeSurvey 5.x e6a76695 |
2023-10-25 15:13 | mfavetti | Note Added: 77977 | |
2023-10-25 15:14 | tibor.pacalat | Status | ready for testing => resolved |
2023-10-25 15:14 | tibor.pacalat | Note Added: 77978 | |
2023-10-25 15:14 | tibor.pacalat | Bug heat | 8 => 10 |
2023-10-30 10:54 | LimeBot | Note Added: 78122 | |
2023-10-30 10:54 | LimeBot | Status | resolved => closed |
2023-10-30 10:54 | LimeBot | Bug heat | 10 => 12 |