View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
18894 | Bug reports | Theme editor | public | 2023-06-19 08:13 | 2023-09-21 15:26 |
Reporter | OMdev | Assigned To | ollehar | ||
Priority | normal | Severity | block | ||
Status | ready for code review | Resolution | open | ||
Product Version | 6.1.x | ||||
Summary | 18894: Not able to add theme option text input | ||||
Description | Hello - We also not able to add text fields in theme options : Earlier we had options.twig and we were able to add whatever needed. | ||||
Steps To Reproduce | Steps to reproduceadd text box input in config.xml Expected resultGet text field theme option Actual resultWe dont get it (Write here what happened instead) | ||||
Tags | No tags attached. | ||||
Bug heat | 20 | ||||
Complete LimeSurvey version number (& build) | LimeSurvey Community Edition Version 6.1.3+230612 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | |||||
Database type & version | na | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | na | ||||
related to | 18895 | confirmed | No way to add textarea with core config.xml | |
related to | 18880 | ready for code review | p_teichmann | Unable to add imagefile except brandlogofile and backgroundimagefile in option |
You can still use options.twig : https://github.com/LimeSurvey/LimeSurvey/blob/a48ae2dc3a47077fefdd88d60afc5bbf69f10347/themes/survey/vanilla/config.xml#L94 Here the type must be text, not input … |
|
Since using the far better structured config.xml has various advantages, I'd like to see this fixed at LS 6.x. Using the options.twig is very error prone and far more difficult to use for new users. |
|
@ollehar, can we please assign these theme related tickets to a developer? We are currently working on making our templates compatible with version 6.x but this holds us back. |
|
@ollehar, @c_schmitz: We are currently stuck adjusting/developing themes for LS 6.x due to the various issues reported to defining theme options at config.xml. |
|
@gabrieljenik Want to pick this up? |
|
Thanks for picking this up @ollehar. |
|
https://github.com/LimeSurvey/LimeSurvey/pull/3354 |
|
Sample theme with sample option to set subtitle on welcome screen |
|
@gabrieljenik, this fix has the "Code review" tags for more than a month now and nothing has happened. But we need this fix for new projects. |
|
It i s up to the DEV team to review it. Sorry, not much I can do. |
|
@ollehar, assuming you are the boss of the DEV team: What are the next steps to finally bring this fix into the next release? |
|
ping @p_teichmann have fun ;) |
|
@ollerhar, why should I talk to @f_funke about this? To my knowledge he is not a developer? Or is he also testing bug fixes? |
|
Well this was kinda a grey zone between bug fix and new feature, but fine, reminding devs about stalled bug fixes is probably OK. |
|
@p_teichmann, can you review so we can finally have this essential fix available at one of the next releases? |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2023-06-19 08:13 | OMdev | New Issue | |
2023-06-19 08:20 | DenisChenu | Note Added: 75693 | |
2023-06-19 08:20 | DenisChenu | Bug heat | 0 => 2 |
2023-06-19 08:24 | DenisChenu | Relationship added | related to 18895 |
2023-06-19 08:31 | DenisChenu | Relationship added | related to 18880 |
2023-06-19 09:57 | Mazi | Note Added: 75698 | |
2023-06-19 09:57 | Mazi | Bug heat | 2 => 4 |
2023-06-19 10:23 | DenisChenu | Bug heat | 4 => 10 |
2023-06-19 10:37 | tibor.pacalat | Bug heat | 10 => 16 |
2023-06-28 11:03 | Mazi | Note Added: 75882 | |
2023-06-28 12:38 | DenisChenu | Summary | not able to add theme option type input => not able to add theme option text input |
2023-07-11 12:15 | Mazi | Note Added: 76030 | |
2023-08-08 11:21 | ollehar | Assigned To | => gabrieljenik |
2023-08-08 11:21 | ollehar | Status | new => assigned |
2023-08-08 11:21 | ollehar | Note Added: 76480 | |
2023-08-08 11:21 | ollehar | Bug heat | 16 => 18 |
2023-08-08 11:21 | ollehar | Priority | none => normal |
2023-08-08 11:21 | ollehar | Summary | not able to add theme option text input => Not able to add theme option text input |
2023-08-08 11:49 | Mazi | Note Added: 76485 | |
2023-08-11 21:15 | gabrieljenik | Assigned To | gabrieljenik => ollehar |
2023-08-11 21:15 | gabrieljenik | Status | assigned => ready for code review |
2023-08-11 21:15 | gabrieljenik | Note Added: 76543 | |
2023-08-11 21:15 | gabrieljenik | Bug heat | 18 => 20 |
2023-08-15 16:33 | gabrieljenik | Note Added: 76603 | |
2023-08-15 16:33 | gabrieljenik | File Added: fruity_18894.zip | |
2023-09-18 13:38 | Mazi | Note Added: 77109 | |
2023-09-18 13:50 | gabrieljenik | Note Added: 77112 | |
2023-09-18 14:00 | Mazi | Note Added: 77116 | |
2023-09-18 14:01 | ollehar | Note Added: 77117 | |
2023-09-18 14:08 | ollehar | Note Added: 77119 | |
2023-09-18 14:23 | Mazi | Note Added: 77123 | |
2023-09-18 15:07 | ollehar | Note Added: 77136 | |
2023-09-21 15:26 | Mazi | Note Added: 77222 |