Earlier we had options.twig and we were able to add whatever needed.

You can still use options.twig : https://github.com/LimeSurvey/LimeSurvey/blob/a48ae2dc3a47077fefdd88d60afc5bbf69f10347/themes/survey/vanilla/config.xml#L94

Here the type must be text, not input …

Since using the far better structured config.xml has various advantages, I'd like to see this fixed at LS 6.x. Using the options.twig is very error prone and far more difficult to use for new users.

@ollehar, can we please assign these theme related tickets to a developer? We are currently working on making our templates compatible with version 6.x but this holds us back.

@ollehar, @c_schmitz: We are currently stuck adjusting/developing themes for LS 6.x due to the various issues reported to defining theme options at config.xml.
Can someone look into this?

@gabrieljenik Want to pick this up?

Thanks for picking this up @ollehar.

https://github.com/LimeSurvey/LimeSurvey/pull/3354
(Dev, as this is the implementation of a missing feature: text inputs on theme options)

Sample theme with sample option to set subtitle on welcome screen

@gabrieljenik, this fix has the "Code review" tags for more than a month now and nothing has happened. But we need this fix for new projects.
What are the next steps?

It i s up to the DEV team to review it. Sorry, not much I can do.

@ollehar, assuming you are the boss of the DEV team: What are the next steps to finally bring this fix into the next release?

ping @p_teichmann have fun ;)

Or perhaps rather communicate with @f_funke, @Mazi.

@ollerhar, why should I talk to @f_funke about this? To my knowledge he is not a developer? Or is he also testing bug fixes?

Well this was kinda a grey zone between bug fix and new feature, but fine, reminding devs about stalled bug fixes is probably OK.

@p_teichmann, can you review so we can finally have this essential fix available at one of the next releases?

Guys, it looks like playing ping-pong with this ticket checking the history. What are the final steps to finally get this into the next release?

@c_schmitz, many hosting customers on your end seem to be forced to switch from old 3.x to newer 6.x version soon. Without having the basic theme issues fixed, we can not help our customers using your hosting to re-build their custom 3.x themes for the new 6.x version.

Seems good to me, not sure if 1 line as textbox size is enough

@gabrieljenik can you please resolve merge conflicts and maybe also merge develop into this branch https://github.com/LimeSurvey/LimeSurvey/pull/3354 ?

When I switch to this PR currently, and I press on Upload theme button, I get grey overlay and no modal :/

All green now.

@gabrieljenik with debug=2 after selecting the zip file to upload and clicking on install I am getting this error.

In case it matters, I have php 8.1

@tibor.pacalat: Sorry for being a little annoying. But can we finally have this integrated at the upcoming release?
All these template issues really hold us back from creating LS 6.x templates for customers.

@gabrieljenik with debug=2 after selecting the zip file to upload and clicking on install I am getting this error.

I will review and be back

@tibor.pacalat: Sorry for being a little annoying. But can we finally have this integrated at the upcoming release?
All these template issues really hold us back from creating LS 6.x templates for customers.

@Mazi sorry for holding you back, but I can't push things faster than they are going.

@tibor.pacalat Ready for re-reviewal

The problem was this PR: https://github.com/LimeSurvey/LimeSurvey/pull/3376/files
It added trim without taking into account that it could be null, which is not allowed on PHP 8.1.

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35879

@gabrieljenik, is this the same fix for a different branch/LS version or another fix to get this to work fine?

@gabrieljenik, is this the same fix for a different branch/LS version or another fix to get this to work fine?

Initial thought, it should work for v5 as well with not much of a hassle.

@gabrieljenik, we just tested the previously attached demo theme yesterday. That didn't display the text field. Is it still a bug or was that because the fix was not available at the latest release yet?

That didn't display the text field. Is it still a bug or was that because the fix was not available at the latest release yet?

I think this was released today

I have checked using : LimeSurvey Community Edition Version 6.3.9 using the template shared above [fruity_18894.zip ] by gabrieljenik 2023-08-15 16:33 and it seems to be not working. See screenshot please.

image.png (37,184 bytes)   

image.png (37,184 bytes)   

@Mazi @OMdev for me it works as expected (see screenshots).

Screenshot 2023-12-19 at 12.22.43.png (54,374 bytes)   

Screenshot 2023-12-19 at 12.22.43.png (54,374 bytes)   

@tibor.pacalat, which version/build did you test?

6.4.0+231218 using the provided theme. But, 6.3.9 should behave the same, since this was merged in a while ago.