View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|18894||Bug reports||Theme editor||public||2023-06-19 08:13||2023-11-20 14:53|
|Summary||18894: Not able to add theme option text input|
Hello - We also not able to add text fields in theme options :
Earlier we had options.twig and we were able to add whatever needed.
|Steps To Reproduce|
Steps to reproduce
add text box input in config.xml
Get text field theme option
We dont get it
(Write here what happened instead)
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||LimeSurvey Community Edition Version 6.1.3+230612|
|I will donate to the project if issue is resolved||No|
|Database type & version||na|
|Server OS (if known)|
|Webserver software & version (if known)|
You can still use options.twig : https://github.com/LimeSurvey/LimeSurvey/blob/a48ae2dc3a47077fefdd88d60afc5bbf69f10347/themes/survey/vanilla/config.xml#L94
Here the type must be text, not input …
Since using the far better structured config.xml has various advantages, I'd like to see this fixed at LS 6.x. Using the options.twig is very error prone and far more difficult to use for new users.
@ollehar, can we please assign these theme related tickets to a developer? We are currently working on making our templates compatible with version 6.x but this holds us back.
@gabrieljenik Want to pick this up?
Thanks for picking this up @ollehar.
Sample theme with sample option to set subtitle on welcome screen
fruity_18894.zip (109,751 bytes)
@gabrieljenik, this fix has the "Code review" tags for more than a month now and nothing has happened. But we need this fix for new projects.
It i s up to the DEV team to review it. Sorry, not much I can do.
@ollehar, assuming you are the boss of the DEV team: What are the next steps to finally bring this fix into the next release?
ping @p_teichmann have fun ;)
@ollerhar, why should I talk to @f_funke about this? To my knowledge he is not a developer? Or is he also testing bug fixes?
Well this was kinda a grey zone between bug fix and new feature, but fine, reminding devs about stalled bug fixes is probably OK.
@p_teichmann, can you review so we can finally have this essential fix available at one of the next releases?
Guys, it looks like playing ping-pong with this ticket checking the history. What are the final steps to finally get this into the next release?
@c_schmitz, many hosting customers on your end seem to be forced to switch from old 3.x to newer 6.x version soon. Without having the basic theme issues fixed, we can not help our customers using your hosting to re-build their custom 3.x themes for the new 6.x version.
Seems good to me, not sure if 1 line as textbox size is enough
@gabrieljenik can you please resolve merge conflicts and maybe also merge develop into this branch https://github.com/LimeSurvey/LimeSurvey/pull/3354 ?
When I switch to this PR currently, and I press on Upload theme button, I get grey overlay and no modal :/
All green now.
@gabrieljenik with debug=2 after selecting the zip file to upload and clicking on install I am getting this error.
In case it matters, I have php 8.1
Screenshot 2023-11-09 at 17.31.30.png (437,351 bytes)
@tibor.pacalat: Sorry for being a little annoying. But can we finally have this integrated at the upcoming release?
I will review and be back
@Mazi sorry for holding you back, but I can't push things faster than they are going.
@tibor.pacalat Ready for re-reviewal
The problem was this PR: https://github.com/LimeSurvey/LimeSurvey/pull/3376/files
|2023-06-19 08:13||OMdev||New Issue|
|2023-06-19 08:20||DenisChenu||Note Added: 75693|
|2023-06-19 08:20||DenisChenu||Bug heat||0 => 2|
|2023-06-19 08:24||DenisChenu||Relationship added||related to 18895|
|2023-06-19 08:31||DenisChenu||Relationship added||related to 18880|
|2023-06-19 09:57||Mazi||Note Added: 75698|
|2023-06-19 09:57||Mazi||Bug heat||2 => 4|
|2023-06-19 10:23||DenisChenu||Bug heat||4 => 10|
|2023-06-19 10:37||tibor.pacalat||Bug heat||10 => 16|
|2023-06-28 11:03||Mazi||Note Added: 75882|
|2023-06-28 12:38||DenisChenu||Summary||not able to add theme option type input => not able to add theme option text input|
|2023-07-11 12:15||Mazi||Note Added: 76030|
|2023-08-08 11:21||ollehar||Assigned To||=> gabrieljenik|
|2023-08-08 11:21||ollehar||Status||new => assigned|
|2023-08-08 11:21||ollehar||Note Added: 76480|
|2023-08-08 11:21||ollehar||Bug heat||16 => 18|
|2023-08-08 11:21||ollehar||Priority||none => normal|
|2023-08-08 11:21||ollehar||Summary||not able to add theme option text input => Not able to add theme option text input|
|2023-08-08 11:49||Mazi||Note Added: 76485|
|2023-08-11 21:15||gabrieljenik||Assigned To||gabrieljenik => ollehar|
|2023-08-11 21:15||gabrieljenik||Status||assigned => ready for code review|
|2023-08-11 21:15||gabrieljenik||Note Added: 76543|
|2023-08-11 21:15||gabrieljenik||Bug heat||18 => 20|
|2023-08-15 16:33||gabrieljenik||Note Added: 76603|
|2023-08-15 16:33||gabrieljenik||File Added: fruity_18894.zip|
|2023-09-18 13:38||Mazi||Note Added: 77109|
|2023-09-18 13:50||gabrieljenik||Note Added: 77112|
|2023-09-18 14:00||Mazi||Note Added: 77116|
|2023-09-18 14:01||ollehar||Note Added: 77117|
|2023-09-18 14:08||ollehar||Note Added: 77119|
|2023-09-18 14:23||Mazi||Note Added: 77123|
|2023-09-18 15:07||ollehar||Note Added: 77136|
|2023-09-21 15:26||Mazi||Note Added: 77222|
|2023-11-01 17:31||p_teichmann||Status||ready for code review => in code review|
|2023-11-02 10:36||p_teichmann||Assigned To||ollehar => p_teichmann|
|2023-11-02 11:57||Mazi||Note Added: 78211|
|2023-11-07 14:45||p_teichmann||Note Added: 78313|
|2023-11-07 14:45||p_teichmann||Bug heat||20 => 22|
|2023-11-07 14:46||p_teichmann||Assigned To||p_teichmann => tibor.pacalat|
|2023-11-07 14:46||p_teichmann||Status||in code review => ready for testing|
|2023-11-07 15:15||tibor.pacalat||Note Added: 78314|
|2023-11-07 15:15||tibor.pacalat||Bug heat||22 => 24|
|2023-11-07 15:18||tibor.pacalat||Note Edited: 78314|
|2023-11-08 12:52||gabrieljenik||Note Added: 78333|
|2023-11-09 17:48||tibor.pacalat||Note Added: 78355|
|2023-11-09 17:48||tibor.pacalat||File Added: Screenshot 2023-11-09 at 17.31.30.png|
|2023-11-10 14:36||tibor.pacalat||Note Edited: 78355|
|2023-11-13 10:01||Mazi||Note Added: 78404|
|2023-11-13 14:06||gabrieljenik||Note Added: 78410|
|2023-11-14 11:43||tibor.pacalat||Note Added: 78450|
|2023-11-16 21:09||gabrieljenik||Note Added: 78504|
|2023-11-20 14:53||tibor.pacalat||Status||ready for testing => resolved|
|2023-11-20 14:53||tibor.pacalat||Resolution||open => fixed|