Before/after data entry submit.

mysql> select * from survey_298188;
+----+-------+------------+----------+---------------+-----------+--------------------+--------------------+
| id | token | submitdate | lastpage | startlanguage | seed      | 298188X83X259SQ001 | 298188X84X260SQ001 |
+----+-------+------------+----------+---------------+-----------+--------------------+--------------------+
|  1 | NULL  | NULL       |        1 | en            | 203463304 | Y                  | NULL               |
+----+-------+------------+----------+---------------+-----------+--------------------+--------------------+
1 row in set (0,00 sec)

mysql> select * from survey_298188;
+----+-------+------------+----------+---------------+------+--------------------+--------------------+
| id | token | submitdate | lastpage | startlanguage | seed | 298188X83X259SQ001 | 298188X84X260SQ001 |
+----+-------+------------+----------+---------------+------+--------------------+--------------------+
|  1 | NULL  | NULL       |        1 | en            |      | Y                  |                    |
+----+-------+------------+----------+---------------+------+--------------------+--------------------+

Checkbox for yes/no question: Checked = yes, Not checked = No.

Not checked : empty string (not No)

298188X84X260SQ001 as NULL : it means not shown by condition , not NOT checked

I know, Denis, read again please. The issue is the DATA ENTRY screen (edit response).

OK : you confirm 298188X84X260SQ001 was hidden by relevance ?
It's what i don't understand :)

PS : i think it's same issue for ALL question : for example single choice.

Have a lss file with

A Y/N question
A single choice with relevance set to Q00.NAOK == "Y'

Can help to find the issue.

Not related to checkbox …

Data entry don't use relevance

Steps to reproduce

1. Import included survey,
2. Lauch and submit
3. Check statistics : one Not completed or Not displayed
4. Go to response
5. Edit the last response
6. Save
7. Check statistics

Expected result

one Not completed or Not displayed

Actual result

zero Not completed or Not displayed (moved to No answer)

Capture d’écran du 2023-03-18 14-18-32.png (29,777 bytes)   

Capture d’écran du 2023-03-18 14-18-32.png (29,777 bytes)   

Capture d’écran du 2023-03-18 14-19-19.png (30,167 bytes)   

Capture d’écran du 2023-03-18 14-19-19.png (30,167 bytes)   

Worst : you can set Yes to the G01Q02
And i think you can submit invalid value

data entry screen are not made for this …

Solution :

1. Allow to laucnh any survey as public https://gitlab.com/SondagesPro/coreAndTools/reloadAnyResponse
2. RecomputeExpression : https://gitlab.com/SondagesPro/RemoteControl/RemoteManageResponse/-/blob/main/RemoteControlHandler.php#L163
3. do all ExpressionManager action when try submitting Data entry screen (and set survey as All in one page) (need a lot of rewrite of Expression Manager and SurveyRuntim (and frontend_helpr)

Another issue : Equation are not updated when using Data entry screen

Jesus, give me a break... Don't change title please.

The reported issue is about pages and checkboxes, not relevance eq.

One solution might be to regard lastpage visited in the answer table when processing the POST in data entry. Another solution is to never POST the whole page, just single questions.

It could also be made visible if a question was shown to the user or not.

OK : you confirm 298188X84X260SQ001 was hidden by relevance ?

No, it's another question group, so on another page --> never visited/seen.

No, it's another question group, so on another page --> never visited/seen.

Maybe make a complete report is better then … to fix an issue : you need to know exactly what is the issue …

No, it's another question group, so on another page --> never visited/seen.

But you can eventually set as Completed a not completed response.
And we can not update (currently) the last page …

Maybe make a complete report is better then … to fix an issue : you need to know exactly what is the issue …

Yes sorry, we have an affected customer, this is just my notes, we'll pick it up during the week I think.

For lastpage : i really think the only way is to add warning on edit page … there are no way to allow set as complete …

And more : Data edition is used for prefilling answer , then if set NULL according to last page set : this feature is broken …

2 possible solution here

1. Add a 'Set to null" checkbox option on all question (checked if already null)
2. Add a N when checkbox is not checked for multiple choice in Question twig, and show it with 3 option when edit : Y + N + No answer (Big API update ? Except if we do it in option).

For lastpage : i really think the only way is to add warning on edit page … there are no way to allow set as complete …

Not sure what such a warning would say? Don't use this feature if you have checkboxes for yes/no?

Add a 'Set to null" checkbox option on all question (checked if already null)

Yes, but might make the POST too big, basically doubling its size in number of inputs.

About 2, not sure. It's already a bit strange that unchecked is saved as empty string, isn't it? But hard to change if people rely on it.

Yes, but might make the POST too big, basically doubling its size in number of inputs.

Since we move Answers + Subquestions with all Question settings : i think we don't care about number of inputs.

About 2, not sure. It's already a bit strange that unchecked is saved as empty string, isn't it? But hard to change if people rely on it.

Question settings ?
Save false as N (default to false)

It can not be a QuestionTheme since QuestionTheme don't update Data Entry.

Since we move Answers + Subquestions with all Question settings : i think we don't care about number of inputs.

That's one question, much less than the entire survey. Stop complaining xD

That's one question, much less than the entire survey. Stop complaining xD

;)
(but : unsure about much less)

The biggest part about number of data sent was Quick Translation since years now.

Current suggestion after discussion: Add a new column in the [html] table, with a checkbox for each question. "Unseen", checked if value is null in database.

If this checkbox is checked, DO NOT make any changes in the database for this question (should keep being NULL).

Current suggestion after discussion: Add a new column in the table, with a checkbox for each question. "Unseen", checked if value is null in database.

But we already have issue with number of question with multiple choice.

But we already have issue with number of question with multiple choice.

Do we tho? If it's visited, all columns in db is already empty string OR "Y", not null.

But more : it's for all questions ?

Then limit is not at 800 questions but at 400 for mysql ?

It's a joke ?

https://manual.limesurvey.org/General_FAQ/en#...regarding_survey_size

We're not gonna change the database structure, just the posted form.

Add a new column in the table

Sorry, new column in the HTML table! :D <table> etc

Ouf :)
A Checkbox "Set as unseen/unrelevant"

:+1:

Sorry sorry …

https://github.com/LimeSurvey/LimeSurvey/pull/3018

To avoid issue with subquestion : maybe {$fname['fieldname']}:unseen ?

Some fix to do

1. Single choice with comment : unseen state
2. Numeric : unseen state shown for not answered
3. Multi numeric : unseen state shown for not answered
4. Date : unseen state shown for not answered

We must avoid to loose text (sometime big) by error Then

Unseen checkbox must tested only if value ===""

Peek 05-05-2023 16-37.gif (53,427 bytes)   

Peek 05-05-2023 16-37.gif (53,427 bytes)   

6.X version have same issue

1. Single choice with comment not answered : unseen state
2. Numeric : unseen state shown for not answered
3. Multi numeric : unseen state shown for not answered
4. Date : unseen state shown for not answered
5. We must avoid to loose text Then : Unseen checkbox must tested only if value ===""

5x PR: https://github.com/LimeSurvey/LimeSurvey/pull/3109

v5 is ready for re-reviewal.

Added validation: Unseen can onlybe checked if answer is empty.
Had to add some options (answer options) for making answers empty on some control types (this screen was rather outdated)
Had to add a hook mechanism on the save.js, as to run custom validation before submitting a form.
(was on 3.x, not on v5, nor v6)

Had to add a hook mechanism on the save.js, as to run custom validation before submitting a form.

It's always good to add validation.
Here : i think i prefer unchecking (and set as disable) checkbox when there are data in input, maybe as feature request ? Or if UX tester can give advice .

Else : still the issue woith numeric and date question type : this item must NOT have an uinseen checkbox, or label must be «unseen or not answered»

I send a LSA in 2 minutes

Capture d’écran du 2023-05-18 16-37-01.png (67,970 bytes)   

Capture d’écran du 2023-05-18 16-37-01.png (67,970 bytes)   

The LSA showing the issue on numeric+multi-numeric+date

Steps to reproduce

1. Import
2. Launch : don't enter something in any quetstion (you can not submit :D)
3. Submit
4. Go to browse response
5. Edit submitted response

Expected result

See all question seen

Actual result

The 3 primary question shown as unseen.

Still the numeric+date issue

PS : if you find a solution to avoid this
for multiple choice (unseen column ?) UX can be really better.
(i didn't set as Needs update by author, juts if you have a better solution).

Capture d’écran du 2023-05-18 16-50-11.png (19,921 bytes)   

Capture d’écran du 2023-05-18 16-50-11.png (19,921 bytes)   

i think i prefer unchecking (and set as disable) checkbox when there are data in input, maybe as feature request

Yes please, another ticket.

still the issue woith numeric and date question type : this item must NOT have an uinseen checkbox, or label must be «unseen or not answered»

I think we missed the label part.
Let me review.

PS : if you find a solution to avoid this

Another ticket :)
If not, this will be neverending story :)

Ready for merge.
Please, if possible, review it as well. These touches lot of stuff and sensitive (data edit)

@gabrieljenik can you please resolve conflicts here https://github.com/LimeSurvey/LimeSurvey/pull/3109 ?

Done

Ooooh we can finally merge this? :D Hooray!

There are conflicts in master branch @gabrieljenik https://github.com/LimeSurvey/LimeSurvey/pull/3018

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34807

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34806

tested and merged

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34814

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34815