18659: cannot install two plugins in a row - LimeSurvey bugs and feature requests

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18659	Bug reports	Plugins	public	2023-02-28 15:07	2023-06-14 14:17

Reporter	ritapas	Assigned To	gabrieljenik
Priority	none	Severity	partial_block
Status	closed	Resolution	fixed

Summary	18659: cannot install two plugins in a row
Description	If I install two plugins in a row, the attempt to install the second fails.
Steps To Reproduce	Steps to reproduce Install a plugin (e.g. the DummyPlugin1 I enclose here). Get successful installation feedback for DummyPlugin1. Install a second plugin (e.g. the DummyPlugin2 I enclose here). Expected result Get successful installation feedback for DummyPlugin2. Actual result I am prompted to update DummyPlugin1 . If I abort such update and try again, DummyPlugin2 is installed successfully.
Tags	No tags attached.
Attached Files	DummyPlugin2.zip (2,143 bytes) DummyPlugin1.zip (2,143 bytes)

Bug heat	10
Complete LimeSurvey version number (& build)	5.4.14 (build 221205)
I will donate to the project if issue is resolved	No
Browser
Database type & version	mariadb-10.3.35
Server OS (if known)	Red Hat Enterprise Linux release 8.7 (Ootpa)
Webserver software & version (if known)	httpd-2.4.37
PHP Version	php-fpm-7.4.30

User List	ritapas

gabrieljenik 2023-05-17 22:02 manager ~75048	PR for v5 https://github.com/LimeSurvey/LimeSurvey/pull/3146 If good will port to v6

DenisChenu 2023-05-18 16:52 developer ~75087	:+1:

gabrieljenik 2023-05-18 17:39 manager ~75088	Remains pending (for other tickets): How orphan temp plugin files should be handled Clean up the files when the plugin finishes successfully installing

gabrieljenik 2023-05-19 20:52 manager ~75121	PR Master: https://github.com/LimeSurvey/LimeSurvey/pull/3160

tibor.pacalat 2023-05-23 17:30 administrator ~75189	@gabrieljenik I couldn't reproduce this issue in 5.x . Is this issue connected with specific subversion and/or database (I am using 5.6.22 and MySql)? But it works with and without fix for me.

guest 2023-05-23 17:52 viewer ~75193	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34711

guest 2023-05-23 17:55 viewer ~75194	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34712

guest 2023-06-14 14:17 viewer ~75628	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34814

guest 2023-06-14 14:17 viewer ~75629	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34815

LimeSurvey: master 0df83112 2023-05-23 17:29:20 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18659: cannot install two plugins in a row (#3160) Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18659
	mod - application/libraries/ExtensionInstaller/FileFetcherUploadZip.php	Diff File
LimeSurvey: 5.x f79c3339 2023-05-23 17:29:49 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18659: cannot install two plugins in a row (#3146) Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18659
	mod - application/libraries/ExtensionInstaller/FileFetcherUploadZip.php	Diff File
LimeSurvey: master 3ee692cc 2023-06-14 14:04:14 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view (#3018) * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix Data Entry crash with debug=2 * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Revert "Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view" This reverts commit 2e2edc9d9e2c7c39b26eb7234af5e0d80d3f1949. * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18659: cannot install two plugins in a row * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix after merge * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix bug when last question has subquestions ( === false) - Don't throw exception when Unseen is checked and a value is provided * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix file changed by mistake --------- Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18659, 18693
	mod - application/controllers/admin/DataEntry.php	Diff File
	mod - assets/admin_themes/adminbasics_temporary/000-lime-admin-common.scss	Diff File
	mod - assets/packages/adminbasics/build/adminbasics.js	Diff File
	mod - assets/packages/adminbasics/build/adminbasics.min.js	Diff File
	mod - assets/packages/adminbasics/src/parts/save.js	Diff File
	add - assets/scripts/admin/dataentry.js	Diff File
	mod - themes/admin/Sea_Green/css/sea_green-rtl.css	Diff File
	mod - themes/admin/Sea_Green/css/sea_green-rtl.min.css	Diff File
	mod - themes/admin/Sea_Green/css/sea_green.css	Diff File
	mod - themes/admin/Sea_Green/css/sea_green.min.css	Diff File
LimeSurvey: master 3ee692cc 2023-06-14 14:04:14 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view (#3018) * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix Data Entry crash with debug=2 * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Revert "Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view" This reverts commit 2e2edc9d9e2c7c39b26eb7234af5e0d80d3f1949. * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18659: cannot install two plugins in a row * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix after merge * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix bug when last question has subquestions ( === false) - Don't throw exception when Unseen is checked and a value is provided * Fixed issue 18693: Using checkbox question for yes/no loses data when data entry view - Fix file changed by mistake --------- Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18659, 18693
	mod - application/controllers/admin/DataEntry.php	Diff File
	mod - assets/admin_themes/adminbasics_temporary/000-lime-admin-common.scss	Diff File
	mod - assets/packages/adminbasics/build/adminbasics.js	Diff File
	mod - assets/packages/adminbasics/build/adminbasics.min.js	Diff File
	mod - assets/packages/adminbasics/src/parts/save.js	Diff File
	add - assets/scripts/admin/dataentry.js	Diff File
	mod - themes/admin/Sea_Green/css/sea_green-rtl.css	Diff File
	mod - themes/admin/Sea_Green/css/sea_green-rtl.min.css	Diff File
	mod - themes/admin/Sea_Green/css/sea_green.css	Diff File
	mod - themes/admin/Sea_Green/css/sea_green.min.css	Diff File

Date Modified	Username	Field	Change
2023-02-28 15:07	ritapas	New Issue
2023-02-28 15:07	ritapas	File Added: DummyPlugin2.zip
2023-02-28 15:07	ritapas	File Added: DummyPlugin1.zip
2023-03-09 14:45	gabrieljenik	Status	new => confirmed
2023-04-07 14:36	ritapas	Issue Monitored: ritapas
2023-04-07 14:36	ritapas	Bug heat	0 => 2
2023-05-17 22:02	gabrieljenik	Assigned To	=> DenisChenu
2023-05-17 22:02	gabrieljenik	Status	confirmed => ready for code review
2023-05-17 22:02	gabrieljenik	Note Added: 75048
2023-05-17 22:02	gabrieljenik	Bug heat	2 => 4
2023-05-18 16:52	DenisChenu	Note Added: 75087
2023-05-18 16:52	DenisChenu	Bug heat	4 => 6
2023-05-18 16:53	DenisChenu	Assigned To	DenisChenu => gabrieljenik
2023-05-18 16:53	DenisChenu	Status	ready for code review => ready for testing
2023-05-18 17:39	gabrieljenik	Note Added: 75088
2023-05-18 17:41	gabrieljenik	Issue cloned: 18828
2023-05-18 17:41	gabrieljenik	Relationship added	related to 18828
2023-05-18 17:43	gabrieljenik	Issue cloned: 18829
2023-05-18 17:43	gabrieljenik	Relationship added	related to 18829
2023-05-19 20:52	gabrieljenik	Note Added: 75121
2023-05-23 17:30	tibor.pacalat	Note Added: 75189
2023-05-23 17:30	tibor.pacalat	Bug heat	6 => 8
2023-05-23 17:30	tibor.pacalat	Status	ready for testing => closed
2023-05-23 17:30	tibor.pacalat	Resolution	open => fixed
2023-05-23 17:52		Changeset attached	=> LimeSurvey master 0df83112
2023-05-23 17:52	guest	Note Added: 75193
2023-05-23 17:52	guest	Bug heat	8 => 10
2023-05-23 17:55		Changeset attached	=> LimeSurvey 5.x f79c3339
2023-05-23 17:55	guest	Note Added: 75194
2023-06-14 14:17		Changeset attached	=> LimeSurvey master 3ee692cc
2023-06-14 14:17		Changeset attached	=> LimeSurvey master 3ee692cc
2023-06-14 14:17	guest	Note Added: 75628
2023-06-14 14:17	guest	Note Added: 75629

View Issue Details

Steps to reproduce

Expected result

Actual result

Relationships

Users monitoring this issue

Activities

Related Changesets

Issue History

related to	18828	confirmed		Clean up the files when the plugin finishes successfully installing
related to	18829	confirmed		How orphan temp plugin files should be handled