Can you provide more steps for rerproducing?
I think you had some kind of orphan records or broken relationships..

So the problem happens when you create a usergrp as a user and then delete the user, when you then go to the usergroups page the error is visible. The main problem is that the users dont get deleted at all from the tables "user_groups" and "user_in_groups".

Part of the problems had to do with the fact that the code assumed that if you were the owner you were in the group. In LTS it is like this, the owner is always in the group. But in master no.

Also done:

• Transfer to user 1 if the owner user is deleted
• If the owner of a group no longer exists, instead of the name it shows "(Deleted user)" in the table. (shouldn't happen, but still)
• Fixed inconsistencies in the actionViewGroup(). Things that were set inside IF statements and were always used.

https://github.com/LimeSurvey/LimeSurvey/pull/2565

My opinion : we must have a clean decision about $userGroup->owner_id == Yii::app()->user->id on the right part
We don't have this control in 3.X

I think we must have UserGroup->hasPermission with something like this

    /* superadmin can do whole */
    if(Permission::model()->hasPermission(0, 'global', 'superadmin', 'read', $iUserID)) {
        return true;
    }
    /* usercontrolSameGroupPolicy : need to be in group */
    if (App()->getConfig('usercontrolSameGroupPolicy') && !$this->hasUser($iUserID)) {
        return false;
    }
    /* Check global right only (no single rights) */
    return Permission::model()->hasPermission(0, 'global', 'usergroups', $sCRUD, $iUserID);

When decision is done about owner : we can easily add it here.

I think we must have UserGroup->hasPermission with something like this

So, you wouldn't care about who owns the group, right?

Currently no, be cause we don't care in 3.X and in current 5.X.
owner_id are not used in UserGroup permission since years … do not add it without discussion (and API update)

Then : need decision about usage of owner_id before adding it.

See the last sentence

When decision is done about owner : we can easily add it here.

owner_id are not used in UserGroup permission since years

Not sure if we are talking about the same thing... I see it is being used a lot...

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/UserGroup.php#L191
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/UserGroup.php#L232

https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/UserGroupController.php#L178
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/UserGroupController.php#L190
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/UserGroupController.php#L347
....

Are we talking about the same stuff?

do not add it without discussion (and API update)

No worries, I am not saying I will, I will not... Why would I?

Not sure if we are talking about the same thing... I see it is being used a lot...

Seems to didn't work with specific permission then …

Time to update to real Permission system …
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Traits/PermissionTrait.php

Look forward for decisions and directions ...

For LS5:
The group owner should be member of the group.
For LS6:
The group owner can be a group member, but doesn't have to be. However, the group owner should always be able to see/edit group members.

@tibor.pacalat if you could test it one more time before merging would be great as this seems sensitive

@gabrieljenik when I include owner in the group (let's say 2 members and owner), and then delete the owner, members count doesn't account for that and shows 3 still.

Also, I noticed there is no way to change owner of the group once the owner has been deleted (except from the DB).

Screenshot 2023-07-10 at 13.24.23.png (25,933 bytes)   

Screenshot 2023-07-10 at 13.24.23.png (25,933 bytes)   

when I include owner in the group (let's say 2 members and owner), and then delete the owner, members count doesn't account for that and shows 3 still.

That's treated on 18936
We can wait and merge both at the same time if prefer.

No, that is fine, I merged it.

v5 is pending. Will add PR soon

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34954

v5: https://github.com/LimeSurvey/LimeSurvey/pull/3284

Fixed in Release 6.1.8+230717

Please, if possible give it a quick test as this may be sensitive.

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35185

Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35184

Tested fix for 5.x and merged.

Fixed in Release 5.6.32+230731