18936: User count in group is not OK after deleting a user.

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

18936	Bug reports	User / Groups / Roles	public	2023-07-03 22:45	2023-08-08 23:28

Reporter	gabrieljenik	Assigned To	tibor.pacalat
Priority	none	Severity	minor
Status	resolved	Resolution	fixed
Product Version	5.3.x

Summary	18936: User count in group is not OK after deleting a user.
Description	After deleting a user, which was in a group, on the "user groups" screen shows a wron number in the "Members" column. Caught while reviewing 18281
Steps To Reproduce	Scenario: Created user A Created a group Add user A to the group Delete user A The group is left without members but in the "user groups" table it continues to appear, in the "Members" column, the number of members it had (even though it has been eliminated).
Tags	No tags attached.

Bug heat	8
Complete LimeSurvey version number (& build)	5
I will donate to the project if issue is resolved	No
Browser
Database type & version	MySQL
Server OS (if known)
Webserver software & version (if known)
PHP Version	7.2

User List	There are no users monitoring this issue.

gabrieljenik 2023-07-12 22:16 manager ~76068	This is built on top of 18281, so waiting on it to be pushed to v5 to create the PR.

gabrieljenik 2023-07-13 21:09 manager ~76084	Master: https://github.com/LimeSurvey/LimeSurvey/pull/3286/files

gabrieljenik 2023-07-20 14:24 manager ~76195	As it is some kind sensitive (deletion of user) please if you can given an extra test would be great. Please bear in mind removing can happen from action menu as well as from massive action.

tibor.pacalat 2023-07-21 12:52 administrator ~76216	This is still an issue in 5.x, please fix it there as well.

tibor.pacalat 2023-07-21 12:57 administrator ~76217	I have verified the fix on master.

guest 2023-07-21 12:58 viewer ~76218	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35201

guest 2023-07-21 12:58 viewer ~76219	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35200

gabrieljenik 2023-07-25 21:40 manager ~76263	v5: https://github.com/LimeSurvey/LimeSurvey/pull/3306

LimeBot 2023-07-31 15:02 administrator ~76369	Fixed in Release 6.2.0+230732

gabrieljenik 2023-08-02 15:26 manager ~76401	We have tested OK v5. Still @tibor.pacalat can you also give it a try (as it is sensitive and we did some code reorg)? Thanks

tibor.pacalat 2023-08-02 17:25 administrator ~76407	Yup, will do!

tibor.pacalat 2023-08-03 15:44 administrator ~76418	Tested and merged.

guest 2023-08-03 15:59 viewer ~76421	Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35309

gabrieljenik 2023-08-08 23:28 manager ~76495	Tests for master: https://github.com/LimeSurvey/LimeSurvey/pull/3344

LimeSurvey: master 56af913f 2023-07-21 12:58:14 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18936: User count in group is not OK after deleting a user (#3286) Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18936
	mod - application/controllers/UserManagementController.php	Diff File
	add - application/datavalueobjects/OperationResult.php	Diff File
	add - application/datavalueobjects/TypedMessage.php	Diff File
	mod - application/models/services/UserManager.php	Diff File
LimeSurvey: master 56af913f 2023-07-21 12:58:14 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18936: User count in group is not OK after deleting a user (#3286) Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18936
	mod - application/controllers/UserManagementController.php	Diff File
	add - application/datavalueobjects/OperationResult.php	Diff File
	add - application/datavalueobjects/TypedMessage.php	Diff File
	mod - application/models/services/UserManager.php	Diff File
LimeSurvey: 5.x 2fee7cc1 2023-08-03 15:43:57 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 18936: User count in group is not OK after deleting a user (#3306) Co-authored-by: encuestabizdevgit <devgit@encuesta.biz> Co-authored-by: lapiudevgit <devgit@lapiu.biz>	Affected Issues 18936
	mod - application/controllers/UserManagementController.php	Diff File
	add - application/datavalueobjects/OperationResult.php	Diff File
	add - application/datavalueobjects/TypedMessage.php	Diff File
	mod - application/models/services/UserManager.php	Diff File

Date Modified	Username	Field	Change
2023-07-03 22:45	gabrieljenik	New Issue
2023-07-03 22:45	gabrieljenik	Issue generated from: 18281
2023-07-03 22:45	gabrieljenik	Relationship added	related to 18281
2023-07-03 22:51	gabrieljenik	Assigned To	=> gabrieljenik
2023-07-03 22:51	gabrieljenik	Status	new => assigned
2023-07-12 22:16	gabrieljenik	Note Added: 76068
2023-07-12 22:16	gabrieljenik	Bug heat	0 => 2
2023-07-13 21:05	gabrieljenik	Description Updated
2023-07-13 21:05	gabrieljenik	Steps to Reproduce Updated
2023-07-13 21:09	gabrieljenik	Assigned To	gabrieljenik => DenisChenu
2023-07-13 21:09	gabrieljenik	Status	assigned => ready for code review
2023-07-13 21:09	gabrieljenik	Note Added: 76084
2023-07-20 14:24	gabrieljenik	Assigned To	DenisChenu => tibor.pacalat
2023-07-20 14:24	gabrieljenik	Status	ready for code review => ready for merge
2023-07-20 14:24	gabrieljenik	Note Added: 76195
2023-07-21 12:52	tibor.pacalat	Note Added: 76216
2023-07-21 12:52	tibor.pacalat	Bug heat	2 => 4
2023-07-21 12:57	tibor.pacalat	Note Added: 76217
2023-07-21 12:58		Changeset attached	=> LimeSurvey master 56af913f
2023-07-21 12:58		Changeset attached	=> LimeSurvey master 56af913f
2023-07-21 12:58	guest	Note Added: 76219
2023-07-21 12:58	guest	Note Added: 76218
2023-07-21 12:58	guest	Bug heat	4 => 6
2023-07-21 12:58	guest	Bug heat	4 => 6
2023-07-25 21:40	gabrieljenik	Assigned To	tibor.pacalat => DenisChenu
2023-07-25 21:40	gabrieljenik	Status	ready for merge => ready for code review
2023-07-25 21:40	gabrieljenik	Note Added: 76263
2023-07-26 08:54	DenisChenu	Assigned To	DenisChenu => gabrieljenik
2023-07-26 08:54	DenisChenu	Status	ready for code review => ready for testing
2023-07-31 15:02	LimeBot	Note Added: 76369
2023-07-31 15:02	LimeBot	Status	ready for testing => closed
2023-07-31 15:02	LimeBot	Resolution	open => fixed
2023-07-31 15:02	LimeBot	Bug heat	6 => 8
2023-08-02 15:26	gabrieljenik	Assigned To	gabrieljenik => tibor.pacalat
2023-08-02 15:26	gabrieljenik	Status	closed => in testing
2023-08-02 15:26	gabrieljenik	Note Added: 76401
2023-08-02 17:25	tibor.pacalat	Note Added: 76407
2023-08-03 15:44	tibor.pacalat	Status	in testing => resolved
2023-08-03 15:44	tibor.pacalat	Note Added: 76418
2023-08-03 15:59		Changeset attached	=> LimeSurvey 5.x 2fee7cc1
2023-08-03 15:59	guest	Note Added: 76421
2023-08-08 23:28	gabrieljenik	Note Added: 76495

View Issue Details

Relationships

Users monitoring this issue

Activities

Related Changesets

Issue History