On 4.6.3 with firefox : mobile view : seems to work.

I check on a real phone browser (after update ùmy online test)

Capture d’écran_2021-05-22_14-29-57.png (20,967 bytes)   

Capture d’écran_2021-05-22_14-29-57.png (20,967 bytes)   

@DenisChenu, I checked with Chrome using mobile simulation. Test link: https://demo.limesurvey.org/index.php?r=survey/index&sid=619922&newtest=Y&lang=en

Same with firefox on your link

But not on : https://master.sondages.pro/619922?newtest=Y&lang=en
It's an update issue : reset vanilla theme : its'OK now.

Explanation :

3.X css : https://github.com/LimeSurvey/LimeSurvey/blob/7220965bf32581024d43a6328b4fa7c43bd6d21a/themes/survey/vanilla/config.xml#L49-L53
master CSS : https://github.com/LimeSurvey/LimeSurvey/blob/c3736063160f821c72ba87a1cea52abc804e9a24/themes/survey/vanilla/config.xml#L42-L47

Then : when you update from 3.X to 4.X : if you don't reset config : css/noTablesOnMobile.css is not loaded.

I attach to related issue now way to update onky , need to reset whole theme options on all survey to add one option or one css is a big big issue for all theme devlopper (and the reason why i'm at skelvanilla 9.X version)

It's one of the reason why i must remove css/noTablesOnMobile.css from 4.X version for sklelvanilla : it broke my system …

So, not a bug...?

Still an issue : when update form 3.X to 4.X : all table are broken until reset whole theme option on all surveys …

How do you reset theme options, even? oO

Also, I'm not sure why there are so many related issues...?

You'r right : still related but there are a lack of "update without reset" option.

I can confirm that resetting the vanilla theme and the custom theme fixed the problem.

Still, there needs to be a solution to prevent such manual edits when doing an update!

Still, there needs to be a solution to prevent such manual edits when doing an update!

And :

1. Set a specific logo fort one survey ( or one hundred, or one thousand)
2. Update to 4.X
3. Need to reset theme
4. All specific logo disappear …

I asked Gabriel to have a look at it this week.

Hi All!

Just to be clear and making sure we are on the same page, what do you call "resetting the theme"?

We couldn't reproduce the issue, although obviosuly you can :)
OK, may I ask you how you had your files_css option for one of your extended themes?

As to solve this, as you did, resetting vanilla would be OK, as it would pickup the definition from the manifest, which after the upgrade has the noTables css. Question would be, why did you had to reset the extended theme as well?

On upgrade db version 428, a new css is added to the vanilla and bootswatch theme: noTablesOnMobile.css.
That seems not to have run in your environment.
This I understand is the key to the problem.

files_css at config.xml looks like this:
<css>
<add>css/base.css</add>
<add>css/ajaxify.css</add>
<add>css/theme.css</add>
<add>css/custom.css</add>
</css>

Obviously, the old Ajax files can be removed.

We resetted our own theme just in case. I wasn't sure if only resetting vanilla does the trick.

I think in this case the customer updated from 2.73 to 4.x manually.

I didn't test :
on 3.X extend vanilla
update
reset extended vanilla : in my opinion this extended is out of date ?

I think in this case the customer updated from 2.73 to 4.x manually.

Manually? What do you mean? The upgrade script didn't run?

I am pretty sure the update script ran. Manually = Copy-over the 4.x files to the old installation, that should trigger the updater and force DB updates as well.

Very very strange...
And this happened on one installation ?
Or is it reproducible?

Dennis, you reproduced it? Sorry, not quite sure by what I read.

So far the customer updated one of their 3-4 systems, but more are about to follow. Maybe we can arrange a group chat with the customer when doing the upate so you can follow what is done and what the effect is. Will that help?

Hi Mazi,

I think the best is to take a snapshot of the DB after upgrade, and before hitting reset.
That will tell if the upgrade script 428 ran as expected.

Thanks!

Dennis, you reproduced it? Sorry, not quite sure by what I read.

No : i test on my working for a lot of time 4.X only.

And after check on cdemo where it's broken :)

Else : we are sure at 100% upgarde process happen else : DB is broken and all survey is broken.

OK, so, let's stick to the plan we aid with Mazi.
Right after another upgrade, take a snapshot and then see if the error happens again.

@gabrieljenik, a short update after I had a chat with the customer: This system was NOT updated but set up from scratch. Then they imported an old template and created a child theme.

OK, although the situation is unfortunate, I don't see much we can do here. Right?
ideas?

Waiting for updates. Nothing be done yet.

Since there is nothing to be done, I am closing this issue. Please feel free to open it again if the issue still exists.

noTablesOnMobile.css is not loaded in version 5.2.8.

@gabrieljenik, problem is back at 5.2.10+220118.

Damn

Can we review the steps for reproducing it?

Steps we did:
In LS3, made a theme extending vanilla.
Created a survey with that theme, holding an Array question.
Upgraded to master, and it works fine.

@gabrieljenik, see yesterday's team meeting chat at Discord.

Me and Tony and @galads could reproduce it with the latest 5.x version, using the vanilla theme and a simple array question.

We were able to reproduce it, but only on new installations, not for the ones upgraded from LS3.
Will submit a patch

https://github.com/LimeSurvey/LimeSurvey/pull/2226

This is for new installations.
Let us review about old installations, not LS3.

Added a DB update for v4 and v5 existing installations

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33340

Fixed in Release 5.3.5+220314