View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|17321||Bug reports||Survey taking||public||2021-05-22 14:16||2021-06-16 14:46|
|Summary||17321: Array question are not split up on mobile devices when using vanilla theme|
|Description||Array questions are split up into several single choice question on smaller mobile devices. This works fine for the fruity theme at LS 4.x but not when using the vanilla theme.|
Custom templates which inherit from vanilla show the same buggy behavior which makes it impossible to run surveys on mobile devices.
|Steps To Reproduce||Create an array question.|
Assign the vanilla theme.
Run the survey on a mobile device.
-> Question is not split up.
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||4.6.2|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||MySQL|
|Server OS (if known)|
|Webserver software & version (if known)|
|related to||08426||new||Feature requests||Unable to update an existing template by upload without update survey settings|
|related to||14605||acknowledged||Bug reports||Adding an option or a css file on an existing template didn't update survey|
|related to||12037||new||Feature requests||Better separation in feature in template-default package|
On 4.6.3 with firefox : mobile view : seems to work.
I check on a real phone browser (after update ùmy online test)
|@DenisChenu, I checked with Chrome using mobile simulation. Test link: https://demo.limesurvey.org/index.php?r=survey/index&sid=619922&newtest=Y&lang=en|
|Same with firefox on your link|
But not on : https://master.sondages.pro/619922?newtest=Y&lang=en
It's an update issue : reset vanilla theme : its'OK now.
3.X css : https://github.com/LimeSurvey/LimeSurvey/blob/7220965bf32581024d43a6328b4fa7c43bd6d21a/themes/survey/vanilla/config.xml#L49-L53
master CSS : https://github.com/LimeSurvey/LimeSurvey/blob/c3736063160f821c72ba87a1cea52abc804e9a24/themes/survey/vanilla/config.xml#L42-L47
Then : when you update from 3.X to 4.X : if you don't reset config : css/noTablesOnMobile.css is not loaded.
I attach to related issue now way to update onky , need to reset whole theme options on all survey to add one option or one css is a big big issue for all theme devlopper (and the reason why i'm at skelvanilla 9.X version)
It's one of the reason why i must remove css/noTablesOnMobile.css from 4.X version for sklelvanilla : it broke my system …
|So, not a bug...?|
|Still an issue : when update form 3.X to 4.X : all table are broken until reset **whole** theme option on **all** surveys …|
|How do you reset theme options, even? oO|
|Also, I'm not sure why there are so many related issues...?|
|You'r right : still related but there are a lack of "update without reset" option.|
I can confirm that resetting the vanilla theme and the custom theme fixed the problem.
Still, there needs to be a solution to prevent such manual edits when doing an update!
> Still, there needs to be a solution to prevent such manual edits when doing an update!
1. Set a specific logo fort one survey ( or one hundred, or one thousand)
2. Update to 4.X
3. Need to reset theme
4. All specific logo disappear …
|I asked Gabriel to have a look at it this week.|
Just to be clear and making sure we are on the same page, what do you call "resetting the theme"?
We couldn't reproduce the issue, although obviosuly you can :)
OK, may I ask you how you had your files_css option for one of your extended themes?
As to solve this, as you did, resetting vanilla would be OK, as it would pickup the definition from the manifest, which after the upgrade has the noTables css. Question would be, why did you had to reset the extended theme as well?
On upgrade db version 428, a new css is added to the vanilla and bootswatch theme: noTablesOnMobile.css.
That seems not to have run in your environment.
This I understand is the key to the problem.
image.png (109,288 bytes)
files_css at config.xml looks like this:
Obviously, the old Ajax files can be removed.
We resetted our own theme just in case. I wasn't sure if only resetting vanilla does the trick.
I think in this case the customer updated from 2.73 to 4.x manually.
I didn't test :
on 3.X extend vanilla
reset extended vanilla : in my opinion this extended is out of date ?
> I think in this case the customer updated from 2.73 to 4.x manually.
Manually? What do you mean? The upgrade script didn't run?
|I am pretty sure the update script ran. Manually = Copy-over the 4.x files to the old installation, that should trigger the updater and force DB updates as well.|
Very very strange...
And this happened on one installation ?
Or is it reproducible?
Dennis, you reproduced it? Sorry, not quite sure by what I read.
|So far the customer updated one of their 3-4 systems, but more are about to follow. Maybe we can arrange a group chat with the customer when doing the upate so you can follow what is done and what the effect is. Will that help?|
I think the best is to take a snapshot of the DB after upgrade, and before hitting reset.
That will tell if the upgrade script 428 ran as expected.
> Dennis, you reproduced it? Sorry, not quite sure by what I read.
No : i test on my working for a lot of time 4.X only.
And after check on cdemo where it's broken :)
Else : we are sure at 100% upgarde process happen else : DB is broken and all survey is broken.
OK, so, let's stick to the plan we aid with Mazi.
Right after another upgrade, take a snapshot and then see if the error happens again.
|@gabrieljenik, a short update after I had a chat with the customer: This system was NOT updated but set up from scratch. Then they imported an old template and created a child theme.|
OK, although the situation is unfortunate, I don't see much we can do here. Right?
|Waiting for updates. Nothing be done yet.|
|2021-05-22 14:16||Mazi||New Issue|
|2021-05-22 14:30||DenisChenu||Note Added: 64514|
|2021-05-22 14:30||DenisChenu||File Added: Capture d’écran_2021-05-22_14-29-57.png|
|2021-05-22 14:39||Mazi||Note Added: 64515|
|2021-05-22 18:18||DenisChenu||Note Added: 64516|
|2021-05-22 18:25||DenisChenu||Note Added: 64517|
|2021-05-22 18:26||DenisChenu||Relationship added||related to 08426|
|2021-05-22 18:27||DenisChenu||Relationship added||related to 14605|
|2021-05-22 18:32||DenisChenu||Relationship added||related to 12037|
|2021-05-23 22:38||ollehar||Priority||none => normal|
|2021-05-25 10:53||ollehar||Note Added: 64523|
|2021-05-25 11:38||DenisChenu||Note Added: 64524|
|2021-05-25 11:42||ollehar||Note Added: 64525|
|2021-05-25 11:43||ollehar||Note Added: 64526|
|2021-05-25 11:44||ollehar||Assigned To||=> gabrieljenik|
|2021-05-25 11:44||ollehar||Status||new => assigned|
|2021-05-25 11:50||DenisChenu||Note Added: 64527|
|2021-05-25 12:25||Mazi||Note Added: 64529|
|2021-05-25 12:28||DenisChenu||Note Added: 64530|
|2021-05-25 12:32||ollehar||Note Added: 64531|
|2021-05-27 01:22||gabrieljenik||Note Added: 64583|
|2021-05-27 08:14||DenisChenu||Note Added: 64585|
|2021-05-27 08:14||DenisChenu||File Added: Capture d’écran_2021-05-27_08-13-21.png|
|2021-05-27 16:16||gabrieljenik||Note Added: 64599|
|2021-05-27 16:16||gabrieljenik||File Added: image.png|
|2021-05-27 16:36||Mazi||Note Added: 64601|
|2021-05-27 16:45||DenisChenu||Note Added: 64602|
|2021-05-27 17:06||gabrieljenik||Note Added: 64603|
|2021-05-27 18:06||Mazi||Note Added: 64605|
|2021-05-27 18:49||gabrieljenik||Note Added: 64607|
|2021-05-28 09:01||Mazi||Note Added: 64612|
|2021-05-28 14:35||gabrieljenik||Note Added: 64636|
|2021-05-28 14:35||gabrieljenik||Status||assigned => feedback|
|2021-05-28 14:41||DenisChenu||Note Added: 64637|
|2021-05-28 15:43||gabrieljenik||Note Added: 64650|
|2021-05-30 18:30||Mazi||Note Added: 64659|
|2021-05-30 18:30||Mazi||Status||feedback => assigned|
|2021-05-31 14:22||gabrieljenik||Note Added: 64668|
|2021-05-31 14:22||gabrieljenik||Status||assigned => review|
|2021-06-16 14:46||gabrieljenik||Status||review => feedback|
|2021-06-16 14:46||gabrieljenik||Note Added: 64926|