 |
capture_2.png (27,378 bytes) |
 |
The custom_attributes got renamed to attributes. So if you replace it you should be able to see it properly, they will get merged with the ones from the base questiontype in this case "L" |
|
|
@p_teichmann, I did that after a fresh pull from git and don't see any change. Is this documented anywhere? Does it mean that we will need two versions of every custom question theme - one for 3.x and one for 4.x? capture_3.png (12,470 bytes) capture_4.png (9,170 bytes) |
|
|
I found the problem, i will fix the issue and get back to you. We will write the documentation for it as soon as possible. |
|
|
implemented in https://github.com/LimeSurvey/LimeSurvey/commit/99dfc5d0062c600efd2c98f0267a06488e12c319 |
|
|
I don't see this as fixed after a fresh pull today - version 4.0.0-RC14. I installed the attached question theme and, although the attributes now appear in the GUI, they don't work properly. The buttongroup attribute seems to be stored correctly but the button remains in the "No" position regardless of the stored value. The text attribute does not get stored at all and is not shown for multiple languages (i18n). Please see the attache question theme and test survey. |
 |
> The buttongroup attribute seems to be stored correctly but the button remains in the "No" position regardless of the stored value. Confirm : saved in DB, not reloaded in admin GUI And : seems not accessible in twig part (see another plugin again ;) `question_template_attribute.multiple-email` return 0 https://gitlab.com/SondagesPro/QuestionTheme/EmailInput/blob/master/survey/questions/answer/shortfreetext/text/item.twig#L17 |
|
|
@p_teichmann : i can test : what branch to be used for maximum of fixes ? https://github.com/LimeSurvey/LimeSurvey/commit/99dfc5d0062c600efd2c98f0267a06488e12c319 is already on develop And ```` $ git reset --hard origin/develop HEAD est maintenant à 00926bd1ef Fixed issue 15584: Error when adding list-radio answer with code "0" $ git pull Déjà à jour. ```` See screencast done with EmailInput plugin and lss Capture d’écran du 2020-01-15 10-00-10.png (9,672 bytes) |
|
|
sure you can do it if you want, normally we do it internally first :) https://github.com/LimeSurvey/LimeSurvey/tree/bug/15585-Custom-question-attributes-not-available |
|
|
For information : admin GUI seems OK now question_template_attribute.multiple-email still return 0. |
|
|
Its showing for the theme i am using from tpartner in twig its {{ question_template_attribute.custom_attribute_1 }} maybe you could give me a zip from your theme? |
|
|
Not with : https://gitlab.com/SondagesPro/QuestionTheme/EmailInput/blob/master/survey/questions/answer/shortfreetext/text/item.twig#L17 Available only in answer.twig ? If yes : i really think theme can not be really used in production … plugin is better … |
|
|
For the zip : https://bugs.limesurvey.org/file_download.php?file_id=12496&type=bug https://bugs.limesurvey.org/view.php?id=15585#c55249 |
|
|
Maybe the `-` in name are an issue ? https://gitlab.com/SondagesPro/QuestionTheme/EmailInput/blob/master/survey/questions/answer/shortfreetext/config.xml#L44 |
|
|
yes i just tested and replaced mine with - notation, this does indeed not work, allthough i tested with other Files and oyu are able to display them in there |
|
|
OK, i update the theme to use _ :) Must inform dev somewhere. If i reming core use _ ? No ? |
|
|
Thanks !! confirm : issue with `-` : https://gitlab.com/SondagesPro/QuestionTheme/EmailInput My 1st question theme ;) |
|
|
But the two themes that I attached work perfectly in 3.x (with dashes in the attribute names). So, they should work in 4.x. Correct? |
|
|
@tpartner both of the once you posted here have it with "_" like custom_attribute_1 @DenisChenu yeah i think they should be updated, you have an example where its wrong? |
|
|
> But the two themes that I attached work perfectly in 3.x (with dashes in the attribute names). So, they should work in 4.x. Correct? `-` is KO, `_` is OK. @p_teichmann : i don't have any question theme currently. Looking at core : seems they use all `_`. I think `-` can not be used with twig , like `.`. Maybe we need to throw error in this case ? But then it's another feature request. I don't see any manual page about questi_n theme for dev here : https://manual.limesurvey.org/Category:Development |
|
|
> @tpartner both of the once you posted here have it with "_" like custom_attribute_1 Sorry, my mistake. |
|
|
@DenisChenu yeah thats right, i couldnt find any wrongly named attributes in the core themes also the documentation is located at https://manualv4.limesurvey.org/Question_themes seems like the attributes work so far, i will then push it to develop |
|
|
Maybe time to send ALL attributes in a clean array https://bugs.limesurvey.org/view.php?id=14228#c54938 @p_teichmann : i need to make 3 feature request for 14228 ? 1. QuestionAttribute 2. Answers 3. SubQuestions ? |
|
|
QuestinAttribute feature is here : https://bugs.limesurvey.org/view.php?id=14449 |
|
|
i think one should suffice. |
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29402 |
|
|
pushed to https://github.com/LimeSurvey/LimeSurvey/commit/43300c524d90618db0b18d63a80ecd3a2cd84f4f |
|
|
@p_teichmann, the attribute values are now saved but there is no localization. I have an attribute that uses the <i18n> tag but in the GUI it is not rendered for all survey languages. Do you want me to open a new bug report? capture_3-2.png (11,037 bytes) capture_2-2.png (7,143 bytes) capture_4-2.png (8,529 bytes) |
 |
@tpartner, pls open a new bug report and assign it to me/tag me |
 |
Fixed in Release 4.0.1+200120 |
- Anonymous
