View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
15348 | Bug reports | Expression Manager | public | 2019-10-01 16:13 | 2019-10-08 10:32 |
Reporter | ollehar | Assigned To | ollehar | ||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 3.18.0 | ||||
Target Version | 3.18.x | ||||
Summary | 15348: Ranking question does not save answers when array filter and max columns are used | ||||
Description | Title. | ||||
Steps To Reproduce |
| ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | latest master | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | - | ||||
Database type & version | - | ||||
Server OS (if known) | - | ||||
Webserver software & version (if known) | - | ||||
PHP Version | - | ||||
related to | 09464 | closed | DenisChenu | Ranking question cannot go to next question if it's filtered by another question |
parent of | 15369 | closed | DenisChenu | Ranking with filter didn't save all value |
related to | 15368 | closed | DenisChenu | Filtered ranking didn't appear if in same page than the filter |
@DenisChenu Did you see this before? Old issue? |
|
I think it work on 2.6, didn't use a lot array filter in ranking. There are an old issue about array filter in ranking + mandatory |
|
@ollehar : checked with skelvanilla (no ajax mode) seems OK |
|
@DenisChenu Skelvanilla in 2.06? Or 2.73? |
|
3.18. Checked with vanilla in 3.18 (no ajax) : seems OK too [edit] 3.28 is not out … 3.18 is … |
|
3.18 (0e1849256f) + vanilla + ajax mode ON : can not reproduce |
|
Not able to reproduce under Version 3.18.0 and 3.17. |
|
Thanks for testing, jelo. I can't reproduce wither when starting from clean install. >< Have to check more. |
|
How to reproduce:
The combination of array filter in ranking + min/max and mandatory bugs out. |
|
4b : unlog , quit browser (etc …) => reset $_SESSION ? |
|
The database structure in answer table is different if the survey is activated with mandatory on or off for ranking question. Mandatory on: Nr of columns = max nr Don't know if that's causing the bug. |
|
Will try again with clean install. |
|
Max number of columns is set to 7 when import LSS But your lss have already 7 in max_numbers_columns … |
|
Yes, seems like the issue is resolved if you remove " Maximum columns for answers" before activating the survey. |
|
Indeed, mandatory does not matter. It's the "Maximum columns for answers" attribute that causes responses not to be recorded (probably in combination with array filter). |
|
@ollehar: Are you still using the LSS you attached here? Or did you change something and now testing with a different survey structure? |
|
@ollehar : and what it's the value of this number ? Did you have the 7 columns like me and the seven columns in DB ? |
|
I will update my latest test survey, one sec... |
|
New test survey:
|
|
Confirm … |
|
No, it's related to your 2015 fix where the ranking subquestions get marked as irrelevant. Will read it in detail. |
|
Stranhe, since it was here since 3 years … and working at this time … |
|
Arg … confirm it's broken too in 2.6lts … |
|
Maybe it broke when "Maximum columns for answers" was introduced? |
|
OK, thanks for testing! |
|
Maybe … but still totally unsure … Remind : the issue with Filter for answer : We must check only count here … maybe count(notFilteredQuestion) == 0 when control ? |
|
Will have to read the code more, don't understand right now. Another theory: _ProcessSubQRelevance returns wrong result for array filter ranking subquestions. |
|
Subquestion in ranking are _1, _2, _3 etc … Look at the question logic file … |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29173 |
|
Functional test added. |
|
Fixed now : right ? |
|
Fixed in Release 3.19.0+191008 |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2019-10-01 16:13 | ollehar | New Issue | |
2019-10-01 16:13 | ollehar | File Added: limesurvey_survey_157447_ranking_array_filter.lss | |
2019-10-01 16:13 | ollehar | Note Added: 53801 | |
2019-10-01 16:15 | ollehar | Assigned To | => ollehar |
2019-10-01 16:15 | ollehar | Status | new => assigned |
2019-10-01 16:23 | DenisChenu | Note Added: 53802 | |
2019-10-01 16:25 | DenisChenu | File Added: Capture d’écran du 2019-10-01 16-25-25.png | |
2019-10-01 16:25 | DenisChenu | Note Added: 53803 | |
2019-10-01 16:32 | ollehar | Note Added: 53804 | |
2019-10-01 16:33 | DenisChenu | Note Added: 53805 | |
2019-10-01 16:34 | DenisChenu | Note Edited: 53805 | |
2019-10-01 16:42 | DenisChenu | Note Added: 53806 | |
2019-10-01 16:55 | jelo | Note Added: 53807 | |
2019-10-01 17:10 | ollehar | Note Added: 53808 | |
2019-10-02 14:34 | ollehar | Note Added: 53825 | |
2019-10-02 14:41 | DenisChenu | Note Added: 53826 | |
2019-10-02 14:53 | ollehar | Note Added: 53829 | |
2019-10-02 14:53 | ollehar | Note Added: 53830 | |
2019-10-02 14:56 | DenisChenu | Note Added: 53832 | |
2019-10-02 15:03 | ollehar | Note Added: 53836 | |
2019-10-02 15:08 | ollehar | Note Added: 53838 | |
2019-10-02 15:12 | jelo | Note Added: 53839 | |
2019-10-02 15:18 | DenisChenu | Note Added: 53840 | |
2019-10-02 15:26 | ollehar | Note Added: 53842 | |
2019-10-02 15:38 | ollehar | File Added: limesurvey_survey_157447_array_filter_ranking_max_columns.lss | |
2019-10-02 15:38 | ollehar | Note Added: 53843 | |
2019-10-02 15:55 | DenisChenu | Note Added: 53844 | |
2019-10-02 16:21 | ollehar | Note Added: 53849 | |
2019-10-02 16:23 | ollehar | Relationship added | related to 09464 |
2019-10-02 16:35 | DenisChenu | Note Added: 53851 | |
2019-10-02 16:38 | DenisChenu | Note Added: 53852 | |
2019-10-02 16:38 | ollehar | Note Added: 53853 | |
2019-10-02 16:41 | ollehar | Note Added: 53854 | |
2019-10-02 16:48 | DenisChenu | Note Added: 53855 | |
2019-10-02 16:50 | ollehar | Note Added: 53856 | |
2019-10-02 17:02 | DenisChenu | File Added: RankingBroken.png | |
2019-10-02 17:02 | DenisChenu | File Added: RankingFixed.png | |
2019-10-02 17:02 | DenisChenu | Note Added: 53857 | |
2019-10-02 18:53 | ollehar | Summary | Ranking question does not save answers when array filter is used => Ranking question does not save answers when array filter and max columns are used |
2019-10-02 18:53 | ollehar | File Deleted: limesurvey_survey_157447_ranking_array_filter.lss | |
2019-10-04 16:31 | ollehar | Changeset attached | => LimeSurvey master c4309bd9 |
2019-10-04 16:31 | ollehar | Note Added: 53894 | |
2019-10-04 16:31 | ollehar | Resolution | open => fixed |
2019-10-04 17:36 | DenisChenu | Relationship added | parent of 15369 |
2019-10-06 10:56 | DenisChenu | Relationship added | related to 15368 |
2019-10-07 16:35 | ollehar | Note Added: 53927 | |
2019-10-07 18:27 | DenisChenu | Status | assigned => resolved |
2019-10-07 18:27 | DenisChenu | Note Added: 53932 | |
2019-10-08 10:32 | lime_release_bot | Note Added: 53938 | |
2019-10-08 10:32 | lime_release_bot | Status | resolved => closed |