View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
09906Bug reportsSurvey takingpublic2015-09-22 06:112019-05-10 23:01
Reporterduvemyster Assigned ToDenisChenu  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.06+ 
Fixed in Version2.06+ 
Summary09906: Invalid survey is set finished in response table with index complete
Description

Surveys without mandatory fields completed are marked completed on submit when Question Index / Allow Jumping is set to Full. This presents an issue when token-based response persistence is activated if the user leaves without completing the mandatory fields and submitting in that same session. If they leave, and then return later, their previously entered answers will no longer load for them.

Steps To Reproduce

Using the lsa file provided here:

  1. Follow the token link.
  2. Leave the mandatory field blank
  3. Enter something in the next field
  4. Click on Page 2 in the Index
  5. Submit
  6. OK
  7. Exit session
  8. Return again and follow the token link a second time.
  9. Note that the answer entered in step number 3 above doesn't load.
Additional Information

Note that survey records are being marked complete before they are actually complete this case. This is happening on submit at the same time as when the user is being told "You cannot proceed until you enter some text for one or more questions."

TagsNo tags attached.
Attached Files
survey_archive_412486.lsa (3,660 bytes)
survey_archive_index2token.lsa (3,797 bytes)
Bug heat6
Complete LimeSurvey version number (& build)150911
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome 45.0
Database type & versionMySQL 5.0.77
Server OS (if known)Linux (RedHat)
Webserver software & version (if known)Apache 2.2
PHP Version5.4.10

Relationships

Relationship GraphDependency Graph
related to 10243 closedc_schmitz Able to skip required questions when complete question index enable 
related to 14855 closedDenisChenu Allowed invalid completed survey + full index send false error about did not save 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2015-09-22 09:42

developer   ~33126

Actually : you can not submit a survey with "empty" mandatory question .. I do a fix in 2.05 .... Maybe "un-fixed" . Can you upload a little lss file ?
DenisChenu

DenisChenu

2015-09-22 10:18

developer   ~33129

OK : have it : set completed even if return to last page .... WTF.
DenisChenu

DenisChenu

2015-09-25 12:55

developer   ~33163

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=15960
DenisChenu

DenisChenu

2015-09-25 12:56

developer   ~33164

Upload a real lsa to test : 2 group/ 3 question inside.
It's better to upload the less little survey you can .
apmuthu

apmuthu

2015-09-25 21:34

reporter   ~33174

Where in v2.05 did you do a complete fix (08806?)?
Is this necessary in last release of v2.05?
Should instances of
$thissurvey['questionindex']==2
be
$thissurvey['questionindex']>=2
in the current fix at https://github.com/LimeSurvey/LimeSurvey/commit/d9d30622405dadb6d1d1340a1bf1e5f9ef5e511c ?
apmuthu

apmuthu

2015-09-28 04:03

reporter   ~33181

Fixed in v2.051 as well:
https://github.com/apmuthu/LimeSurvey/commit/c9717e1432c851c0925f1755c3b07c9e663b570a
c_schmitz

c_schmitz

2015-09-30 11:01

administrator   ~33218

Version 2.06+ Build 150930 released

Related Changesets

LimeSurvey: master d9d30622

2015-09-25 10:54:49

DenisChenu

Details Diff 		Fixed issue 09906: Invalid survey is set finished in response table with index complete
Dev: the first move set 'completed' to reponse table, then even if coma back : response tabke is set 'completed' and token 'uncompleted'
Dev: SurveyRuntimeHelper become more an more complicated ....
Dev: a good reason to add event to move 'index' to plugin ..... no ?		 Affected Issues
09906
mod - application/helpers/SurveyRuntimeHelper.php Diff File

Issue History

Date Modified Username Field Change
2015-09-22 06:11 duvemyster New Issue
2015-09-22 06:11 duvemyster File Added: survey_archive_412486.lsa
2015-09-22 09:42 DenisChenu Note Added: 33126
2015-09-22 10:17 DenisChenu Status new => confirmed
2015-09-22 10:18 DenisChenu Note Added: 33129
2015-09-25 12:41 DenisChenu Assigned To => DenisChenu
2015-09-25 12:41 DenisChenu Status confirmed => assigned
2015-09-25 12:52 DenisChenu Summary Persistent tokens lose persistency when index jumping bypasses a mandatory field and the survery is submitted => Invalid survey is set finished in response table with index complete
2015-09-25 12:55 DenisChenu Changeset attached => LimeSurvey master d9d30622
2015-09-25 12:55 DenisChenu Note Added: 33163
2015-09-25 12:55 DenisChenu Resolution open => fixed
2015-09-25 12:55 DenisChenu Status assigned => resolved
2015-09-25 12:55 DenisChenu Fixed in Version => 2.06+
2015-09-25 12:56 DenisChenu File Added: survey_archive_index2token.lsa
2015-09-25 12:56 DenisChenu Note Added: 33164
2015-09-25 21:34 apmuthu Note Added: 33174
2015-09-28 04:03 apmuthu Note Added: 33181
2015-09-30 11:01 c_schmitz Note Added: 33218
2015-09-30 11:01 c_schmitz Status resolved => closed
2016-01-25 08:21 DenisChenu Relationship added related to 10243
2019-05-10 23:01 DenisChenu Relationship added related to 14855