View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 4
IDProjectCategoryView StatusDate SubmittedLast Update
09111Feature requestsSurvey takingpublic2014-06-23 12:582015-08-21 15:51
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynormalSeverityfeature 
Status closedResolutionfixed 
Fixed in Version2.05+ 
Summary09111: Better url (shortest)
Description

In 1.92 and 2.00 : at the survey list we have url like this:
example.org/XXX if we set config with good value.
In 2.05 : the url use $_GET param

Additional Information

Fix here : https://github.com/LimeSurvey/LimeSurvey/pull/205

I do some test, it's OK.
I test without updating routes.php BUT : the new routes go after <_controller:\w+>/<_action:\w+> : then this one is applied before
<sid:\d+>/*

TagsNo tags attached.
Bug heat4
Story point estimate
Users affected %

Relationships

Relationship GraphDependency Graph
parent of 08239 ready for testinggabrieljenik Allow for user friendly survey URLS 
Not all the children of this issue are yet resolved or closed.

Users monitoring this issue

mfaber

Activities

DenisChenu

DenisChenu

2014-06-23 13:00

developer   ~30206

Add the child 08239 because we need to fix this one before have shortest url with text (and find how to manage this).
DenisChenu

DenisChenu

2014-06-27 08:52

developer   ~30235

Just use Yii system. Can be updated via config (but need existing parameters for url, because $route['<_controller:\w+>/<_action:\w+>'] = '<_controller>/<_action>'; is readed before config.php
Maybe add this one in internal at last ?

Related Changesets

LimeSurvey: master bdfad82d

2014-06-23 12:13

DenisChenu


Details Diff		 New feature : use shortest url with urlFormat path
Dev: this replace array('survey/index', 'sid' => $survey->sid, 'lang' => App()->lang->langcode) by /$sid/lang/language
Dev: same behaviour than 2.0 or 1.92 with modrewrite=1
Dev: maybe some other default rules to add : actually surveyurl + statistics_ur + optout url (maybe partially)
Dev: need more testing ? urlFormat get not changed		 Affected Issues
09111
mod - application/config/routes.php Diff File

LimeSurvey: master 9cf14b36

2014-06-23 13:37

DenisChenu


Details Diff		 Dev: fix createUrl("/survey/index,array('sid'=>'some_string')
Dev: 'matchValue'=>true do the trick		 Affected Issues
09111
mod - application/config/routes.php Diff File

LimeSurvey: master 2ed19efe

2014-06-23 13:47

DenisChenu


Details Diff		 Dev: leave other parameters for $_GET
Dev: createUrl("/survey/index",array('sid'=>1234,'lang'=>'en','newtest'=>'Y')) do /1234.html?lang=en&newtest=Y		 Affected Issues
09111
mod - application/config/routes.php Diff File

LimeSurvey: master 72e0dcfd

2014-06-27 08:48

DenisChenu


Details Diff		 Merge pull request #205 from Shnoulle/master_routes

Dev: Don't take lang, because unexiting lang make a new false page		 Affected Issues
09111
mod - application/config/routes.php Diff File

Issue History

Date Modified Username Field Change
2014-06-23 12:58 DenisChenu New Issue
2014-06-23 12:59 DenisChenu Relationship added child of 08239
2014-06-23 12:59 DenisChenu Relationship deleted child of 08239
2014-06-23 12:59 DenisChenu Relationship added parent of 08239
2014-06-23 13:00 DenisChenu Note Added: 30206
2014-06-23 22:29 mfaber Issue Monitored: mfaber
2014-06-27 08:49 DenisChenu Assigned To => DenisChenu
2014-06-27 08:49 DenisChenu Status new => assigned
2014-06-27 08:49 DenisChenu Changeset attached => LimeSurvey master bdfad82d
2014-06-27 08:50 DenisChenu Changeset attached => LimeSurvey master 72e0dcfd
2014-06-27 08:50 DenisChenu Changeset attached => LimeSurvey master 2ed19efe
2014-06-27 08:50 DenisChenu Changeset attached => LimeSurvey master 9cf14b36
2014-06-27 08:52 DenisChenu Note Added: 30235
2014-06-27 08:52 DenisChenu Status assigned => resolved
2014-06-27 08:52 DenisChenu Fixed in Version => 2.05+
2014-06-27 08:52 DenisChenu Resolution open => fixed
2015-08-21 15:51 c_schmitz Status resolved => closed