View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 6
IDProjectCategoryView StatusDate SubmittedLast Update
08973Bug reportsCentral participant databasepublic2014-04-16 13:592014-05-25 22:00
Reporterc_schmitz Assigned Totpartner  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Target Version2.05+ 
Summary08973: Editing attributes not properly working
Description

When editing attribute values of a participant in the CPDB main view, then when using a double click to start inline editing the icons are not coming up properly, also a message shows 'You don't have permissions to edit this' while I clearly have.
While when using the edit icon to start editing this works like a charm.

It looks that for some reason the double-click to propagated to the main grid from where the denial message comes.

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)140414
I will donate to the project if issue is resolvedNo
BrowserLatest FF
Database type & versionirrelevant
Server OS (if known)irrelevant
Webserver software & version (if known)irrelevant
PHP Versionirrelevant

Relationships

Relationship GraphDependency Graph
related to 08798 closedc_schmitz Editing a dropdown attribute value deletes everything but the first word 

Users monitoring this issue

duvemyster

Activities

tpartner

tpartner

2014-04-23 15:44

partner   ~29870

Okay, so these problems were introduced at commit - https://github.com/LimeSurvey/LimeSurvey/commit/afd51003c15edbe7ac24fc74acafb8440d27da66

Regarding the dialog:

In participantdisplay.js at lines 140 and 719, $('#displayparticipants').getCell(id, 'can_edit') is not returning true because the "can_edit" cell doesn't exist in the sub-grid row. It actually lives in the parent row of the main grid.

Do we even need to be accessing this variable, or can we just go with your new "bEditPermission" var?

Regarding the editable inputs not appearing:

You commented out line 756. Was there a reason for this?
c_schmitz

c_schmitz

2014-04-25 11:49

administrator   ~29889

But doesn't

$('#displayparticipants')

not refer to the main grid? And the column does exist there.

I am not sure about line 756, think that was committed in error.
tpartner

tpartner

2014-04-25 12:01

partner   ~29891

Yes, but the "id" var refers to the row that was double-clicked and in that row there is no "can_edit". I'll look into a fix later today or tomorrow.
tpartner

tpartner

2014-05-05 13:18

partner   ~29956

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=14203
tpartner

tpartner

2014-05-05 13:47

partner   ~29957

Fixed in 2.05

Related Changesets

LimeSurvey: master 53163473

2014-05-05 13:18

tpartner


Details Diff		 Fixed issue 08973: Editing attributes not properly working
Dev Prevent unwanted double-click event on subgrids		 Affected Issues
08973
mod - scripts/admin/participantdisplay.js Diff File

Issue History

Date Modified Username Field Change
2014-04-16 13:59 c_schmitz New Issue
2014-04-16 13:59 c_schmitz Status new => assigned
2014-04-16 13:59 c_schmitz Assigned To => tpartner
2014-04-16 14:00 c_schmitz Relationship added related to 08798
2014-04-23 15:44 tpartner Assigned To tpartner => c_schmitz
2014-04-23 15:44 tpartner Note Added: 29870
2014-04-25 11:49 c_schmitz Assigned To c_schmitz => tpartner
2014-04-25 11:49 c_schmitz Note Added: 29889
2014-04-25 11:49 c_schmitz Status assigned => feedback
2014-04-25 12:01 tpartner Note Added: 29891
2014-04-30 21:24 duvemyster Issue Monitored: duvemyster
2014-05-05 13:18 tpartner Changeset attached => LimeSurvey master 53163473
2014-05-05 13:18 tpartner Note Added: 29956
2014-05-05 13:18 tpartner Resolution open => fixed
2014-05-05 13:47 tpartner Note Added: 29957
2014-05-05 13:47 tpartner Status feedback => resolved
2014-05-25 22:00 c_schmitz Status resolved => closed
2021-08-02 23:08 guest Bug heat 4 => 6