View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08798Bug reportsCentral participant databasepublic2014-09-10 12:10
Reporterrom Assigned Toc_schmitz  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Summary08798: Editing a dropdown attribute value deletes everything but the first word
Description

When editing a value of a dropdown attribute in CPD which already contained multiple words & spaces, everything except the first word is deleted once I press the edit button

Steps To Reproduce

-add dropdown attribute do CPD
-add a value to the dropdown which contains spaces, e.g. "this is a value"
-save
-edit dropdown
-edit dropdown value again
-everything in this value is deleted except the first word "this"

TagsNo tags attached.
Attached Files
multiple_edits.jpg (33,468 bytes)   
multiple_edits.jpg (33,468 bytes)   
Bug heat6
Complete LimeSurvey version number (& build)Master Branch
I will donate to the project if issue is resolvedNo
BrowserChrome
Database type & versionMYSQL
Server OS (if known)Linux
Webserver software & version (if known)APACHE
PHP Version5.3.x

Relationships

related to 08973 closedtpartner Editing attributes not properly working 

Users monitoring this issue

rom

Activities

c_schmitz

c_schmitz

2014-03-03 11:53

administrator   ~29075

I suspect it is a JS bug - if not please assign it back to me.

tpartner

tpartner

2014-03-03 15:38

partner   ~29078

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13968

tpartner

tpartner

2014-03-03 15:45

partner   ~29079

Last edited: 2014-03-03 15:46

Carsten, I have cleaned up the JS so the full text is loaded into the input for editing.

I've also added a "Cancel" button while editing and cleaned up some styles.

A problem remains that is not really JS related - it is possible to edit more than one row at a time but if you do and submit the form, only the last attribute is saved.

Can you fix this in the form action or do we need to limit to only editing one row at a time? If the later, what behavior should we use? An alert? Disable the other "Edit" icons while a row is being edited?

c_schmitz

c_schmitz

2014-03-18 09:11

administrator   ~29321

Tony, I can edit only one attribute at a time here and it looks fine to me this way.
One minor issue: It is possible to finish editing by pressing ENTER - the value is saved but the Cancel/Save icon remains.
Can you have another look please?

tpartner

tpartner

2014-09-05 13:13

partner   ~30478

Carsten, I cannot reproduce your problem. Can you please provide a screenshot?

Additionally, I can still edit several values at once but only changes to the last will be saved. For example, in my screenshot (multiple_edits.jpg), although I have edited 3 values, only changes to "Option 444" will be saved.

c_schmitz

c_schmitz

2014-09-09 15:40

administrator   ~30516

I think I was looking in the wrong place. I can reproduce your behaviour now - I will have a look if the save action can do it easily.

c_schmitz

c_schmitz

2014-09-10 12:10

administrator   ~30520

The usability of that screen is horrible. I will leave it as it is right now but will create a new task for development to revamp that page.

Related Changesets

LimeSurvey: master 66368b9a

2014-03-03 14:37:54

tpartner

Details Diff
Fixed issue 08798: Editing a dropdown attribute value deletes everything but the first word
Dev: Clean up JavaScript and styles for editing attributes
Affected Issues
08798
mod - application/views/admin/participants/viewAttribute_view.php Diff File
mod - scripts/admin/viewAttribute.js Diff File
add - styles/blobblueish/images/cancel_16.png Diff File
mod - styles/blobblueish/viewAttribute.css Diff File
add - styles/darkblue/images/cancel_16.png Diff File
mod - styles/darkblue/viewAttribute.css Diff File
add - styles/gringegreen/images/cancel_16.png Diff File
mod - styles/gringegreen/viewAttribute.css Diff File

Issue History

Date Modified Username Field Change
2014-03-03 11:30 rom New Issue
2014-03-03 11:30 rom Issue Monitored: rom
2014-03-03 11:47 c_schmitz Assigned To => tpartner
2014-03-03 11:47 c_schmitz Status new => assigned
2014-03-03 11:53 c_schmitz Note Added: 29075
2014-03-03 15:38 tpartner Changeset attached => LimeSurvey master 66368b9a
2014-03-03 15:38 tpartner Note Added: 29078
2014-03-03 15:38 tpartner Resolution open => fixed
2014-03-03 15:45 tpartner Assigned To tpartner =>
2014-03-03 15:45 tpartner Assigned To => c_schmitz
2014-03-03 15:45 tpartner Note Added: 29079
2014-03-03 15:46 tpartner Note Edited: 29079
2014-03-18 09:11 c_schmitz Assigned To c_schmitz => tpartner
2014-03-18 09:11 c_schmitz Note Added: 29321
2014-04-16 14:00 c_schmitz Relationship added related to 08973
2014-09-05 13:12 tpartner File Added: multiple_edits.jpg
2014-09-05 13:13 tpartner Assigned To tpartner => c_schmitz
2014-09-05 13:13 tpartner Note Added: 30478
2014-09-09 15:40 c_schmitz Note Added: 30516
2014-09-10 12:10 c_schmitz Note Added: 30520
2014-09-10 12:10 c_schmitz Status assigned => closed
2021-08-02 23:08 guest Bug heat 4 => 6