This make a lot of change in EM : core and manager

Not in 2.05, but more for 2.06

And allow access to other information too (get from DB, and not from session :help is the first example).

For questions with subquestion this may actually qualify as a bug (missing implementation)....
Should not be that much work. Implementation probably in _GetVarAttribute() in em_manager_helper.
I can take it (the .question-thing) but will likely not get to it before april.

Carsten, please advise:

This is our status:

For questions without subquestions (eg. single answer)
QCODE.question [gives question text]

For questions with subquestions (eg. matrix)
QCODE_SQCODE.question [gives SUBquestion text]
No access to the main question text at the moment.
--> QCODE.question [gives error]

Problem is that only subquestions are in the fieldmap and other data structures, so for a matrix question, QCODE without a subquestion code is (for EM) not a valid variable. And i am reluctant to change that only because we would like to access "QCODE.question".

What can be very easily implemented is an additional question attribute (let's call it ".questiontext"?). So the main questiontext of a matrix question could be accessed with QCODE_ANYSQCODE.questiontext. Question is: Would that be ok/helpful? Or rather leave it as it is?

Tom, do you have any advice for us how to best deal with this?

Hi,

Like mafaber say, 2 siolution:

• Leave EM KnowVars system (in fieldmap) + Add a new function to call 'anything'
• Add all Question part in knowvar

Very difficult to choose, because after choosing, it can be more easy or more difficult to add a new system (question-help is one example, but our user have surely a lot of idea).

Carsten: feel free to assign this back to me if you think a ".questiontext" attribute would be helpful (see http://bugs.limesurvey.org/view.php?id=8858#c29532)

If I can add that this is a problem for me. When creating a "Review page" subquestion answers without the main question context can be meaningless. In the survey I am currently working on I need to display an image which is embedded within the question text to give the answer some relevance.

I can work around it but its a lot more complex than one would hope.

Why not a new event (or 2 news events)

• Extend ExpressionManager->knowVars here : https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/expressions/em_manager_helper.php#L4272
• Extend CoreReplacement before here : https://github.com/LimeSurvey/LimeSurvey/blob/develop/application/helpers/replacements_helper.php#L594

About EM : the danger is whole system goes in $_SESSION , then it already make a big SESSION part .....
About CoreReplacement : maybe there are better solution with twig : @LouisGac : do you think it can be more easy and clean with twig system ? In the twig replacement system ?

I can see how this might be very difficult.

As it is I am using javascript to recreate the original question which means the images need to be named in such a way that the correct image can be determined from the selected answer. It works OK and if I am honest its probably the lazy way to be able to reference the original question.

You also have the problem of if a question itself references a previous question and then you reference the dependent question, will the expression manager handle it correctly. As I do not know how the expression manager works (its magic isn't it) I do not know how complex this problem may be.

OK,

Done by plugins : https://github.com/LimeSurvey/LimeSurvey/pull/1256/commits/ee28e01723bc0928e68cd10502e0f445111dbabe

If you activate expressionQuestionHelp you have Q00.help too \o/

@DenisChenu, I know you prefer adding functionality as plugins but isn't this some core feature to be able to properly get the question text by an EM placeholder?

@c_schmitz, what do you think? My suggestion would be adding this fix to the core code. Alternatively, add it as an activated core plugin.
Thing is that if this fix is available as a plugin the user has to install, nearly no one will make use of it.

@Mazi : here one fix for 3 plugins (in core, distributed with core).
And this pull request allow more an more situation fix …

Thing is that if this fix is available as a plugin the user has to install, nearly no one will make use of it.
False : it's in distribution, just activate.

And more : Expression Manager SESSION is already big. Some user already have issue with big session, the this QCODE.question MUST be optional because it fill again the SESSION …
The usage of QCODE.question is exceptional. Current user use Condition editor + Placehoder field in HTML editor. They rarely use current .question.

I really think core must not add always something in SESSION (+ in PHP memory and time) if it's rarely used …
In fact : i think .question can be a plugin by himself (like expressionQuestionHelp )

https://github.com/LimeSurvey/LimeSurvey/commit/011890d128084176074421cbe82cdd342706f729#diff-bccf0f511c5328f1ef2c78b92305646a