View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
08829Bug reportsExpression Managerpublic2014-03-17 13:14
Reportermfaber Assigned Tomfaber  
PrioritynormalSeverityminor 
Status closedResolutionfixed 
Product Version2.05+ 
Fixed in Version2.05+ 
Summary08829: Questions with incorrect relevance equations are not shown
Description

Questions with relevance equations containing errors (eg. misspelled var name) are not shown (are treated as not relevant).
I think a better behaviour would be show these questions. Just because it's better to ask a pontially irrelevant question than to omit a pontially important one in a survey. It's also much harder to detect a missing question while testing a survey than to spot one that does not belong there.

Sample lss with two questions attached.

Steps To Reproduce

Create a survey w/ a question with an incorrect rel. equation.
Test the survey-->question is not shown.

TagsNo tags attached.
Attached Files
relevance_errors.lss (12,882 bytes)
Bug heat6
Complete LimeSurvey version number (& build)20140307
I will donate to the project if issue is resolvedNo
BrowserFF
Database type & versionMySql 5.6.14
Server OS (if known)Win7
Webserver software & version (if known)Apache 2.4.7
PHP VersionPhP 5.4.19

Relationships

related to 07703 closedmfaber Feature requests When an exclusive option in a multiple choice question is malformatted, the answers aren´t saved at all. 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2014-03-08 12:18

developer   ~29143

I think this is very difficult : because it's in EM. But find a way can be great.

I atached too : 07048: No need to show error at respondant

But think this one (and other ) are more Feature request or dev :)

mfaber

mfaber

2014-03-08 13:00

reporter   ~29144

Technically no problem. If the Team is OK with it i can do it. Maybe a PR?

DenisChenu

DenisChenu

2014-03-08 13:11

developer   ~29145

You mean it's easy to set relevance to true if error in EM ?

mfaber

mfaber

2014-03-08 13:25

reporter   ~29146

Yes

DenisChenu

DenisChenu

2014-03-08 13:41

developer   ~29147

Put a +1 on feature request ;)

mfaber

mfaber

2014-03-08 14:01

reporter   ~29148

Noted :)

mfaber

mfaber

2014-03-08 15:32

reporter   ~29149

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13984

mfaber

mfaber

2014-03-08 15:38

reporter   ~29150

Denis: for http://bugs.limesurvey.org/view.php?id=7703 it is more difficult (SQ relevance). I am working on implementing SQ relevance and will probably solve this in the process.

http://bugs.limesurvey.org/view.php?id=7048 is EM but not stricly relevance. Probably needs solving somewhere else.

DenisChenu

DenisChenu

2014-03-08 18:36

developer   ~29151

for 07703 , i think the if() (javascript broken) is already fixed. Please test : if not i fix it.

But : need to fix too the PHP, i assign it to you if needed.

OK ?

And for #07048 : this one is not relevance, you're rigth , just need to set somewhere bIsAdmin in EM, after it's more easy. I take it for 2.06

mfaber

mfaber

2014-03-08 23:34

reporter   ~29152

I'm afraid the js syntax error is still there. Problem is the empty $LEM->subQrelInfo['qid']['relevancejs'].

6973: $relParts[] = " if ( " . $sq['relevancejs'] . " ) {\n";
in em_manager_helper.php.

Can you have a look?

With the PHP part I'm already done but need to test without the js error :)

mfaber

mfaber

2014-03-09 01:30

reporter   ~29153

to be continued in 07703

DenisChenu

DenisChenu

2014-03-09 11:43

developer   ~29155

I take a look and test whole tomorrow morning.

Thanks to you \o/

c_schmitz

c_schmitz

2014-03-17 13:14

administrator   ~29274

2.05+ Build 140317 released

Related Changesets

LimeSurvey: master 233c5ec6

2014-03-08 14:23:24

mfaber


Committer: mfaber Details Diff
Fixed issue 08829: Questions with errors in relevance equations are hidden

Dev: Set questions to "relevant" if there's an error in the rel equation
Affected Issues
08829
mod - application/helpers/expressions/em_manager_helper.php Diff File

Issue History

Date Modified Username Field Change
2014-03-08 00:02 mfaber New Issue
2014-03-08 00:03 mfaber File Added: relevance_errors.lss
2014-03-08 12:18 DenisChenu Note Added: 29143
2014-03-08 13:00 mfaber Note Added: 29144
2014-03-08 13:11 DenisChenu Note Added: 29145
2014-03-08 13:25 mfaber Note Added: 29146
2014-03-08 13:41 DenisChenu Note Added: 29147
2014-03-08 14:01 mfaber Note Added: 29148
2014-03-08 15:32 mfaber Changeset attached => LimeSurvey master 233c5ec6
2014-03-08 15:32 mfaber Note Added: 29149
2014-03-08 15:32 mfaber Assigned To => mfaber
2014-03-08 15:32 mfaber Resolution open => fixed
2014-03-08 15:38 mfaber Note Added: 29150
2014-03-08 15:38 mfaber Severity partial_block => minor
2014-03-08 15:38 mfaber Reproducibility have not tried => always
2014-03-08 15:38 mfaber Status new => resolved
2014-03-08 15:38 mfaber Fixed in Version => 2.05+
2014-03-08 18:36 DenisChenu Note Added: 29151
2014-03-08 23:34 mfaber Note Added: 29152
2014-03-08 23:36 mfaber Relationship added related to 07703
2014-03-09 01:30 mfaber Note Added: 29153
2014-03-09 11:43 DenisChenu Note Added: 29155
2014-03-17 13:14 c_schmitz Note Added: 29274
2014-03-17 13:14 c_schmitz Status resolved => closed