View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
07703Feature requestsSurvey editingpublic2014-05-03 21:31
Reportermysterywolff Assigned Tomfaber  
PrioritylowSeverityfeature 
Status closedResolutionfixed 
Summary07703: When an exclusive option in a multiple choice question is malformatted, the answers aren´t saved at all.
Description

When an excluive option in a multiple choice question is not amongst the answer codes of that question, one of the following things happen:
A) Matrix filter type is set to hidden: Question is shown but no answer options. Question can be skiped and no answers are captured.
b) Matric filter type is set to deactivated: Question and answer possibilities are shown, question can be answered but the answers are not saved.

Steps To Reproduce

When using the uploaded surved remove the exclusiv answer. The question is shown with both matrix filter types. If an exclusive option like "33" is inserted the problem occurs like stated above.

Additional Information

Answer codes might change in the process of a survey design, might differ when a survey gets copied or maybe when an update takes place. Maybe a warning that the exclusive option does not match an answer code used would help.

TagsNo tags attached.
Attached Files
Bug heat8
Story point estimate
Users affected %

Relationships

related to 08829 closedmfaber Bug reports Questions with incorrect relevance equations are not shown 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2013-03-25 14:07

developer   ~24854

Think it's an "Feature request", not a bug.

Expresssion MAnager is designed like that actually : do an error : break survey.

mysterywolff

mysterywolff

2013-03-25 17:37

reporter   ~24859

Well the warning is an suggestion, indeed, but it´s not intended to just show a question and not save what was answered, is it? =)

Mazi

Mazi

2013-04-29 23:02

updater   ~25168

NOT saving answers without any warning is always a bad idea.

I know that it is very complex to check something like that when designing the survey, so maybe the survey logic file could be used for that?

DenisChenu

DenisChenu

2013-04-30 08:37

developer   ~25172

Mazi : it's allways a problem with javascript only (like old ranking):
If js breaked then answer are not saved.

But here: think a solution can be find :

  • First : The problem is if( ) in js: broken: think i have a solution
  • Second: i have to try without js why it's broken.
mfaber

mfaber

2014-03-09 01:35

reporter   ~29154

Denis: This should fix it. OK to commit? (without the traceVars of course ;)

https://github.com/mfaber/LimeSurvey/commit/dbb652930c0aa2b37d68402e06b21cb42a77655f

mfaber

mfaber

2014-03-12 17:56

reporter   ~29210

Hey Denis,
do you still want to have a look? Otherwise I'll just do the commit.
My fix does not implement a warning but changes behaviour so values are saved if a relevance equation contains errors (so relevance with errors is regarded as "true" and not as "afalse").

DenisChenu

DenisChenu

2014-03-12 18:07

developer   ~29211

Hi, sorry no time today .... Go on :)

mfaber

mfaber

2014-03-12 21:17

reporter   ~29214

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=13993

Related Changesets

LimeSurvey: master 959a6600

2014-03-09 00:31:45

mfaber


Committer: mfaber Details Diff
Fixed issue 07703: results not saved when rel eq contains errors Affected Issues
07703
mod - application/helpers/expressions/em_manager_helper.php Diff File

Issue History

Date Modified Username Field Change
2013-03-25 12:06 mysterywolff New Issue
2013-03-25 12:06 mysterywolff File Added: limesurvey_survey_834429.lss
2013-03-25 13:27 c_schmitz Assigned To => DenisChenu
2013-03-25 13:27 c_schmitz Status new => assigned
2013-03-25 14:07 DenisChenu Note Added: 24854
2013-03-25 14:08 DenisChenu Project Bug reports => Development
2013-03-25 14:09 DenisChenu Project Development => Feature requests
2013-03-25 17:37 mysterywolff Note Added: 24859
2013-04-29 22:57 c_schmitz Severity @50@ => feature
2013-04-29 22:57 c_schmitz Product Version 2.00+ =>
2013-04-29 23:02 Mazi Note Added: 25168
2013-04-30 08:37 DenisChenu Note Added: 25172
2014-03-08 23:36 mfaber Relationship added related to 08829
2014-03-09 01:35 mfaber Note Added: 29154
2014-03-09 11:42 DenisChenu Assigned To DenisChenu => mfaber
2014-03-12 17:56 mfaber Note Added: 29210
2014-03-12 18:07 DenisChenu Note Added: 29211
2014-03-12 21:17 mfaber Changeset attached => LimeSurvey master 959a6600
2014-03-12 21:17 mfaber Note Added: 29214
2014-03-12 21:17 mfaber Resolution open => fixed
2014-03-12 21:17 mfaber Status assigned => resolved
2014-03-12 21:17 mfaber Fixed in Version => 2.05+
2014-05-03 21:31 c_schmitz Status resolved => closed
2019-11-01 17:25 c_schmitz Category Survey design => Survey editing