View Issue Details

Related ChangesetsJump to NotesJump to History
This bug affects 1 person(s).
 8
IDProjectCategoryView StatusDate SubmittedLast Update
19746Bug reportsSurvey takingpublic2024-09-12 15:322024-10-09 14:07
Reportertibor.pacalat Assigned Totibor.pacalat  
PrioritynoneSeverityminor 
Status resolvedResolutionfixed 
Product Version6.6.x 
Summary19746: Auto correction of invalid input in Multiple numeric input type question could be improved
Description

While I was testing https://bugs.limesurvey.org/view.php?id=19677, I noticed that if I input "23,ertz" it corrects it to "23,".
In my opinion it should correct it to "23" without the comma. Or, if we want to preserve the comma as part of comma/dot notation, then it should be converted into "23,0" or "23.0" depending on the region.

Steps To Reproduce

Steps to reproduce

(Replace this text with detailed step-by-step instructions on how to reproduce the issue)

Expected result

(Write here what you expected to happen)

Actual result

(Write here what happened instead)

TagsNo tags attached.
Bug heat8
Complete LimeSurvey version number (& build)6.6.3+240909
I will donate to the project if issue is resolvedNo
Browser
Database type & version.
Server OS (if known)
Webserver software & version (if known)
PHP Version.

Users monitoring this issue

There are no users monitoring this issue.

Activities

gabrieljenik

gabrieljenik

2024-09-27 22:44

manager   ~81125

https://github.com/LimeSurvey/LimeSurvey/pull/3982

Not sure why that snippet was there in the first place.
We need to test it against many variations to make sure we don't introduce a regression.
DenisChenu

DenisChenu

2024-10-03 17:50

developer   ~81159

We need to test it against many variations to make sure we don't introduce a regression.

Listing potential test ?
guest

guest

2024-10-09 14:06

viewer   ~81195

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36585
tibor.pacalat

tibor.pacalat

2024-10-09 14:07

administrator   ~81196

Tested and merged.

Related Changesets

LimeSurvey: master 4ad32959

2024-10-09 14:06:43

Gabriel Jenik


Committer: GitHub Details Diff 		Fixed issue 19746: Auto correction of invalid input in Multiple numeric input type question could be improved (03982)

Co-authored-by: lapiudevgit <devgit@lapiu.biz>		 Affected Issues
19746
mod - assets/packages/expressions/em_javascript.js Diff File

Issue History

Date Modified Username Field Change
2024-09-12 15:32 tibor.pacalat New Issue
2024-09-12 15:32 tibor.pacalat Assigned To => gabrieljenik
2024-09-12 15:32 tibor.pacalat Status new => assigned
2024-09-27 22:44 gabrieljenik Assigned To gabrieljenik => DenisChenu
2024-09-27 22:44 gabrieljenik Status assigned => ready for code review
2024-09-27 22:44 gabrieljenik Note Added: 81125
2024-09-27 22:44 gabrieljenik Bug heat 0 => 2
2024-10-03 17:50 DenisChenu Note Added: 81159
2024-10-03 17:50 DenisChenu Bug heat 2 => 4
2024-10-03 17:50 DenisChenu Assigned To DenisChenu => tibor.pacalat
2024-10-03 17:50 DenisChenu Status ready for code review => ready for testing
2024-10-09 14:06 Changeset attached => LimeSurvey master 4ad32959
2024-10-09 14:06 guest Note Added: 81195
2024-10-09 14:06 guest Bug heat 4 => 6
2024-10-09 14:07 tibor.pacalat Status ready for testing => resolved
2024-10-09 14:07 tibor.pacalat Resolution open => fixed
2024-10-09 14:07 tibor.pacalat Note Added: 81196
2024-10-09 14:07 tibor.pacalat Bug heat 6 => 8