19746: Auto correction of invalid input in Multiple numeric input type question could be improved

This bug affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

19746	Bug reports	Survey taking	public	2024-09-12 15:32	2024-10-28 17:41

Reporter	tibor.pacalat	Assigned To	tibor.pacalat
Priority	none	Severity	minor
Status	closed	Resolution	fixed
Product Version	6.6.x

Summary	19746: Auto correction of invalid input in Multiple numeric input type question could be improved
Description	While I was testing https://bugs.limesurvey.org/view.php?id=19677, I noticed that if I input "23,ertz" it corrects it to "23,". In my opinion it should correct it to "23" without the comma. Or, if we want to preserve the comma as part of comma/dot notation, then it should be converted into "23,0" or "23.0" depending on the region.
Steps To Reproduce	Steps to reproduce (Replace this text with detailed step-by-step instructions on how to reproduce the issue) Expected result (Write here what you expected to happen) Actual result (Write here what happened instead)
Tags	No tags attached.

Bug heat	10
Complete LimeSurvey version number (& build)	6.6.3+240909
I will donate to the project if issue is resolved	No
Browser
Database type & version	.
Server OS (if known)
Webserver software & version (if known)
PHP Version	.

User List	There are no users monitoring this issue.

gabrieljenik 2024-09-27 22:44 manager ~81125	https://github.com/LimeSurvey/LimeSurvey/pull/3982 Not sure why that snippet was there in the first place. We need to test it against many variations to make sure we don't introduce a regression.

DenisChenu 2024-10-03 17:50 developer ~81159	We need to test it against many variations to make sure we don't introduce a regression. Listing potential test ?

guest 2024-10-09 14:06 viewer ~81195	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=36585

tibor.pacalat 2024-10-09 14:07 administrator ~81196	Tested and merged.

LimeBot 2024-10-28 17:41 administrator ~81303	Fixed in Release 6.6.7+241028

LimeSurvey: master 4ad32959 2024-10-09 16:06 Gabriel Jenik Committer: GitHub Details Diff	Fixed issue 19746: Auto correction of invalid input in Multiple numeric input type question could be improved (03982) Co-authored-by: lapiudevgit <devgit@lapiu.biz>		Affected Issues 19746
	mod - assets/packages/expressions/em_javascript.js		Diff File

Date Modified	Username	Field	Change
2024-09-12 15:32	tibor.pacalat	New Issue
2024-09-12 15:32	tibor.pacalat	Assigned To	=> gabrieljenik
2024-09-12 15:32	tibor.pacalat	Status	new => assigned
2024-09-27 22:44	gabrieljenik	Assigned To	gabrieljenik => DenisChenu
2024-09-27 22:44	gabrieljenik	Status	assigned => ready for code review
2024-09-27 22:44	gabrieljenik	Note Added: 81125
2024-09-27 22:44	gabrieljenik	Bug heat	0 => 2
2024-10-03 17:50	DenisChenu	Note Added: 81159
2024-10-03 17:50	DenisChenu	Bug heat	2 => 4
2024-10-03 17:50	DenisChenu	Assigned To	DenisChenu => tibor.pacalat
2024-10-03 17:50	DenisChenu	Status	ready for code review => ready for testing
2024-10-09 14:06		Changeset attached	=> LimeSurvey master 4ad32959
2024-10-09 14:06	guest	Note Added: 81195
2024-10-09 14:06	guest	Bug heat	4 => 6
2024-10-09 14:07	tibor.pacalat	Status	ready for testing => resolved
2024-10-09 14:07	tibor.pacalat	Resolution	open => fixed
2024-10-09 14:07	tibor.pacalat	Note Added: 81196
2024-10-09 14:07	tibor.pacalat	Bug heat	6 => 8
2024-10-28 17:41	LimeBot	Note Added: 81303
2024-10-28 17:41	LimeBot	Status	resolved => closed
2024-10-28 17:41	LimeBot	Bug heat	8 => 10