|
|
I confirmed that the behaviour is different.
In LS5 (first screenshot) user lands on last valid date.
In LS6 (second and third screenshot, fruity23 theme) user lands on todays date and then if the user knows how to use this date picker - everything is fine.
But, this is not the best UX, plus there are too many unnecessary clicks involved. |
|
|
|
Thank you. The technical behavious is indeed OK, but many users will get confused. In my opinion, this is a regression. |
|
|
|
This is clearly a regression :) |
|
|
|
https://github.com/LimeSurvey/LimeSurvey/pull/3912 |
|
|
|
Expression don't seems to be covered here
Maybe just to deactivate (strtotime($minDate) === false) for start.
I think there are a system in 3X for expression to update it when open the date dialog, maybe need to be reported (again, and again ;) ) |
|
|
|
Expression don't seems to be covered here
What do you mean? Got lost. |
|
|
|
You can set
- {date(strtotime("+1 week"))}
- {date(strtotime("today"))}
- {date(AnotherQDate)}
etc …
it seems not covered her.
previously (3.X) :
- Put it in view
- Use it when shown https://github.com/SondagesPro/LimeSurvey-SondagesPro/blob/18bac625f52375f33dff8376e4254e9dff6781bd/assets/scripts/date.js#L7
|
|
|
|
What about now? |
|
|
|
You rock ;) |
|
|
|
I cannot test now, but I believe Denis just did.... :-) |
|
|
|
No, i review, i didn't test when reviewing |
|
|
|
@gabrieljenik I tested this, but I have found something that should still be fixed if possible.
When I have restricted question like in the attached survey and activate date widget, I get to the end of the restricted time span, which is good. But, I can't go to previous month (which is still valid) via left arrow. I also see that the left arrow has disabled styling.
After I click on the month name and select previous month, I can use the arrow as I expected in the first place. |
|
|
|
I tested this, but I have found something that should still be fixed if possible
Is this a bug introduced by this fix?
If not, I would open a new ticket. It will be easier to manage, review, handle, discuss ... |
|
|
|
Well, on master, without your fix I can move back and forth with the arrows at all times, so I would say it was introduced by this fix. |
|
|
|
For information : totally working survey on 3.X
limesurvey_survey_DateMinMaxTest.lss (15,614 bytes)
<?xml version="1.0" encoding="UTF-8"?>
<document>
<LimeSurveyDocType>Survey</LimeSurveyDocType>
<DBVersion>366</DBVersion>
<languages>
<language>en</language>
</languages>
<groups>
<fields>
<fieldname>gid</fieldname>
<fieldname>sid</fieldname>
<fieldname>group_name</fieldname>
<fieldname>group_order</fieldname>
<fieldname>description</fieldname>
<fieldname>language</fieldname>
<fieldname>randomization_group</fieldname>
<fieldname>grelevance</fieldname>
</fields>
<rows>
<row>
<gid><![CDATA[143]]></gid>
<sid><![CDATA[731186]]></sid>
<group_name><![CDATA[My first question group]]></group_name>
<group_order><![CDATA[1]]></group_order>
<description/>
<language><![CDATA[en]]></language>
<randomization_group/>
<grelevance><![CDATA[1]]></grelevance>
</row>
</rows>
</groups>
<questions>
<fields>
<fieldname>qid</fieldname>
<fieldname>parent_qid</fieldname>
<fieldname>sid</fieldname>
<fieldname>gid</fieldname>
<fieldname>type</fieldname>
<fieldname>title</fieldname>
<fieldname>question</fieldname>
<fieldname>preg</fieldname>
<fieldname>help</fieldname>
<fieldname>other</fieldname>
<fieldname>mandatory</fieldname>
<fieldname>question_order</fieldname>
<fieldname>language</fieldname>
<fieldname>scale_id</fieldname>
<fieldname>same_default</fieldname>
<fieldname>relevance</fieldname>
<fieldname>modulename</fieldname>
</fields>
<rows>
<row>
<qid><![CDATA[1712]]></qid>
<parent_qid><![CDATA[0]]></parent_qid>
<sid><![CDATA[731186]]></sid>
<gid><![CDATA[143]]></gid>
<type><![CDATA[D]]></type>
<title><![CDATA[DateMin]]></title>
<question><![CDATA[Minimal date]]></question>
<preg/>
<help/>
<other><![CDATA[N]]></other>
<mandatory><![CDATA[N]]></mandatory>
<question_order><![CDATA[1]]></question_order>
<language><![CDATA[en]]></language>
<scale_id><![CDATA[0]]></scale_id>
<same_default><![CDATA[0]]></same_default>
<relevance><![CDATA[1]]></relevance>
<modulename/>
</row>
<row>
<qid><![CDATA[1713]]></qid>
<parent_qid><![CDATA[0]]></parent_qid>
<sid><![CDATA[731186]]></sid>
<gid><![CDATA[143]]></gid>
<type><![CDATA[D]]></type>
<title><![CDATA[DateMax]]></title>
<question><![CDATA[Maximal date]]></question>
<preg/>
<help/>
<other><![CDATA[N]]></other>
<mandatory><![CDATA[N]]></mandatory>
<question_order><![CDATA[2]]></question_order>
<language><![CDATA[en]]></language>
<scale_id><![CDATA[0]]></scale_id>
<same_default><![CDATA[0]]></same_default>
<relevance><![CDATA[!is_empty(DateMin.NAOK)]]></relevance>
<modulename/>
</row>
<row>
<qid><![CDATA[1714]]></qid>
<parent_qid><![CDATA[0]]></parent_qid>
<sid><![CDATA[731186]]></sid>
<gid><![CDATA[143]]></gid>
<type><![CDATA[D]]></type>
<title><![CDATA[Date]]></title>
<question><![CDATA[Final date]]></question>
<preg/>
<help/>
<other><![CDATA[N]]></other>
<mandatory><![CDATA[N]]></mandatory>
<question_order><![CDATA[3]]></question_order>
<language><![CDATA[en]]></language>
<scale_id><![CDATA[0]]></scale_id>
<same_default><![CDATA[0]]></same_default>
<relevance><![CDATA[!is_empty(DateMin.NAOK) && !is_empty(DateMax.NAOK)]]></relevance>
<modulename/>
</row>
</rows>
</questions>
<question_attributes>
<fields>
<fieldname>qid</fieldname>
<fieldname>attribute</fieldname>
<fieldname>value</fieldname>
<fieldname>language</fieldname>
</fields>
<rows>
<row>
<qid><![CDATA[1713]]></qid>
<attribute><![CDATA[date_min]]></attribute>
<value><![CDATA[DateMin.NAOK]]></value>
</row>
<row>
<qid><![CDATA[1714]]></qid>
<attribute><![CDATA[date_max]]></attribute>
<value><![CDATA[DateMax.NAOK]]></value>
</row>
<row>
<qid><![CDATA[1714]]></qid>
<attribute><![CDATA[date_min]]></attribute>
<value><![CDATA[DateMin.NAOK]]></value>
</row>
</rows>
</question_attributes>
<surveys>
<fields>
<fieldname>sid</fieldname>
<fieldname>gsid</fieldname>
<fieldname>admin</fieldname>
<fieldname>expires</fieldname>
<fieldname>startdate</fieldname>
<fieldname>adminemail</fieldname>
<fieldname>anonymized</fieldname>
<fieldname>faxto</fieldname>
<fieldname>format</fieldname>
<fieldname>savetimings</fieldname>
<fieldname>template</fieldname>
<fieldname>language</fieldname>
<fieldname>additional_languages</fieldname>
<fieldname>datestamp</fieldname>
<fieldname>usecookie</fieldname>
<fieldname>allowregister</fieldname>
<fieldname>allowsave</fieldname>
<fieldname>autonumber_start</fieldname>
<fieldname>autoredirect</fieldname>
<fieldname>allowprev</fieldname>
<fieldname>printanswers</fieldname>
<fieldname>ipaddr</fieldname>
<fieldname>refurl</fieldname>
<fieldname>showsurveypolicynotice</fieldname>
<fieldname>publicstatistics</fieldname>
<fieldname>publicgraphs</fieldname>
<fieldname>listpublic</fieldname>
<fieldname>htmlemail</fieldname>
<fieldname>sendconfirmation</fieldname>
<fieldname>tokenanswerspersistence</fieldname>
<fieldname>assessments</fieldname>
<fieldname>usecaptcha</fieldname>
<fieldname>usetokens</fieldname>
<fieldname>bounce_email</fieldname>
<fieldname>attributedescriptions</fieldname>
<fieldname>emailresponseto</fieldname>
<fieldname>emailnotificationto</fieldname>
<fieldname>tokenlength</fieldname>
<fieldname>showxquestions</fieldname>
<fieldname>showgroupinfo</fieldname>
<fieldname>shownoanswer</fieldname>
<fieldname>showqnumcode</fieldname>
<fieldname>bouncetime</fieldname>
<fieldname>bounceprocessing</fieldname>
<fieldname>bounceaccounttype</fieldname>
<fieldname>bounceaccounthost</fieldname>
<fieldname>bounceaccountpass</fieldname>
<fieldname>bounceaccountencryption</fieldname>
<fieldname>bounceaccountuser</fieldname>
<fieldname>showwelcome</fieldname>
<fieldname>showprogress</fieldname>
<fieldname>questionindex</fieldname>
<fieldname>navigationdelay</fieldname>
<fieldname>nokeyboard</fieldname>
<fieldname>alloweditaftercompletion</fieldname>
<fieldname>googleanalyticsstyle</fieldname>
<fieldname>googleanalyticsapikey</fieldname>
</fields>
<rows>
<row>
<sid><![CDATA[731186]]></sid>
<gsid><![CDATA[1]]></gsid>
<admin><![CDATA[Denis Chenu]]></admin>
<adminemail><![CDATA[denis@sondages.pro]]></adminemail>
<anonymized><![CDATA[N]]></anonymized>
<faxto/>
<format><![CDATA[G]]></format>
<savetimings><![CDATA[N]]></savetimings>
<template><![CDATA[vanilla]]></template>
<language><![CDATA[en]]></language>
<additional_languages/>
<datestamp><![CDATA[N]]></datestamp>
<usecookie><![CDATA[N]]></usecookie>
<allowregister><![CDATA[N]]></allowregister>
<allowsave><![CDATA[Y]]></allowsave>
<autonumber_start><![CDATA[0]]></autonumber_start>
<autoredirect><![CDATA[N]]></autoredirect>
<allowprev><![CDATA[N]]></allowprev>
<printanswers><![CDATA[N]]></printanswers>
<ipaddr><![CDATA[N]]></ipaddr>
<refurl><![CDATA[N]]></refurl>
<showsurveypolicynotice><![CDATA[0]]></showsurveypolicynotice>
<publicstatistics><![CDATA[N]]></publicstatistics>
<publicgraphs><![CDATA[N]]></publicgraphs>
<listpublic><![CDATA[N]]></listpublic>
<htmlemail><![CDATA[Y]]></htmlemail>
<sendconfirmation><![CDATA[Y]]></sendconfirmation>
<tokenanswerspersistence><![CDATA[N]]></tokenanswerspersistence>
<assessments><![CDATA[N]]></assessments>
<usecaptcha><![CDATA[N]]></usecaptcha>
<usetokens><![CDATA[N]]></usetokens>
<bounce_email><![CDATA[denis@sondages.pro]]></bounce_email>
<emailresponseto/>
<emailnotificationto/>
<tokenlength><![CDATA[15]]></tokenlength>
<showxquestions><![CDATA[Y]]></showxquestions>
<showgroupinfo><![CDATA[B]]></showgroupinfo>
<shownoanswer><![CDATA[N]]></shownoanswer>
<showqnumcode><![CDATA[X]]></showqnumcode>
<bounceprocessing><![CDATA[N]]></bounceprocessing>
<showwelcome><![CDATA[Y]]></showwelcome>
<showprogress><![CDATA[Y]]></showprogress>
<questionindex><![CDATA[0]]></questionindex>
<navigationdelay><![CDATA[0]]></navigationdelay>
<nokeyboard><![CDATA[N]]></nokeyboard>
<alloweditaftercompletion><![CDATA[N]]></alloweditaftercompletion>
</row>
</rows>
</surveys>
<surveys_languagesettings>
<fields>
<fieldname>surveyls_survey_id</fieldname>
<fieldname>surveyls_language</fieldname>
<fieldname>surveyls_title</fieldname>
<fieldname>surveyls_description</fieldname>
<fieldname>surveyls_welcometext</fieldname>
<fieldname>surveyls_endtext</fieldname>
<fieldname>surveyls_policy_notice</fieldname>
<fieldname>surveyls_policy_error</fieldname>
<fieldname>surveyls_policy_notice_label</fieldname>
<fieldname>surveyls_url</fieldname>
<fieldname>surveyls_urldescription</fieldname>
<fieldname>surveyls_email_invite_subj</fieldname>
<fieldname>surveyls_email_invite</fieldname>
<fieldname>surveyls_email_remind_subj</fieldname>
<fieldname>surveyls_email_remind</fieldname>
<fieldname>surveyls_email_register_subj</fieldname>
<fieldname>surveyls_email_register</fieldname>
<fieldname>surveyls_email_confirm_subj</fieldname>
<fieldname>surveyls_email_confirm</fieldname>
<fieldname>surveyls_dateformat</fieldname>
<fieldname>surveyls_attributecaptions</fieldname>
<fieldname>email_admin_notification_subj</fieldname>
<fieldname>email_admin_notification</fieldname>
<fieldname>email_admin_responses_subj</fieldname>
<fieldname>email_admin_responses</fieldname>
<fieldname>surveyls_numberformat</fieldname>
<fieldname>attachments</fieldname>
</fields>
<rows>
<row>
<surveyls_survey_id><![CDATA[731186]]></surveyls_survey_id>
<surveyls_language><![CDATA[en]]></surveyls_language>
<surveyls_title><![CDATA[Dat min - max]]></surveyls_title>
<surveyls_description/>
<surveyls_welcometext/>
<surveyls_endtext/>
<surveyls_url/>
<surveyls_urldescription/>
<surveyls_email_invite_subj><![CDATA[Invitation to participate in a survey]]></surveyls_email_invite_subj>
<surveyls_email_invite><![CDATA[Dear {FIRSTNAME},<br />
<br />
You have been invited to participate in a survey.<br />
<br />
The survey is titled:<br />
"{SURVEYNAME}"<br />
<br />
"{SURVEYDESCRIPTION}"<br />
<br />
To participate, please click on the link below.<br />
<br />
Sincerely,<br />
<br />
{ADMINNAME} ({ADMINEMAIL})<br />
<br />
----------------------------------------------<br />
Click here to do the survey:<br />
{SURVEYURL}<br />
<br />
If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br />
{OPTOUTURL}<br />
<br />
If you are blacklisted but want to participate in this survey and want to receive invitations please click the following link:<br />
{OPTINURL}]]></surveyls_email_invite>
<surveyls_email_remind_subj><![CDATA[Reminder to participate in a survey]]></surveyls_email_remind_subj>
<surveyls_email_remind><![CDATA[Dear {FIRSTNAME},<br />
<br />
Recently we invited you to participate in a survey.<br />
<br />
We note that you have not yet completed the survey, and wish to remind you that the survey is still available should you wish to take part.<br />
<br />
The survey is titled:<br />
"{SURVEYNAME}"<br />
<br />
"{SURVEYDESCRIPTION}"<br />
<br />
To participate, please click on the link below.<br />
<br />
Sincerely,<br />
<br />
{ADMINNAME} ({ADMINEMAIL})<br />
<br />
----------------------------------------------<br />
Click here to do the survey:<br />
{SURVEYURL}<br />
<br />
If you do not want to participate in this survey and don't want to receive any more invitations please click the following link:<br />
{OPTOUTURL}]]></surveyls_email_remind>
<surveyls_email_register_subj><![CDATA[Survey registration confirmation]]></surveyls_email_register_subj>
<surveyls_email_register><![CDATA[Dear {FIRSTNAME},<br />
<br />
You, or someone using your email address, have registered to participate in an online survey titled {SURVEYNAME}.<br />
<br />
To complete this survey, click on the following URL:<br />
<br />
{SURVEYURL}<br />
<br />
If you have any questions about this survey, or if you did not register to participate and believe this email is in error, please contact {ADMINNAME} at {ADMINEMAIL}.]]></surveyls_email_register>
<surveyls_email_confirm_subj><![CDATA[Confirmation of your participation in our survey]]></surveyls_email_confirm_subj>
<surveyls_email_confirm><![CDATA[Dear {FIRSTNAME},<br />
<br />
This email is to confirm that you have completed the survey titled {SURVEYNAME} and your response has been saved. Thank you for participating.<br />
<br />
If you have any further questions about this email, please contact {ADMINNAME} on {ADMINEMAIL}.<br />
<br />
Sincerely,<br />
<br />
{ADMINNAME}]]></surveyls_email_confirm>
<surveyls_dateformat><![CDATA[1]]></surveyls_dateformat>
<email_admin_notification_subj><![CDATA[Response submission for survey {SURVEYNAME}]]></email_admin_notification_subj>
<email_admin_notification><![CDATA[Hello,<br />
<br />
A new response was submitted for your survey '{SURVEYNAME}'.<br />
<br />
Click the following link to see the individual response:<br />
{VIEWRESPONSEURL}<br />
<br />
Click the following link to edit the individual response:<br />
{EDITRESPONSEURL}<br />
<br />
View statistics by clicking here:<br />
{STATISTICSURL}]]></email_admin_notification>
<email_admin_responses_subj><![CDATA[Response submission for survey {SURVEYNAME} with results]]></email_admin_responses_subj>
<email_admin_responses><![CDATA[Hello,<br />
<br />
A new response was submitted for your survey '{SURVEYNAME}'.<br />
<br />
Click the following link to see the individual response:<br />
{VIEWRESPONSEURL}<br />
<br />
Click the following link to edit the individual response:<br />
{EDITRESPONSEURL}<br />
<br />
View statistics by clicking here:<br />
{STATISTICSURL}<br />
<br />
<br />
The following answers were given by the participant:<br />
{ANSWERTABLE}]]></email_admin_responses>
<surveyls_numberformat><![CDATA[0]]></surveyls_numberformat>
</row>
</rows>
</surveys_languagesettings>
<themes>
<theme>
<sid>731186</sid>
<template_name>edg_2021</template_name>
<config>
<options>inherit</options>
</config>
</theme>
<theme>
<sid>731186</sid>
<template_name>vanilla</template_name>
<config>
<options>inherit</options>
</config>
</theme>
</themes>
<themes_inherited>
<theme>
<sid>731186</sid>
<template_name>edg_2021</template_name>
<config>
<options>
<ajaxmode>on</ajaxmode>
<animatebody>off</animatebody>
<hideprivacyinfo>off</hideprivacyinfo>
<container>on</container>
<bodyanimation>fadeInRight</bodyanimation>
<brandlogo>on</brandlogo>
<brandlogofile>./files/logo.png</brandlogofile>
<font>noto</font>
<showpopups>1</showpopups>
<fixnumauto>off</fixnumauto>
</options>
</config>
</theme>
<theme>
<sid>731186</sid>
<template_name>vanilla</template_name>
<config>
<options>
<ajaxmode>off</ajaxmode>
<brandlogo>on</brandlogo>
<container>on</container>
<hideprivacyinfo>off</hideprivacyinfo>
<brandlogofile>./files/logo.png</brandlogofile>
<font>noto</font>
</options>
</config>
</theme>
</themes_inherited>
</document>
|
|
|
|
I have the arrwo issue too, maybe related to popper ?
We are at v2.11.5
https://www.npmjs.com/package/@popperjs/core |
|
|
|
A broken survey (working on 3.X)
Throw a JS error
Uncaught Error: TD: Could not correctly parse "{SYMSTART.NAOK}" to a date for restrictions.minDate.
Forum post : https://forums.limesurvey.org/forum/design-issues/156183-minimum-data-blocks-conditions-v6 |
|
|
|
Else :
Is this a bug introduced by this fix?
Not really since no action can be done with current master : previous and next icon are disabled too … like WHOLE calendar. |
|
|
|
Updated the datepicker component.
Upgraded tempusdominus to 6.2.10.
Can't upgrade to 6.9.9 because in 6.4.1 something, related to the date format, gets broken |
|
|
|
Seems to fix the issue (with limesurvey_survey_DateMinMaxTest.lss test survey)
Good job !
Can't upgrade to 6.9.9 because in 6.4.1 something, related to the date format, gets broken
There are an issue on github ? https://github.com/Eonasdan/tempus-dominus/issues |
|
|
|
Now the issue with arrows has been resolved, but I have issues with css of the date picker ... (look at the screenshot). The theme is fruity23 |
|
|
|
OK with Vanilla. |
|
|
|
@DenisChenu not for me :( I have a dark theme on my chrome, but this is not the issue. |
|
|
|
We come from 6.0.0-beta7, and in beta9 they added the “theme” option, which by default is “auto”:
Theme option · Issue #2522 · Eonasdan/tempus-dominus
https://github.com/Eonasdan/tempus-dominus/issues/2522
Display Options
https://getdatepicker.com/6/options/display.html#theme
“Specifies which theme to use, light mode or dark mode. When set to auto, it will auto detect based on settings of the user's system.”
I don't know what would be the best way to handle it in Lime…
Looking at the pictures attacjed, maybe just set it as light mode by default? |
|
|
|
The issue was in LimeSurvey theme : please don't force light mode !
Else, if we construct an adaptive theme using OS settings : https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/#aa-dark-mode-at-the-operating-system-level oit don't work.
Must come from LimeSurvey css template.
PS : i think we must include https://github.com/Eonasdan/tempus-dominus/blob/master/src/scss/tempus-dominus.scss in LimeSurey theme.
Maybe have a solution to get it by theme if exist ? |
|
|
|
Maybe we can have the Dominus to pick the theme mode from a function (if exists).
Then the theme can define the function and customize the theme mode.
Thoughts?
In the future we can include other customization settings on the theme, but so far, this could be a quick workaround |
|
|
|
My opinion : @tibor.pacalat want a dark mode : the issue was : LimeSurvey core theme don't offer dark mode. New calendar theme are great.
We have issue too with boostwatch dark theme.
There are no solution to set default option like this https://gitlab.com/SondagesPro/SurveyThemes/skelvanilla/-/blob/master/views/subviews/header/head.twig?ref_type=heads#L25
Else : theme : (typeof LSvar.themeoption.mode !== 'undefined') ? LSvar.themeoption.mode : 'auto' ? |
|
|
|
Thoughts?
If body bg color is white : white mode, else dark mode ;) |
|
|
|
theme : (typeof LSvar.themeoption.mode !== 'undefined') ? LSvar.themeoption.mode : 'auto' ?
This is OK
Another possibility is to use a data attribute on the body tag.
data-thememode='dark'
I think this last one is a bit more accesible for non JS people.
Thoughts? |
|
|
|
Another possibility is to use a data attribute on the body tag.
I think this last one is a bit more accesible for non JS people.
Yes !!! Really better !
:+1: |
|
|
|
@gabrieljenik any updates on this? |
|
|
|
This ready to be reviewwed again. |
|
|
|
Hmm, I am still seeing black background with fruity23. |
|
|
|
Sorry, check now.
It was done for vanilla and the ones which extended it.
Fruity2023 wasn't extending Vanilla.
The theme has been updated now. |
|
|
|
Good job ! |
|
