View Issue Details

This bug affects 1 person(s).
 8
IDProjectCategoryView StatusLast Update
19166Bug reportsMenu systempublic2023-11-30 13:44
Reportermferraz Assigned To 
PrioritynoneSeverityblock 
Status newResolutionopen 
Product Version6.2.x 
Summary19166: After the last upgrade, users with the permissions to manage users lost the user management options on the Action menu
Description

After the last upgrade, users with the permissions to manage users lost the user management options on the Action menu

Steps To Reproduce

Steps to reproduce

Set the permissions needed for user management

Expected result

Users are able to set permissions to other users.

Actual result

Users can't set the roles or permissions to other users

TagsNo tags attached.
Attached Files
Bug heat8
Complete LimeSurvey version number (& build)6.2.11+231007
I will donate to the project if issue is resolvedYes
Browser
Database type & versionPostgreSQL 13+225
Server OS (if known)
Webserver software & version (if known)
PHP Version8.1

Relationships

related to 19127 new User with Create user permission can not create user 
related to 18968 closedtibor.pacalat User with "View/read Users" permission needs to have "User details" action available for all users, not just itself 

Users monitoring this issue

There are no users monitoring this issue.

Activities

tibor.pacalat

tibor.pacalat

2023-10-11 13:00

administrator   ~77620

Last edited: 2023-10-11 13:01

I don't see any difference between 6.2.10 and 6.2.11.
Superadmin can edit all users, admins can edit only users that they created.
Look at the image, admin can edit user that it created (screenshot is same for 6.2.10 and 6.2.11).

mferraz

mferraz

2023-10-11 13:13

reporter   ~77621

That didn't happen in the last versions; users with full permissions to edit users could also edit permissions for users that were created by other users.
All users here are automatically created after the user successfully logs in on a federated auth, so, we have "power users" that can manage user permissions.

tibor.pacalat

tibor.pacalat

2023-10-11 14:03

administrator   ~77622

We made a lot of security fixes in the last few weeks, so there are more restrictions now.

@DenisChenu @gabrieljenik please correct me here if this was not a wanted change.

gabrieljenik

gabrieljenik

2023-10-11 14:32

manager   ~77623

I would say we need to identify which ticket created this behaviour change and then evealute from there.

DenisChenu

DenisChenu

2023-10-12 09:28

developer   ~77647

There are different test for User permission , before any new update we must make clean decision and write it clearly on wiki or somewhere else

See this issue for example : 19127: User with Create user permission can not create user https://bugs.limesurvey.org/view.php?id=19127

That didn't happen in the last versions; users with full permissions to edit users could also edit permissions for users that were created by other users.

I think he can make update via Quick Menu but not via simple menu ?

@tibor.pacalat : the issue here are about updating system. If you can confirm user need both : update + owner to edit another user in 3 and 1st 5.X version : we can delete update permission at 1st step (and set it at 0 when update) and add it after where user have ALL user update Permisuison.

About commit : https://github.com/LimeSurvey/LimeSurvey/commit/a2eece7853698b6145828cbbe40e10e0fdd36cb4 related issue : https://bugs.limesurvey.org/view.php?id=18355

DenisChenu

DenisChenu

2023-10-12 09:35

developer   ~77648

3.X version : user need to be owner to update other user's

Then : new feature allow user to update other user

This need 2 step

  1. removing current update/delete permission : owner have ALL permission on user created by himself : fix 19127. When update : DB update set all update/create user permission to 0
  2. Adding again update/delete permission : allowing superadmin to create USer manager without access to Survey (for example)
DenisChenu

DenisChenu

2023-10-12 11:13

developer   ~77653

Then there are a really big issue in 1st versions of 6.X

In 5.X : user can not edit other user's
update 6.X : same user can edit other user's …

tibor.pacalat

tibor.pacalat

2023-10-12 13:40

administrator   ~77659

We'll have a meeting next week about permission system in general, so we can decide there, what and how it needs to be changed exactly.

mferraz

mferraz

2023-11-30 13:44

reporter   ~78826

Hi, is there any development on this?

Issue History

Date Modified Username Field Change
2023-10-11 12:32 mferraz New Issue
2023-10-11 12:32 mferraz File Added: Screenshot-20231011110954-454x744.png
2023-10-11 12:32 mferraz File Added: Screenshot-20231011110813-1135x831.png
2023-10-11 12:32 mferraz File Added: Screenshot-20231011110626-247x324.png
2023-10-11 13:00 tibor.pacalat Note Added: 77620
2023-10-11 13:00 tibor.pacalat File Added: Screenshot 2023-10-11 at 12.59.23.png
2023-10-11 13:00 tibor.pacalat Bug heat 0 => 2
2023-10-11 13:01 tibor.pacalat Note Edited: 77620
2023-10-11 13:13 mferraz Note Added: 77621
2023-10-11 13:13 mferraz Bug heat 2 => 4
2023-10-11 14:03 tibor.pacalat Note Added: 77622
2023-10-11 14:32 gabrieljenik Note Added: 77623
2023-10-11 14:32 gabrieljenik Bug heat 4 => 6
2023-10-12 09:28 DenisChenu Note Added: 77647
2023-10-12 09:28 DenisChenu Bug heat 6 => 8
2023-10-12 09:35 DenisChenu Note Added: 77648
2023-10-12 09:35 DenisChenu File Added: Capture d’écran du 2023-10-12 09-31-47.png
2023-10-12 09:35 DenisChenu File Added: Capture d’écran du 2023-10-12 09-31-57.png
2023-10-12 11:11 DenisChenu Relationship added related to 18968
2023-10-12 11:12 DenisChenu Relationship added related to 19127
2023-10-12 11:13 DenisChenu Note Added: 77653
2023-10-12 13:40 tibor.pacalat Note Added: 77659
2023-11-30 13:44 mferraz Note Added: 78826