|
|
Master: https://github.com/LimeSurvey/LimeSurvey/pull/3475 |
|
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35524 |
|
|
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35525 |
|
|
|
Fixed in Release 6.2.9+230925 |
|
|
|
v5: https://github.com/LimeSurvey/LimeSurvey/pull/3528 |
|
|
|
Really related to all User permission …
Code is OK, but logic still broken |
|
|
|
@gabrieljenik when I try to look at the details of superadmin I get 500
http://ls-ce-5x/index.php/userManagement/viewUser?userid=1
<h1>PHP Error [500]</h1>
<p>Trying to access array offset on value of type null (/var/www/ls-ce-5x/public/application/views/userManagement/partial/showuser.php:16)</p>
<pre>#0 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/base/CErrorHandler.php(133): CErrorHandler->handleError()
#1 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/base/CApplication.php(832): CErrorHandler->handle()
#2 /var/www/ls-ce-5x/public/application/views/userManagement/partial/showuser.php(16): LSYii_Application->handleError()
#3 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CBaseController.php(126): require()
#4 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CBaseController.php(95): UserManagementController->renderInternal()
#5 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CController.php(872): UserManagementController->renderFile()
#6 /var/www/ls-ce-5x/public/application/controllers/UserManagementController.php(462): UserManagementController->renderPartial()
#7 unknown(0): UserManagementController->actionViewUser()
#8 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/actions/CAction.php(115): ReflectionMethod->invokeArgs()
#9 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/actions/CInlineAction.php(47): CInlineAction->runWithParamsInternal()
#10 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CController.php(308): CInlineAction->runWithParams()
#11 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CController.php(286): UserManagementController->runAction()
#12 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CController.php(265): UserManagementController->runActionWithFilters()
#13 /var/www/ls-ce-5x/public/application/controllers/LSBaseController.php(145): UserManagementController->run()
#14 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CWebApplication.php(282): UserManagementController->run()
#15 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/web/CWebApplication.php(141): LSYii_Application->runController()
#16 /var/www/ls-ce-5x/public/vendor/yiisoft/yii/framework/base/CApplication.php(185): LSYii_Application->processRequest()
#17 /var/www/ls-ce-5x/public/index.php(161): LSYii_Application->run()
</pre> |
|
|
|
/var/www/ls-ce-5x/public/application/views/userManagement/partial/showuser.php:
That file is not updated by the patch. It may come from somewhere else. |
|
|
|
https://github.com/LimeSurvey/LimeSurvey/blame/9b67749428bac123a5e1939e37114cf99c5ade23/application/views/userManagement/partial/showuser.php#L16
That has been like that for 4 years. Maybe something else done somehwere else impacted on this screen.
Maybe this is just seen because you have debug turned on.
Try changin that line (16) as this in order to be able to test tis ticket and woraournd it:
$oUser->parentUser ? $oUser->parentUser['full_name'] : ''
|
|
|
|
Yeah, this fixes the issue. I think we can leave it like that since I don't know which other views use this partial and it only occurs with debug=2. |
|
|
|
Fix committed to 5.x branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35611 |
|
|
|
Tested and merged. |
|
|
|
That has been like that for 4 years. Maybe something else done somehwere else impacted on this screen.
Need to be reported , usnure if we need to fix $oUser->getParentUser to alway return some value (empty string) or not ?
Edit : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/User.php#L647 |
|
|
|
Maybe just a new method parentName() ?
That would be easier to use. |
|
|
|
Maybe just a new method parentName() ?
We already have it : https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/User.php#L647
I edited my comment. We use it in Survey listing if i don't make error. |
|
|
|
Fixed in Release 5.6.41+231017 |
|
