View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
19081 | Bug reports | Assets | public | 2023-09-13 12:14 | 2023-11-13 15:43 |
Reporter | tigurr | Assigned To | tibor.pacalat | ||
Priority | high | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Product Version | 6.2.x | ||||
Summary | 19081: Lato fonts are loaded from Google fonts instead of solely using the ones shipped with limesurvey itself | ||||
Description | https://github.com/LimeSurvey/LimeSurvey/blob/master/assets/fonts/lato.css references the lato font shipped with limesurvey under the directory at https://github.com/LimeSurvey/LimeSurvey/tree/master/assets/fonts/font-src however probably due to the reference to google fonts at the new default Bootswatch theme actually load fonts from google fonts instead of solely using the ones shipping them with limesurvey itself. This can be be considered a privacy issue, e.g. in Germany. | ||||
Steps To Reproduce | Steps to reproduce
Expected resultHave everything loaded from the server limesurvey is hosted on instead of fetching stuff from other servers e.g. google. Actual resultObserve fonts loaded from fonts.googleapis.com & fonts.gstatic.com | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 20 | ||||
Complete LimeSurvey version number (& build) | 6.2.6+230904 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Chrome | ||||
Database type & version | MariaDB 10.11.4 | ||||
Server OS (if known) | |||||
Webserver software & version (if known) | |||||
PHP Version | 8.1.21 | ||||
I've just noticed the various css variations also reference different fonts so it might also apply to not only lato and flatly.min.css in case of using a different variation. In our case and from there the screenshot is we didn't select any variation in the "Variations" dropdown list of "Survey options for theme bootswatch" (basically because none them is without issues in regards to readability and colors but that's another thing not relevant or related to this bug report). |
|
@tigurr, can I ask you to test the changes in here? If good, we will go ahead and apply them to the rest of the variations. Thanks |
|
@gabrieljenik flatly.min.css from https://github.com/LimeSurvey/LimeSurvey/pull/3543/ appears to work fine for me, though I had to also clean tmp/assets/ after replacing the file for limesurvey to pick up the changes. |
|
We noticed source-sans-pro.css is also served from cloud while it could be served locally. Can you confirm? Thanks |
|
@gabrieljenik well of course, like I stated in comment https://bugs.limesurvey.org/view.php?id=19081#c76982 above, there are plenty of other fonts referenced from google in the various css variations. Maybe that's on purpose but it would be nice to just have a font selection on the bootswatch theme itself like in fruity instead of the various css variants shipping their own fonts hardcoded. Roboto: https://github.com/LimeSurvey/LimeSurvey/blob/master/themes/survey/bootswatch/css/variations/cyborg.min.css |
|
After going deeper into this found the following: Local FontsSome themes already support local fonts, like Fruity. Fonts are published as packages and they can be configured using the config/fonts.php Then, the options.js (or similar) from the theme manages to turn the font selection into a parameter in the packages_to_load option. BootswatchBootswatch doesn't have the same mechanism. It used the same approach as we did on this PR: On the CSS do Denis did a good question: What happens when asset manager is not being used? So we dig a little bit.
ConclusionsCould we use in Bootswatch the system ued fro fruity? Does it worth it? I would rather patch all files from bootswatch as it was on 18422, which was already the way to go. Lookforward to your comments. |
|
I second your opinion, everything else would probably be something for possible future developement/improvements and is out of scope for just fixing this issue for now, however I'm just a reporter and not involved in developement whatsoever. I don't want to hijack this thread at all but just a simple question regarding the future and defaults in general as fruity was mentioned. Is fruity still considered the standard / best supported theme, somehow I got under the maybe false impression bootswatch might actually replace it as the default/standard theme in the (near) future(?). Thanks in advance for any claraification on this subject so I know where we possibly may invest time in adapting the theme for our needs to not have to start all over any time soon. |
|
I think it is fine to keep the current implementation for bootswatch, however i would at some point prefer to add compiling steps to it as well to prevent us from having to edit minified files. |
|
I would open a separate ticket as to assses if 18422 needs to be reaplied or not. |
|
Already test it : OK for core theme. |
|
@tigurr if you wish to help by testing a bit more would be great! Thanks |
|
Its' variation here , need to set variation in package ? Else : good idea. |
|
@gabrieljenik there are some code checks that are failing https://github.com/LimeSurvey/LimeSurvey/actions/runs/6668816209?pr=3543 |
|
Will merge master on top of it |
|
Green |
|
Tested and merged. |
|
Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35738 |
|
Fixed in Release 6.3.5+231113 |
|
LimeSurvey: master 47ec6559 2023-11-09 20:26 Gabriel Jenik Committer: GitHub Details Diff |
Fixed issue 19081: Lato fonts are loaded from Google fonts instead of solely using the ones shipped with limesurvey itself (#3543) Co-authored-by: Lapiu Dev <devgit@lapiu.biz> |
Affected Issues 19081 |
|
add - themes/survey/bootswatch/css/variations/README.txt | Diff File | ||
mod - themes/survey/bootswatch/css/variations/cosmos.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/cyborg.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/darkly.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/flatly.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/journal.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/lumen.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/paper.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/readable.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/sandstone.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/simplex.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/spacelab.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/superhero.min.css | Diff File | ||
mod - themes/survey/bootswatch/css/variations/yeti.min.css | Diff File |
Date Modified | Username | Field | Change |
---|---|---|---|
2023-09-13 12:14 | tigurr | New Issue | |
2023-09-13 12:14 | tigurr | File Added: googlefonts.png | |
2023-09-13 13:49 | ollehar | Priority | none => high |
2023-09-13 13:59 | tigurr | Note Added: 76982 | |
2023-09-13 13:59 | tigurr | Bug heat | 0 => 2 |
2023-09-13 15:37 | gabrieljenik | Assigned To | => gabrieljenik |
2023-09-13 15:37 | gabrieljenik | Status | new => assigned |
2023-10-17 13:21 | gabrieljenik | Note Added: 77737 | |
2023-10-17 13:21 | gabrieljenik | Bug heat | 2 => 4 |
2023-10-17 13:21 | gabrieljenik | Status | assigned => feedback |
2023-10-17 15:56 | tigurr | Note Added: 77746 | |
2023-10-17 15:56 | tigurr | Status | feedback => assigned |
2023-10-18 19:11 | gabrieljenik | Note Added: 77773 | |
2023-10-20 12:39 | tigurr | Note Added: 77804 | |
2023-10-25 19:07 | gabrieljenik | Note Added: 78014 | |
2023-10-25 19:07 | gabrieljenik | Note Edited: 78014 | |
2023-10-25 19:07 | gabrieljenik | Assigned To | gabrieljenik => tibor.pacalat |
2023-10-25 19:07 | gabrieljenik | Status | assigned => feedback |
2023-10-26 13:26 | tigurr | Note Added: 78041 | |
2023-10-26 13:26 | tigurr | Status | feedback => assigned |
2023-10-26 16:16 | tibor.pacalat | Bug heat | 4 => 6 |
2023-10-26 16:42 | p_teichmann | Note Added: 78052 | |
2023-10-26 16:42 | p_teichmann | Bug heat | 6 => 8 |
2023-10-27 14:08 | tibor.pacalat | Bug heat | 8 => 6 |
2023-11-02 22:38 | gabrieljenik | Note Added: 78218 | |
2023-11-02 22:39 | gabrieljenik | Note Edited: 78218 | |
2023-11-02 22:45 | gabrieljenik | Assigned To | tibor.pacalat => DenisChenu |
2023-11-02 22:45 | gabrieljenik | Status | assigned => ready for code review |
2023-11-03 08:52 | DenisChenu | Assigned To | DenisChenu => gabrieljenik |
2023-11-03 08:52 | DenisChenu | Status | ready for code review => ready for testing |
2023-11-03 08:52 | DenisChenu | Note Added: 78226 | |
2023-11-03 08:52 | DenisChenu | Bug heat | 6 => 8 |
2023-11-03 12:49 | gabrieljenik | Assigned To | gabrieljenik => tibor.pacalat |
2023-11-03 12:50 | gabrieljenik | Note Added: 78245 | |
2023-11-03 14:52 | DenisChenu | Note Added: 78246 | |
2023-11-06 13:54 | guest | Bug heat | 8 => 14 |
2023-11-07 16:56 | tibor.pacalat | Note Added: 78326 | |
2023-11-07 16:56 | tibor.pacalat | Bug heat | 14 => 16 |
2023-11-07 18:00 | gabrieljenik | Note Added: 78328 | |
2023-11-08 21:09 | gabrieljenik | Note Added: 78343 | |
2023-11-09 19:27 | tibor.pacalat | Status | ready for testing => resolved |
2023-11-09 19:27 | tibor.pacalat | Resolution | open => fixed |
2023-11-09 19:27 | tibor.pacalat | Note Added: 78364 | |
2023-11-09 19:32 | Changeset attached | => LimeSurvey master 47ec6559 | |
2023-11-09 19:32 | guest | Note Added: 78366 | |
2023-11-09 19:32 | guest | Bug heat | 16 => 18 |
2023-11-13 15:43 | LimeBot | Note Added: 78431 | |
2023-11-13 15:43 | LimeBot | Status | resolved => closed |
2023-11-13 15:43 | LimeBot | Bug heat | 18 => 20 |