Any progress here?

Hi Carsten. We started reviewing this yesterday. Sorry. Haven't noticed it was urgent.
I missed the urgency as I think it wasn't like that on the email notification.
Anyway, we are on it now :)

https://github.com/LimeSurvey/LimeSurvey/pull/2689

Moved Open Sans out from the uploads folder.
Made some fonts local

Abput updating Email Notifications (application/views/userManagement/partial/usernotificationemail.php), are yo sure about that?
We would need to place a full URL pointing to assets/fonts, instead of using the asset manager given URL.
Not sure if keeping the google URL is better for the email notification.

Thoughts?

About email : best is to use websafe font …
Or better : don't force font …

PS : remove all included style can be a REALLY GREAT solution.

And can be the BEST solution …

@gabrieljenik : maybe we can create a second issue for Notification email ?

Abput updating Email Notifications (application/views/userManagement/partial/usernotificationemail.php), are yo sure about that?

I just test : seems outdated ?
I ask for a new password : i get a text email on 5.4.8

I would let @c_schmitz decide

I would just remove the font usage from the registration email, instead use something standard
It seems /partial/usernotificationemail.php it is only used if the admin resets a password. Can you check?

I would just remove the font usage from the registration email, instead use something standard

Standard means not using a font?
Sorry, got lost there :)

It seems /partial/usernotificationemail.php it is only used if the admin resets a password. Can you check?

You are saying there should be other files impacted... right?

It seems /partial/usernotificationemail.php it is only used if the admin resets a password. Can you check?

I check this morning
Create user + ask pasword.

Password reset is sent as plain text only.
Something in my config ?

Capture d’écran du 2022-10-27 14-56-51.png (76,247 bytes)   

Capture d’écran du 2022-10-27 14-56-51.png (76,247 bytes)   

Wasn't there a setting for sending HTML emails?

Wasn't there a setting for sending HTML emails?

Only for survey, no ?
I check on all global settings : only for User creation we have a complete system (see screenshot)

Else for password : all is done here : https://github.com/LimeSurvey/LimeSurvey/blob/09765dcb3ce4055b433b5b1d13d8834206585440/application/models/services/PasswordManagement.php#L149

For me /partial/usernotificationemail.php is deprecated.

Capture d’écran du 2022-10-27 17-01-13.png (74,398 bytes)   

Capture d’écran du 2022-10-27 17-01-13.png (74,398 bytes)   

OK, admin creation emails are handled here:
https://github.com/LimeSurvey/LimeSurvey/blob/09765dcb3ce4055b433b5b1d13d8834206585440/application/controllers/UserManagementController.php#L1218

Following down the code partial/usernotificationemail is being used when an admin user is created

@c_schmitz Should we replace font import there as well?

Following down the code partial/usernotificationemail is being used when an admin user is created

I still don't understand whe it's really used …
When i create an user : i get clean HTML without extra part …

Capture d’écran du 2022-10-31 15-33-04.png (90,676 bytes)   

Capture d’écran du 2022-10-31 15-33-04.png (90,676 bytes)   

i get clean HTML without extra part …

What is the "extra part"?

What is the "extra part"?

No font, to table, no td, nothing from https://github.com/LimeSurvey/LimeSurvey/blob/09765dcb3ce4055b433b5b1d13d8834206585440/application/views/userManagement/partial/usernotificationemail.php

You write «is being used when an admin user is created» but i really didn't see when it's created.

I just want to know when this part is used …

Is this what you are looking for?

actionApplyEdit()
https://github.com/LimeSurvey/LimeSurvey/blob/73ef7087b344ea55b44629ba596708e540d15838/application/controllers/UserManagementController.php#L187

createAdminUser()
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/controllers/UserManagementController.php#L1228

sendPasswordLinkViaEmail()
https://github.com/LimeSurvey/LimeSurvey/blob/73ef7087b344ea55b44629ba596708e540d15838/application/models/services/PasswordManagement.php#L77

sendAdminMail()
https://github.com/LimeSurvey/LimeSurvey/blob/73ef7087b344ea55b44629ba596708e540d15838/application/models/services/PasswordManagement.php#L216

Is this what you are looking for?

A way to get this email …
Way to reproduce the issue

When edit user ?

Added web safe fonts a s fallback on the email sent when "Reset pwd with mass action"

«Reset pwd with mass action» …

OK … only way to get this email …

Tested OK

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=34040

Fixed in Release 5.4.12+221121