View Issue Details

This bug affects 1 person(s).
 6
IDProjectCategoryView StatusLast Update
18495Bug reportsLabel setspublic2022-12-08 15:01
ReporterShiXiong Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status assignedResolutionopen 
Product Version5.4.x 
Summary18495: configuration tab is not visible to a user with only create label set permission
Description

This issue is detected while the testing label sets permission.
"Create" labels --> should be able to create and view your own label sets
"View" labels --> should be able to view all label sets in the system, created by anyone

Steps To Reproduce

Steps to reproduce

  1. create a new user in the user management.
  2. set permission "create label sets" only.
  3. logout and log in again with a new user.
  4. configuration tab is not visible.

Expected result

configuration tab should be visible and the user can view label sets created by self.

Actual result

as the configuration is not, the user can't create/view own label sets

TagsNo tags attached.
Bug heat6
Complete LimeSurvey version number (& build)demo
I will donate to the project if issue is resolvedNo
Browserchrome
Database type & versionmysql
Server OS (if known)
Webserver software & version (if known)
PHP Version8.0

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

ShiXiong

ShiXiong

2022-11-17 16:03

reporter  

1.png (135,664 bytes)
2.png (80,608 bytes)   
2.png (80,608 bytes)   
3.png (114,987 bytes)
4.png (84,427 bytes)   
4.png (84,427 bytes)   
DenisChenu

DenisChenu

2022-11-17 16:11

developer   ~72803

Last edited: 2022-11-17 16:14

There are no owner of Label sets … (currenlly)

then "Create label sets" can not be really used …
We need more

  • Use ALL label set
  • Manage ALL label set (create/update/delete)

The way you ask is moire a feature request
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Interfaces/PermissionInterface.php
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Traits/PermissionTrait.php
https://github.com/LimeSurvey/LimeSurvey/tree/master/application/extensions/UserPermissionsWidget

ShiXiong

ShiXiong

2022-11-17 20:58

reporter   ~72805

I noted this bug always exists if view permission is not added.
Regardless of what role you have, if you don't have view permission, the configuration tab is not showing in any case.

DenisChenu

DenisChenu

2022-11-18 09:26

developer   ~72807

Regardless of what role you have, if you don't have view permission, the configuration tab is not showing in any case.

Yes, it's more related to the current situation … where create need view.

Maybe start by update sentence ?

And create a feature request to have a complete Permission system for label start by owner , and after adding permission by single label set.

gabrieljenik

gabrieljenik

2022-12-02 21:44

manager   ~72990

Will try to reproduce

DenisChenu

DenisChenu

2022-12-08 09:06

developer   ~73022

@gabrieljenik : in my opinion, the only way to really fix the issue if to create (minimal) Permission system
Maybe starting only with owner ?
https://github.com/LimeSurvey/LimeSurvey/blob/872336377c64a243db8f4210e3f8942c9429897d/application/models/Traits/PermissionTrait.php#L10

The user can add only to own Label sets ?
(and maybe create a label set edition to allow to update owner)

After : unsure on the "list" ?
If user have 'read' right : he can see all Label set
If user didn't have 'read' right : he see only own label set

gabrieljenik

gabrieljenik

2022-12-08 13:21

manager   ~73036

Last edited: 2022-12-08 13:21

Let me re-approach the whole issue.

From the very begginig it is said:

"Create" labels --> should be able to create and view your own label sets

Are we sure about that? Where is that stated?

As labels have no owners, it means labels can be generally managed by anyone who has access to labels.

So, maybe

  • this is not a bug
  • view permission is needed to access the screen
  • create permission is needed to then go the extra mile and create labels.

Thoughts?

PS: Yes if we want to have label owners, we would need a FR

DenisChenu

DenisChenu

2022-12-08 14:20

developer   ~73039

Last edited: 2022-12-08 14:22

"Create" labels --> should be able to create and view your own label sets

Are we sure about that? Where is that stated?

There are no state here … but this clearly seems as an issue :) because if you chjeck only Create label : there are no way to create label.

Thoughts?

Same then your 3 points

PS: Yes if we want to have label owners, we would need a FR

Right

EDIT

As labels have no owners, it means labels can be generally managed by anyone who has access to labels.

No owner and no single permission. Managed according to Global Permission.

gabrieljenik

gabrieljenik

2022-12-08 14:52

manager   ~73040

if you chjeck only Create label : there are no way to create label.

I think this is a matter of procedure for permission giving.
Not a bug.

From the top of my head, it is common to need to give create and view permission at the same time.

DenisChenu

DenisChenu

2022-12-08 15:01

developer   ~73041

I think this is a matter of procedure for permission giving.

Maybe need to give more detail on GUI for a quick fix, ading the real fix (owner) in a feature request if LS GMBH team want it.

Permission to create, view, update, delete, export and import label sets/labels

PS : we have near same issue with Theme
User have owner but there are complex situation with group (enable or not)
UserGroup didn't use owner : https://github.com/LimeSurvey/LimeSurvey/pull/2581 + https://bugs.limesurvey.org/view.php?id=18294
PS : PR 2581 is a quick fix to have NO difference between 3 and 5 , yes usage of owner_id is needed but broke API if used.

Issue History

Date Modified Username Field Change
2022-11-17 16:03 ShiXiong New Issue
2022-11-17 16:03 ShiXiong File Added: 1.png
2022-11-17 16:03 ShiXiong File Added: 2.png
2022-11-17 16:03 ShiXiong File Added: 3.png
2022-11-17 16:03 ShiXiong File Added: 4.png
2022-11-17 16:11 DenisChenu Note Added: 72803
2022-11-17 16:11 DenisChenu Bug heat 0 => 2
2022-11-17 16:14 DenisChenu Note Edited: 72803
2022-11-17 20:58 ShiXiong Note Added: 72805
2022-11-17 20:58 ShiXiong Bug heat 2 => 4
2022-11-18 09:26 DenisChenu Note Added: 72807
2022-12-02 21:44 gabrieljenik Assigned To => gabrieljenik
2022-12-02 21:44 gabrieljenik Status new => acknowledged
2022-12-02 21:44 gabrieljenik Note Added: 72990
2022-12-02 21:44 gabrieljenik Bug heat 4 => 6
2022-12-02 21:53 gabrieljenik Assigned To gabrieljenik =>
2022-12-02 21:53 gabrieljenik Status acknowledged => confirmed
2022-12-07 19:40 gabrieljenik Assigned To => gabrieljenik
2022-12-07 19:40 gabrieljenik Status confirmed => assigned
2022-12-08 09:06 DenisChenu Note Added: 73022
2022-12-08 13:21 gabrieljenik Note Added: 73036
2022-12-08 13:21 gabrieljenik Note Edited: 73036
2022-12-08 14:20 DenisChenu Note Added: 73039
2022-12-08 14:21 DenisChenu Note Edited: 73039
2022-12-08 14:22 DenisChenu Note Edited: 73039
2022-12-08 14:52 gabrieljenik Note Added: 73040
2022-12-08 15:01 DenisChenu Note Added: 73041