There are no owner of Label sets … (currenlly)

then "Create label sets" can not be really used …
We need more

• Use ALL label set
• Manage ALL label set (create/update/delete)

The way you ask is moire a feature request
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Interfaces/PermissionInterface.php
https://github.com/LimeSurvey/LimeSurvey/blob/master/application/models/Traits/PermissionTrait.php
https://github.com/LimeSurvey/LimeSurvey/tree/master/application/extensions/UserPermissionsWidget

I noted this bug always exists if view permission is not added.
Regardless of what role you have, if you don't have view permission, the configuration tab is not showing in any case.

Regardless of what role you have, if you don't have view permission, the configuration tab is not showing in any case.

Yes, it's more related to the current situation … where create need view.

Maybe start by update sentence ?

And create a feature request to have a complete Permission system for label start by owner , and after adding permission by single label set.

Will try to reproduce

@gabrieljenik : in my opinion, the only way to really fix the issue if to create (minimal) Permission system
Maybe starting only with owner ?
https://github.com/LimeSurvey/LimeSurvey/blob/872336377c64a243db8f4210e3f8942c9429897d/application/models/Traits/PermissionTrait.php#L10

The user can add only to own Label sets ?
(and maybe create a label set edition to allow to update owner)

After : unsure on the "list" ?
If user have 'read' right : he can see all Label set
If user didn't have 'read' right : he see only own label set

Let me re-approach the whole issue.

From the very begginig it is said:

"Create" labels --> should be able to create and view your own label sets

Are we sure about that? Where is that stated?

As labels have no owners, it means labels can be generally managed by anyone who has access to labels.

So, maybe

• this is not a bug
• view permission is needed to access the screen
• create permission is needed to then go the extra mile and create labels.

Thoughts?

PS: Yes if we want to have label owners, we would need a FR

"Create" labels --> should be able to create and view your own label sets

Are we sure about that? Where is that stated?

There are no state here … but this clearly seems as an issue :) because if you chjeck only Create label : there are no way to create label.

Thoughts?

Same then your 3 points

PS: Yes if we want to have label owners, we would need a FR

Right

EDIT

As labels have no owners, it means labels can be generally managed by anyone who has access to labels.

No owner and no single permission. Managed according to Global Permission.

if you chjeck only Create label : there are no way to create label.

I think this is a matter of procedure for permission giving.
Not a bug.

From the top of my head, it is common to need to give create and view permission at the same time.

I think this is a matter of procedure for permission giving.

Maybe need to give more detail on GUI for a quick fix, ading the real fix (owner) in a feature request if LS GMBH team want it.

Permission to create, view, update, delete, export and import label sets/labels

PS : we have near same issue with Theme
User have owner but there are complex situation with group (enable or not)
UserGroup didn't use owner : https://github.com/LimeSurvey/LimeSurvey/pull/2581 + https://bugs.limesurvey.org/view.php?id=18294
PS : PR 2581 is a quick fix to have NO difference between 3 and 5 , yes usage of owner_id is needed but broke API if used.

Is this a bug? What do you think @tibo.pascalat ?

@gabrieljenik if the system wasn't designed to support this, this is clearly a feature request. Otherwise, it is a bug.

@ollehar @c_schmitz what do you think? Should this be implemented? IMO if there is a need for user with such permissions, we should do it, otherwise no.

if there is a need for user with such permissions

There are clearly NEED of a complete

1. LabelSets permission
2. SurveyTheme permission

Like we have for Survey and SurveyGroups

This discussion seems derailed? From the bug description, it seems like a pretty obvious bug. I didn't test it tho.

There are no owner of Label sets … (currenlly)

Ah sorry, missed this one.

What about adding a new column for label set ownership as a start? owner_id.

Maybe starting only with owner ?
https://github.com/LimeSurvey/LimeSurvey/blob/872336377c64a243db8f4210e3f8942c9429897d/application/models/Traits/PermissionTrait.php#L10

+1

I can take it .
Denis

Adding minimal Permission : usage of owner.

This fix related issue too.
(and i think another one to be reported)

Changed severity to "feature".

Next feature
v6.X : user can create own label sets and manage own labels set
v6.Y : user can create label set and give to any other user (and this user can manage totally the label set)
v6.Z : after adding all Permission : user can share is label set with some specific other users.

We are at 6.X currently

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=35223

Fixed in Release 6.2.0+230732