View Issue Details

This issue affects 2 person(s).
 16
IDProjectCategoryView StatusLast Update
18040Bug reportsLabel setspublic2026-10-09 16:12
Reportergabrieljenik Assigned Toollehar  
PrioritynoneSeveritypartial_block 
Status closedResolutionfixed 
Product Version5.2.x 
Summary18040: Add buttons submit the whole labelset instead of only adding a row
Description

On the PHP side, the html of the table is composed with the labels that are there when you enter.
But when you add a label, the html of the added row is built by the javascript, and is different from the one built by PHP.
That is not consistent and is a problem.

In my browser, and I suppose that in many, the "Add" button is simply a <button>. Since it doesn't have type="button", it behaves like a form submit. That is, the click handler adds a row and then the form is also submitted.

The screen should function as the subquestions/answers part of the question editor. That is, every time you press Add it should make a query to the server to fetch the html to add.

Steps To Reproduce

Discovered while reviewing 18027

TagsNo tags attached.
Bug heat16
Complete LimeSurvey version number (& build)Version 5.3.8+220404
I will donate to the project if issue is resolvedNo
BrowserGoogle Chrome
Database type & versionMS SQL Server 2016
Server OS (if known)Win Server 2019
Webserver software & version (if known)IIS 10
PHP Version7.4
Git branch / Pull Request URL

Relationships

related to 18027 closedgabrieljenik Unable to create a label set 
has duplicate 18523 closedc_schmitz whenever click the “+” icon to add a label, there is always an alert showing with the same content when the save button is clic 
related to 17845 closedgabrieljenik Label set preview only shows last item, other items are missing 

Users monitoring this issue

SESSOU

Activities

gabrieljenik

gabrieljenik

2022-04-21 22:00

developer   ~69186

We should also review the screen when using multiple languages and exporting.

gabrieljenik

gabrieljenik

2022-04-28 21:44

developer   ~69295

PR: https://github.com/LimeSurvey/LimeSurvey/pull/2379

gabrieljenik

gabrieljenik

2022-10-12 01:21

developer   ~72207

This may fit into master as currently the labels screen doesn't look good and also believe it corrupts data

gabrieljenik

gabrieljenik

2023-07-15 00:03

developer   ~76098

Last edited: 2023-07-15 00:03

This is a big change, but somehow is needed for v5.
Should I prepare it @c_schmitz?

Issue History

Date Modified Username Field Change
2022-04-18 22:41 gabrieljenik New Issue
2022-04-18 22:41 gabrieljenik Issue generated from: 18027
2022-04-18 22:41 gabrieljenik Relationship added related to 18027
2022-04-21 22:00 gabrieljenik Note Added: 69186
2022-04-21 22:00 gabrieljenik Bug heat 0 => 2
2022-04-21 22:04 gabrieljenik Relationship added related to 17845
2022-04-22 14:38 gabrieljenik Assigned To => gabrieljenik
2022-04-22 14:38 gabrieljenik Status new => assigned
2022-04-28 21:44 gabrieljenik Status assigned => ready for testing
2022-04-28 21:44 gabrieljenik Note Added: 69295
2022-07-05 19:30 gabrieljenik Assigned To gabrieljenik => ollehar
2022-10-12 01:21 gabrieljenik Status ready for testing => ready for code review
2022-10-12 01:21 gabrieljenik Note Added: 72207
2023-03-06 11:37 SESSOU Issue Monitored: SESSOU
2023-03-06 11:37 SESSOU Bug heat 2 => 10
2023-05-03 13:32 ollehar Status ready for code review => resolved
2023-05-03 13:32 ollehar Resolution open => fixed
2023-06-20 17:49 c_schmitz Status resolved => closed
2023-07-15 00:03 gabrieljenik Note Added: 76098
2023-07-15 00:03 gabrieljenik Note Edited: 76098
2026-10-09 16:12 c_schmitz Relationship added has duplicate 18523
2026-10-09 16:12 c_schmitz Bug heat 10 => 16