View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|17086||Bug reports||Survey taking||public||2021-02-12 09:03||2021-02-17 12:16|
|Summary||17086: Imported survey : hide tip broken|
|Description||When use last git version : old survey didn't show any tip …|
|Steps To Reproduce||Update to last git : https://github.com/LimeSurvey/LimeSurvey/commit/372badb414dcfaffb2314c276d99c3b38de6d20c|
Import included surey
Test : no tips are shown
|Additional Information||switch MUST use 0/1 for actve/inactive else break ALL attribute using switch ...|
Someone put Y/N : this broke all compatibility (and logic …) don't follow it … please …
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||4.4.4 github|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||not relevant|
|Server OS (if known)||not relevant|
|Webserver software & version (if known)||not relevant|
|PHP Version||not relevant|
limesurvey_survey_hideTip3X.lss (22,420 bytes)
it wasn't me who switch to Y/N. Maybe this happend during qanda-refactoring (which has never been finished). I absolutely agree with you. Internally there should be used always 0 (integer) for 'No' and 1 (integer) for 'Yes'. I think the hole process of the switches should be checked and reimplemented. I don't know if i will get time for that. I hope so.
Thanks for your answers. I also already mentioned it in the team meetings month ago.
i also think the label for the user should be "Hide tip". This is confusing. It should be something like "Do you want to show the tip for this question?" and then the user could select Yes (showing the tip) or No (for not showing the tip). Internally (in the software) we should use 0 for "don't show the tip" and 1 for "show the tip".
> it wasn't me who switch to Y/N.
I know :)
> Internally there should be used always 0 (integer) for 'No' and 1 (integer) for 'Yes'.
Yes : and it don't broke existing system. We have same issue with all switch …
I really think we **must not** fix attribute by attribute, but fix switch system directly.
It's a one line fix in https://github.com/LimeSurvey/LimeSurvey/blob/c5c195389d46011c6f0efa8730511704f840c3b0/application/extensions/AdvancedSettingWidget/views/switch.php#L8 …
(if needed : add a DB update to move Y to 1 and N to 0 for each core attributes)
> i also think the label for the user should be "Hide tip".
I didn't have issue with «Hide tip» : Yes / No.
And i don't remind of forum post for this.
I think it's hide_tip since 1.71 or before ;)
PS : https://bugs.limesurvey.org/view.php?id=17087 it's **exactly** the same issue but for checkbox.
And surely some other …
|2021-02-12 09:03||DenisChenu||New Issue|
|2021-02-12 09:03||DenisChenu||Status||new => assigned|
|2021-02-12 09:03||DenisChenu||Assigned To||=> pstelling|
|2021-02-12 09:03||DenisChenu||File Added: limesurvey_survey_hideTip3X.lss|
|2021-02-12 09:03||DenisChenu||File Added: Capture-3X.png|
|2021-02-12 09:03||DenisChenu||File Added: Capture-445.png|
|2021-02-12 09:06||DenisChenu||Relationship added||related to 17078|
|2021-02-12 09:07||DenisChenu||Relationship added||related to 17036|
|2021-02-12 09:21||DenisChenu||Relationship added||related to 17087|
|2021-02-12 10:20||pstelling||Note Added: 62204|
|2021-02-12 10:28||pstelling||Note Added: 62205|
|2021-02-12 10:45||DenisChenu||Note Added: 62206|
|2021-02-12 10:46||DenisChenu||Note Added: 62207|
|2021-02-12 11:10||DenisChenu||Note Added: 62214|
|2021-02-17 12:16||ollehar||Product Version||=> 4.4.4|