View Issue Details

This bug affects 1 person(s).
 18
IDProjectCategoryView StatusLast Update
17067Bug reportsExpression Managerpublic2022-08-08 09:17
Reportertammo Assigned Togabrieljenik  
PriorityhighSeveritypartial_block 
Status closedResolutionfixed 
Product Version3.25.11 
Target Version3.x 
Summary17067: Subquestion Relevance in array by column does not work
Description

Actually 2 errors:

  1. Relevance of column: q5 == "Y" does not seem to work
  2. When by accident you type the relevance for the column as q5 = "Y" it changes q5 in the database, where it should give an error message, I guess...
Steps To Reproduce

Load survey, on first page indicate "Nee"
On second page observe: Column B still shown, although relevance is q5 == "Y"
On thirdd page observe: q5 suddenly has changed from "N" to "Y" although values should not change through relevance equations.

TagsNo tags attached.
Attached Files
Bug heat18
Complete LimeSurvey version number (& build)3.25.11
I will donate to the project if issue is resolvedNo
BrowserFirefox
Database type & versionMySQL
Server OS (if known)Linux
Webserver software & version (if known)Apache
PHP Version7.3.27

Relationships

related to 12277 confirmed Relevance equation on column of array-number question doesn't work 
has duplicate 18269 closedc_schmitz Subquestion Relevance not correctly working on "Array by column" question type 

Users monitoring this issue

There are no users monitoring this issue.

Activities

tammo

tammo

2021-02-09 12:21

developer   ~62066

It is much simpler: even typing in 0 for relevance for a column does not work in the array by column question.

DenisChenu

DenisChenu

2021-02-09 12:25

developer   ~62067

It never work … the issue are "relevance are shown" .

To have a real column relevance : we must construct a relevance:on/off for column with javascript :)

tammo

tammo

2021-02-09 12:30

developer   ~62069

Denis: do you mean that this never has worked before?

What is the use of the relevance field in this question type then? Showing the relevance field actually "promises" that relevances work for columns...

Do you know a resource that shows how this can be done. My knowledge is Javascript is low... ;-(

DenisChenu

DenisChenu

2021-02-09 13:19

developer   ~62073

Denis: do you mean that this never has worked before?

Yes : filter by columns was never added in Expression manager

What is the use of the relevance field in this question type then?

It's an issue

Do you know a resource that shows how this can be done. My knowledge is Javascript is low... ;-(

https://gitlab.com/SondagesPro/QuestionSettingsType/hideEmptyColumn
https://extensions.sondages.pro/questions-updating-and-managing/hideemptycolumn/documentation.html

Demo on 3LTS : https://demo.sondages.pro/655577#

See TABCOL

Must be improved to be used as question settings (here : apply on whole survey …)

ollehar

ollehar

2021-03-02 19:49

administrator   ~62622

Is this blocking or should it be something else?

tammo

tammo

2021-03-02 19:57

developer   ~62623

Not blocking, but misleading. Cost me several hours to detect and make a bug report. While this was already known.

I guess the easiest thing to do is not show relevance fields and perhaps a message that relevance on column level does not work according to bug number such and so. That would be a bummer to the user, but more clear than showing relevance fields that do nothing....

DenisChenu

DenisChenu

2021-03-03 08:16

developer   ~62629

partial_block, and clearly : it's a new issue , we don't have filter on array by column before.

tammo

tammo

2021-03-03 10:11

developer   ~62630

Temporary solution: take away the relevance field at the columns. It promises something that is not there.

Good solution: make it work....

DenisChenu

DenisChenu

2021-03-03 10:15

developer   ~62631

Good solution: make it work....

This need a total rewriting of all js done by Expression Manager …
Even my plugin don't hide dynamically the columns …

The your temporary solution are a long solution …

ollehar

ollehar

2021-03-03 10:20

administrator   ~62632

Last edited: 2021-03-03 10:21

I agree that it should either be hidden or fixed. If fixed is hard, let's hide relevance equation for this question type for subquestions.

DenisChenu

DenisChenu

2021-03-03 10:22

developer   ~62633

if fixed is hard,

lol … hidding column via javascript ? we have tons of issue with this feature.

tammo

tammo

2021-03-03 12:19

developer   ~62634

BTW: I have used Denis'solution, this worked in this case.

https://gitlab.com/SondagesPro/QuestionSettingsType/hideEmptyColumn

ollehar

ollehar

2021-03-03 14:45

administrator   ~62650

Last edited: 2021-03-03 14:45

Same issue? https://bugs.limesurvey.org/view.php?id=16610 "16610: Conditionals with Array Dual Scale not working?"

DenisChenu

DenisChenu

2021-03-03 15:00

developer   ~62659

16610: Conditionals with Array Dual Scale not working?

No , not related , maybe issue with condition and number

c_schmitz

c_schmitz

2022-07-22 11:48

administrator   ~71103

Last edited: 2022-07-22 11:49

I see two solutions here:

  • Either introduce a question attribute that hides the relevance column in the subquestion editor for this question type (and other question types that don't use the relevance properly)

OR

  • Fix this issue for this question type

If the 2nd option takes too much time I would be satisifed to have the first one. However, the current state is not optimal.

DenisChenu

DenisChenu

2022-07-22 12:13

developer   ~71105

About the «Fix this issue for this question type»

The difficulty is to totally rework the Expression Manager javascript system …
Hiding a line (in jquery) : $("tr").hide();
Hiding a columns : https://gitlab.com/SondagesPro/QuestionSettingsType/hideEmptyColumn/-/blob/master/assets/hideemptycolumn.js#L18-23 (+ specific css for such class)
(set width:0 to col didn't work).

c_schmitz

c_schmitz

2022-07-22 12:36

administrator   ~71106

Several approaches here:

https://stackoverflow.com/questions/455958/hide-show-column-in-a-html-table

DenisChenu

DenisChenu

2022-07-22 12:58

developer   ~71109

Last edited: 2022-07-22 12:58

I see some td {display:none) :it don't really work …

gabrieljenik

gabrieljenik

2022-07-29 15:39

manager   ~71243

PR Master: https://github.com/LimeSurvey/LimeSurvey/pull/2553
Disabling the feature "subquestion relevance" for array by columns

gabrieljenik

gabrieljenik

2022-08-03 12:27

manager   ~71303

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=33702

LimeBot

LimeBot

2022-08-08 09:17

administrator   ~71373

Fixed in Release 5.3.30+220808

Related Changesets

LimeSurvey: master 1bf18485

2022-08-03 12:27:53

gabrieljenik


Committer: GitHub Details Diff
Fixed issue 17067: Subquestion Relevance in array by column does not work (#2553)

- Disable feature for Array by column

Co-authored-by: encuestabizdevgit <devgit@encuesta.biz>
Affected Issues
17067
mod - application/views/questionAdministration/subquestionRow.twig Diff File
mod - application/views/questionAdministration/subquestions.twig Diff File

Issue History

Date Modified Username Field Change
2021-02-08 19:58 tammo New Issue
2021-02-08 19:58 tammo File Added: limesurvey_survey_642794.lss
2021-02-09 12:21 tammo Note Added: 62066
2021-02-09 12:21 tammo File Added: Firefox_Screenshot_2021-02-09T11-18-29.574Z.png
2021-02-09 12:22 tammo Description Updated
2021-02-09 12:22 tammo Steps to Reproduce Updated
2021-02-09 12:25 DenisChenu Note Added: 62067
2021-02-09 12:30 tammo Note Added: 62069
2021-02-09 13:19 DenisChenu Note Added: 62073
2021-03-02 19:49 ollehar Note Added: 62622
2021-03-02 19:49 ollehar Assigned To => ollehar
2021-03-02 19:49 ollehar Status new => feedback
2021-03-02 19:57 tammo Note Added: 62623
2021-03-02 19:57 tammo Status feedback => assigned
2021-03-03 08:16 DenisChenu Note Added: 62629
2021-03-03 10:11 tammo Note Added: 62630
2021-03-03 10:15 DenisChenu Note Added: 62631
2021-03-03 10:20 ollehar Priority none => normal
2021-03-03 10:20 ollehar Severity block => partial_block
2021-03-03 10:20 ollehar Note Added: 62632
2021-03-03 10:21 ollehar Note Edited: 62632
2021-03-03 10:22 DenisChenu Note Added: 62633
2021-03-03 12:19 tammo Note Added: 62634
2021-03-03 14:45 ollehar Note Added: 62650
2021-03-03 14:45 ollehar Note Edited: 62650
2021-03-03 15:00 DenisChenu Note Added: 62659
2022-07-22 11:37 DenisChenu Relationship added related to 18269
2022-07-22 11:43 c_schmitz Relationship replaced has duplicate 18269
2022-07-22 11:43 c_schmitz Bug heat 6 => 12
2022-07-22 11:44 c_schmitz Summary Expression in array by column does not work => Subquestion Relevance in array by column does not work
2022-07-22 11:46 c_schmitz Assigned To ollehar => gabrieljenik
2022-07-22 11:48 c_schmitz Note Added: 71103
2022-07-22 11:48 c_schmitz Bug heat 12 => 14
2022-07-22 11:48 c_schmitz Priority normal => high
2022-07-22 11:49 c_schmitz Note Edited: 71103
2022-07-22 12:13 DenisChenu Note Added: 71105
2022-07-22 12:36 c_schmitz Note Added: 71106
2022-07-22 12:58 DenisChenu Note Added: 71109
2022-07-22 12:58 DenisChenu Note Edited: 71109
2022-07-22 15:04 gabrieljenik Relationship added related to 12277
2022-07-29 15:39 gabrieljenik Note Added: 71243
2022-07-29 15:39 gabrieljenik Bug heat 14 => 16
2022-07-29 15:42 gabrieljenik Status assigned => ready for code review
2022-08-03 12:10 ollehar Status ready for code review => ready for testing
2022-08-03 12:27 gabrieljenik Changeset attached => LimeSurvey master 1bf18485
2022-08-03 12:27 gabrieljenik Note Added: 71303
2022-08-03 12:28 gabrieljenik Resolution open => fixed
2022-08-03 12:28 ollehar Status ready for testing => resolved
2022-08-08 09:17 LimeBot Note Added: 71373
2022-08-08 09:17 LimeBot Status resolved => closed
2022-08-08 09:17 LimeBot Bug heat 16 => 18