16941: Too big file to upload, no error message - LimeSurvey bugs and feature requests

This issue affects 1 person(s).

ID	Project	Category	View Status	Date Submitted	Last Update

16941	Bug reports	Survey editing	public	2021-01-04 12:49	2021-07-12 11:53

Reporter	Jmantysalo	Assigned To	gabrieljenik
Priority	normal	Severity	minor
Status	closed	Resolution	fixed
Product Version	4.4.0-RC1

Summary	16941: Too big file to upload, no error message
Description	When I try to upload for example .ps file I get message "Denied file extension." But if I try to upload too big file it just fails silently.
Tags	No tags attached.

Bug heat	4
Complete LimeSurvey version number (& build)	Version 4.4.0-RC1+201223
I will donate to the project if issue is resolved	No
Browser
Database type & version	N/A
Server OS (if known)
Webserver software & version (if known)
PHP Version	N/A

User List	There are no users monitoring this issue.

gabrieljenik 2021-02-01 15:17 manager ~61846	I think mayb we need to port this? 16733

gabrieljenik 2021-02-18 21:46 manager ~62368 Last edited: 2021-02-18 22:41	@c_schmitz, there is a situation when the file size is bigger than the allowed by the php.ini. On those cases, the post is just empty. Then the error is that the CSRF balidation fails. That's something we can;t handle. My suggestion is to change the standard error message, mentioning that these errors could be due to big file sizes. What do you think?

gabrieljenik 2021-02-18 21:46 manager ~62369	Still, we will patch as there are some situations where the file is big, but not that big, where we can show a descriptive message.

gabrieljenik 2021-02-18 22:42 manager ~62380	ping @c_schmitz

c_schmitz 2021-02-19 00:48 administrator ~62382	Sounds good. Make it so. :-)

gabrieljenik 2021-02-25 14:16 manager ~62517	PR: https://github.com/LimeSurvey/LimeSurvey/pull/1783 Added it to the dev branch as to have more testing time

gabrieljenik 2021-05-25 13:36 manager ~64534	Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31888

c_schmitz 2021-07-12 11:53 administrator ~65344	Release done.

LimeSurvey: master 86fc7915 2021-04-08 13:48 gabrieljenik Committer: GitHub Details Diff	Fixed issue 16941: Too big file to upload, no error message (#1783)	Affected Issues 16941
	mod - application/controllers/QuestionAdministrationController.php	Diff File
	mod - application/controllers/SurveyAdministrationController.php	Diff File
	mod - application/controllers/admin/labels.php	Diff File
	mod - application/controllers/admin/participantsaction.php	Diff File
	mod - application/controllers/admin/themes.php	Diff File
	mod - application/controllers/admin/tokens.php	Diff File
	add - application/models/services/UploadHelper.php	Diff File
LimeSurvey: master af1818cf 2021-05-21 16:51 ollehar Details Diff	Revert "Fixed issue 16941: Too big file to upload, no error message (#1783)" This reverts commit 86fc7915f1628fd759c7c79c3dd8627773e8d871.	Affected Issues 16941
	mod - application/controllers/QuestionAdministrationController.php	Diff File
	mod - application/controllers/SurveyAdministrationController.php	Diff File
	mod - application/controllers/admin/labels.php	Diff File
	mod - application/controllers/admin/participantsaction.php	Diff File
	mod - application/controllers/admin/themes.php	Diff File
	mod - application/controllers/admin/tokens.php	Diff File
	rm - application/models/services/UploadHelper.php	Diff

Date Modified	Username	Field	Change
2021-01-04 12:49	Jmantysalo	New Issue
2021-01-28 20:06	cdorin	Priority	none => normal
2021-01-28 20:06	cdorin	Status	new => confirmed
2021-01-28 20:06	cdorin	Sync to Zoho Project	=> \|Yes\|
2021-02-01 15:17	gabrieljenik	Note Added: 61846
2021-02-18 21:46	gabrieljenik	Note Added: 62368
2021-02-18 21:46	gabrieljenik	Note Added: 62369
2021-02-18 22:41	gabrieljenik	Note Edited: 62368
2021-02-18 22:42	gabrieljenik	Note Added: 62380
2021-02-19 00:48	c_schmitz	Note Added: 62382
2021-02-25 14:16	gabrieljenik	Note Added: 62517
2021-03-25 14:58	c_schmitz	Assigned To	=> gabrieljenik
2021-03-25 14:58	c_schmitz	Status	confirmed => assigned
2021-04-08 11:49	c_schmitz	Status	assigned => resolved
2021-04-08 11:49	c_schmitz	Resolution	open => fixed
2021-05-25 13:36	ollehar	Changeset attached	=> LimeSurvey master af1818cf
2021-05-25 13:36	gabrieljenik	Changeset attached	=> LimeSurvey master 86fc7915
2021-05-25 13:36	gabrieljenik	Note Added: 64534
2021-07-12 11:53	c_schmitz	Note Added: 65344
2021-07-12 11:53	c_schmitz	Status	resolved => closed