View Issue Details

IDProjectCategoryView StatusLast Update
16733Bug reportsTheme editorpublic2020-10-23 14:56
Reportergabrieljenik Assigned Togabrieljenik  
PrioritynoneSeveritypartial_block 
Status assignedResolutionopen 
Product Version3.24.0 
Summary16733: When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error
Description

When importing a theme bigger in size than the allowed PHP.ini settings, there is no proper description of the error
Instead of getting a "File to Big error", we got a CRSF token error. Very missleading

TagsNo tags attached.
Complete LimeSurvey version number (& build)3.24.0
I will donate to the project if issue is resolvedNo
Browser
Database & DB-VersionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Activities

DenisChenu

DenisChenu

2020-10-13 11:40

developer   ~60169

We have some checker in Upload Question tye : maybe we can create an helper or an extension ?

gabrieljenik

gabrieljenik

2020-10-13 16:45

developer   ~60174

Sure, that's good idea.

DenisChenu

DenisChenu

2020-10-13 16:57

developer   ~60175

If you found time ;)

gabrieljenik

gabrieljenik

2020-10-16 16:19

developer   ~60233

I think this is failing as well on the Token CSV import

DenisChenu

DenisChenu

2020-10-16 16:47

developer   ~60234

I think it's failling as well onn VVimport :)

gabrieljenik

gabrieljenik

2020-10-23 14:56

developer   ~60390

Fix applied to:

Theme import (Themes list and Theme editor)
File upload in Theme editor (uploading files to a theme)
Image upload (in global theme options)
Image upload (in survey theme options
There are other places where this should be applied. I have some already fixed. Want to review these first.

These are fixed and pendign to be applied:

CPDB (Import CSV)
Labelset import
Token import
Question import (had to add 'action' and 'sid' to the URL)
These are pending to be fixed:

UploaderController
questiongroups
surveyadmin - Import survey - Need to split the method (used for copy and import), or move the 'action' to the URL.
frontend_helper, checkUploadedFileValidity ?
dataentry - Import VV file (need to split the method or assume an upload action when the request is POST)

https://github.com/LimeSurvey/LimeSurvey/pull/1633

See comments on github.

Issue History

Date Modified Username Field Change
2020-10-13 01:49 gabrieljenik New Issue
2020-10-13 11:40 DenisChenu Note Added: 60169
2020-10-13 16:45 gabrieljenik Note Added: 60174
2020-10-13 16:57 DenisChenu Note Added: 60175
2020-10-13 17:01 cdorin Assigned To => gabrieljenik
2020-10-13 17:01 cdorin Status new => assigned
2020-10-16 16:19 gabrieljenik Note Added: 60233
2020-10-16 16:47 DenisChenu Note Added: 60234
2020-10-23 14:56 gabrieljenik Note Added: 60390