View Issue Details

IDProjectCategoryView StatusLast Update
16454Bug reportsQuestion editorpublic2020-07-17 16:33
Reportergabrieljenik Assigned To 
PrioritynoneSeverityminor 
Status resolvedResolutionopen 
Product Version4.2.7 
Summary16454: Sometimes, question_order is assigned from survey_id
Description

We have noticed that sometimes question_order number is set following the survey_id.

Additional Information

See application/controllers/admin/database.php::745

                        // Moving question to a 'lower' group
                        // insert question at the beginning of the destination group
                        Question::model()->updateQuestionOrder($this->iQuestionGroupID, $iSurveyID)
TagsNo tags attached.
Complete LimeSurvey version number (& build)4.2.7
I will donate to the project if issue is resolvedNo
Browser
Database & DB-VersionMysql
Server OS (if known)
Webserver software & version (if known)
PHP Version7

Relationships

related to 16334 feedbackp_teichmann Condition editor: previous question not available 
related to 16488 confirmed Reviewing updateQuestionOrder usage 
related to 16502 new Deprecated code in Database controller 

Activities

gabrieljenik

gabrieljenik

2020-07-02 18:01

developer   ~58658

Last edited: 2020-07-10 21:14

View 2 revisions

This could happen on v3 as code is shared.
Created a ticket for v3: https://bugs.limesurvey.org/view.php?id=16488

DenisChenu

DenisChenu

2020-07-02 18:19

developer   ~58666

Last edited: 2020-07-17 16:33

In 3 : https://github.com/LimeSurvey/LimeSurvey/blob/4edbc0e8a804c72426f10ea101327d8f5667fa02/application/controllers/admin/database.php#L724

in 4 : https://github.com/LimeSurvey/LimeSurvey/blob/ee7db52e3ab48535493b0ff7401ab74703e180ff/application/controllers/admin/database.php#L746

Not the same , right ?

gabrieljenik

gabrieljenik

2020-07-07 16:11

developer   ~58752

Last edited: 2020-07-17 16:33

No, not the same. But we have identified some code on v4 which wrongly used updateQuestionOrder() which was very old.
I will update on this later as we have found some dead code.
Also we have found the method wrongly called on v3 which made the method to do nothing.

Will update later

gabrieljenik

gabrieljenik

2020-07-10 20:49

developer   ~58905

Last edited: 2020-07-17 16:33

View 2 revisions

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1482

On v4, we found "database::actionUpdateQuestion()" to be deprecated. Should it be removed?

Issue History

Date Modified Username Field Change
2020-07-02 17:59 gabrieljenik New Issue
2020-07-02 17:59 gabrieljenik Relationship added related to 16334
2020-07-02 18:01 gabrieljenik Additional Information Updated View Revisions
2020-07-02 18:01 gabrieljenik Note Added: 58658
2020-07-02 18:19 DenisChenu Note Added: 58666
2020-07-03 11:04 ollehar Product Version => 4.2.7
2020-07-06 11:43 cdorin Status new => confirmed
2020-07-07 16:11 gabrieljenik Note Added: 58752
2020-07-10 20:09 gabrieljenik Issue cloned: 16488
2020-07-10 20:09 gabrieljenik Relationship added related to 16488
2020-07-10 20:49 gabrieljenik Note Added: 58905
2020-07-10 21:14 gabrieljenik Note Edited: 58905 View Revisions
2020-07-10 21:14 gabrieljenik Note Edited: 58658 View Revisions
2020-07-16 23:44 gabrieljenik Relationship added related to 16502
2020-07-17 16:33 swendrich Status confirmed => resolved