@bismark: Please also mention at which version this was still working fine.

@cdorin: We use this at a plugin which worked fine a few months ago but is now broken. Please fix ASAP.

version 3.17.15 was ok, 3.17.16+ not

@cdorin any progress on that issue?

No progress so far, unfortunately - other tasks have been assigned to the devs this sprint.

So we have to wait at least another 2 weeks until this gets added to the next sprint and probably 2 more weeks so a fix gets provided?

That is bad for a project that should start in 1-2 weeks. Especially, since the same plugin worked fine at 3.17.x.

c_schmitz, when do we get back the old times at which I could report an urgent issue related to a customer project and then a fix was provided within a few days without planning sprints?

All I can say is, that the plugin returns the content correctly.
the content is available in the source code of the page, but html is probably broken.

any js stuff? vue? adminbasics?

While I do understand your concerns, we just simply do not have the resources at the moment for that. But I would be more than happy to check a PR from you or somebody else and merge it asap.

Sorry, we are not familiar with that vueJS stuff (if that causes the issue). I can only state that it worked fine ago and I still think it is not the partners task to fix new bugs. We already paid someone to fix https://bugs.limesurvey.org/view.php?id=16214.

maybe this commit causes trouble: https://github.com/LimeSurvey/LimeSurvey/commit/575576221f89b4dbfdead4ae02b3fe249923359d

We already paid someone to fix ?

I don't ask money ?

Else : this one work in 3.X : /index.php?r=admin/pluginhelper&sa=sidebody&plugin=TEST&method=actionSettings

    public function actionSettings($surveyId = null)
    {
        if(empty($surveyId)) {
            return "TEST";
        }
        // Do something , my real plugin

Capture d’écran du 2020-06-03 09-11-28.png (6,309 bytes)   

Capture d’écran du 2020-06-03 09-11-28.png (6,309 bytes)   

@DenisChenu we talk about sa=fullpagewrapper, sidebody works as expected

Yes, i know :) it's for an alternative way to do (i never use fullpagewrapper)

Please check if this bug still exists in the latest patch release. Thank you.

no, fullpagewrapper is not working correctly

Alright. Hm, we have a plugin we can test with?

@bismark, can you upload a simple plugin which shows the problem?

@ollehar, after Marko has uploaded a sample plugin, please temporarily turn this into a private ticket.

Sure. Just ping me.

To clarify the problem: the fullpagewrapper works fine, unless one of the parameters in the URL is the survey id.

In that case the side menu appears because the layout_insurvey.php is used.

The _renderWrappedTemplate function of Survey_Common_Action.php decides that this layout should be used when the data in the view ($ aData) includes the "surveyid".

Until version 3.17.15, when you used the fullpagewrapper it worked fine even if you put a survey id in the URL. The problem is that from the commit de7707d700d1304110eca1e12fd22b3aa1d011b7 some parameters such as the survey id are included in the $ aData (it is not included by the helper plugin, but by Survey_Common_Action itself).

The solution then is for the helper plugin to explicitly specify that the layout_main.php must be used.

PR: https://github.com/LimeSurvey/LimeSurvey/pull/1858

@gabrieljenik I didnt test, but it sounds good
thumbs up, thank you

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31643

PR for v4: https://github.com/LimeSurvey/LimeSurvey/pull/1860

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=31652

Release done.