View Issue Details
|ID||Project||Category||View Status||Date Submitted||Last Update|
|16214||Bug reports||Survey taking||public||2020-04-30 17:07||2020-06-08 11:49|
|Fixed in Version||3.22.17|
|Summary||16214: date picker question didn't work with specific language|
|Description||At the first question page of a multilingual survey I can switch to a different language just fine. The page reloads with the new translation. But if I try switching to another language, the page doesn't reload anymore.|
|Steps To Reproduce||1. Import the attached survey and activate.|
2. Start the survey and click NEXT at the welcome screen.
3. At the first question screen switch to a different language like "zulu" top right.
4. The new language loads fine.
5. Now switch back to English or any other language
-> The page doesn't reload anymore
|Tags||No tags attached.|
|Complete LimeSurvey version number (& build)||Version 3.22.14+200423|
|I will donate to the project if issue is resolved||No|
|Database & DB-Version||MySQL 5|
|Server OS (if known)||Ubuntu 18|
|Webserver software & version (if known)||Apache 2|
Please unzip to get a test LSS file. It was too large to upload.
limesurvey_survey_566183.zip (215,825 bytes)
1st page is OK,
Only after move next, right ?
Capture d’écran du 2020-04-30 19-52-05.png (105,156 bytes)
|@cdorin, can you roughly outline a time line to get this fixed?|
It looks like only languages with codes CKB and PS and ZU and AM are affected. So rather exotic ones.
@DenisChenu, any idea how that may be related to the bootstrap date picker? Are we missing the languages there?
|@Mazi : see the screenshot : clearly related to bootsrap-date-picker :)|
|@DenisChenu, I absolutely agree, but I have no idea why that is. What is your assumption?|
|Update: "Carsten said it is either the language does not exist or is not mapped for these exotic languages"|
There are a function for language : https://github.com/LimeSurvey/LimeSurvey/blob/7092a6f600d2019811b0a722d09475101c37cd85/application/helpers/surveytranslator_helper.php#L1059
$sLocale = str_replace('-informal', '', $sLocale);
$aConversions = array(
But seems strange than bootsrap-date-picker have Afrikaans or Urdu ?
@Mazi : tell me what language to get for CKB and PS and ZU and AM
@DenisChenu, these are the languages:
CKB = Kurdish (Sorani)
PS = Pashto
ZU = Zulu
AM = Amharic
But at momentjs I could only find the Kurdish one.
I mean : what language to set :
CKB => `ku` it's OK
PS => ? Maybe english … i don't know …
I don't find a way to add local from a PHP file …
PS : i don't like moment.js …
|I will ask them which languages are the most similar one from momentjs.|
Else : https://momentjs.com/docs/#/i18n/adding-locale/
Sample on https://github.com/moment/moment/blob/develop/src/locale/af.js
|Please update to the latest version and try again. Thank you.|
@ollehar, how should any of these two fixes at the update fix this given problem?
Please do not recommend updating just in case if people already use a rather new version.
FYI: The issue is NOT fixed after the update.
> Please do not recommend updating just in case if people already use a rather new version.
I will always recommend updating. It saves brain energy. We can't keep track on all changes on every release, we can only ask people to always use the latest version.
> FYI: The issue is NOT fixed after the update.
|Is this a regression from an earlier LS3 version?|
|I think it is simply a new bug that didn't show up so far because those exotic languages are rarely used.|
I can assign @Mazi to tester ?
Maybe it's bets if we can ?
Confirm : need date + specific language There are more than this 3
Armenian : https://github.com/LimeSurvey/LimeSurvey/pull/1420/files#diff-fd7e1638b849ebd4dfc8692ff3e535c7R112
zh-Hant-HK and zh-Hant-TW have better translation than zh-cn
|First test: Looks good!|
The customer did some more testing and everything works like a charm. Thanks, DenisChenu!
Let's add this to the core of LS 3 and 4.
I check to merge it tomorrow (at dev team)
And apply same to 4.X
|OK , last merge from 3LTS before merge … like to have Scrutinizer return.|
|Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=30006|
|Fixed in Release 4.2.8+200608|
LimeSurvey: master 92a4e31f
2020-06-05 08:34:11Details Diff
|Fixed issue 16214: date picker question didn't work with specific language
Dev: add momentjs param in supported language array
Dev: checked one by one … set to null if not found
Dev: more fix than Amharic, Kurdish, Pashto and Zulu
Dev: reorder supportedLanguages to find it
|mod - application/helpers/surveytranslator_helper.php||Diff File|
|2020-04-30 17:07||Mazi||New Issue|
|2020-04-30 17:08||Mazi||Note Added: 57502|
|2020-04-30 17:08||Mazi||File Added: limesurvey_survey_566183.zip|
|2020-04-30 19:50||DenisChenu||Note Added: 57512|
|2020-04-30 19:52||DenisChenu||Note Added: 57513|
|2020-04-30 19:52||DenisChenu||File Added: Capture d’écran du 2020-04-30 19-52-05.png|
|2020-05-04 17:40||Mazi||Note Added: 57527|
|2020-05-08 16:00||Mazi||Note Added: 57633|
|2020-05-08 17:35||DenisChenu||Note Added: 57637|
|2020-05-08 18:11||Mazi||Note Added: 57640|
|2020-05-12 17:57||Mazi||Note Added: 57712|
|2020-05-14 08:27||DenisChenu||Note Added: 57764|
|2020-05-14 09:02||DenisChenu||Note Added: 57765|
|2020-05-14 09:44||Mazi||Note Added: 57768|
|2020-05-14 10:18||DenisChenu||Note Added: 57770|
|2020-05-14 10:33||Mazi||Note Added: 57771|
|2020-05-14 10:49||DenisChenu||Note Added: 57772|
|2020-05-14 16:29||ollehar||Priority||none => normal|
|2020-05-14 16:30||ollehar||Note Added: 57790|
|2020-05-14 16:54||Mazi||Note Added: 57797|
|2020-05-14 16:54||Mazi||File Added: update.png|
|2020-05-14 16:59||ollehar||Note Added: 57798|
|2020-05-14 17:03||ollehar||Note Added: 57799|
|2020-05-14 17:05||Mazi||Note Added: 57800|
|2020-05-14 17:06||ollehar||Note Added: 57801|
|2020-05-14 17:18||DenisChenu||Summary||Switching languages more than once stops the survey to re-load => date picker question didn't work with specific language|
|2020-05-14 17:18||DenisChenu||Assigned To||=> DenisChenu|
|2020-05-14 17:18||DenisChenu||Status||new => assigned|
|2020-05-14 17:25||DenisChenu||Status||assigned => testing|
|2020-05-14 17:25||DenisChenu||Note Added: 57805|
|2020-05-14 17:28||DenisChenu||Note Added: 57806|
|2020-05-14 17:33||Mazi||Note Added: 57807|
|2020-05-18 16:47||Mazi||Note Added: 57886|
|2020-05-18 16:48||DenisChenu||Note Added: 57887|
|2020-06-03 09:04||DenisChenu||Note Added: 58151|
|2020-06-05 08:53||DenisChenu||Changeset attached||=> LimeSurvey master 92a4e31f|
|2020-06-05 08:53||DenisChenu||Note Added: 58187|
|2020-06-05 08:53||DenisChenu||Resolution||open => fixed|
|2020-06-05 09:29||DenisChenu||Status||testing => resolved|
|2020-06-05 09:29||DenisChenu||Fixed in Version||=> 3.22.17|
|2020-06-08 11:49||lime_release_bot||Note Added: 58218|
|2020-06-08 11:49||lime_release_bot||Status||resolved => closed|