View Issue Details

This bug affects 1 person(s).
 4
IDProjectCategoryView StatusLast Update
15564Bug reportsExpression Managerpublic2019-11-18 13:53
ReporterDenisChenu Assigned ToDenisChenu  
PrioritynoneSeverityminor 
Status closedResolutionfixed 
Product Version3.20.x 
Fixed in Version3.20.x 
Summary15564: Warnings shown for valid comparaison
Description

Fixing https://bugs.limesurvey.org/view.php?id=15532 : i add warnings for invalid comparaison ( string VS number)
But : in logic file : string VS number come for all values …

Steps To Reproduce

Import included file or create a Numeric question type

Additional Information

The warning must be sent ONLY if invalid compare (number VS string) and have forced string
I fix directly for invalid compare

TagsNo tags attached.
Bug heat4
Complete LimeSurvey version number (& build)3.20.0
I will donate to the project if issue is resolvedNo
Browsernot relevant
Database type & versionnot relevant
Server OS (if known)not relevant
Webserver software & version (if known)not relevant
PHP Versionnot relevant

Relationships

child of 15532 closedDenisChenu Feature requests Show warnings when implicit alphabetical compare is used in expressions 

Users monitoring this issue

User List There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2019-11-14 17:34

developer  

DenisChenu

DenisChenu

2019-11-14 18:09

developer   ~54590

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29252

DenisChenu

DenisChenu

2019-11-14 18:10

developer   ~54591

https://github.com/LimeSurvey/LimeSurvey/commit/05eb1172315779c61dcb3c03fbd8f3879b1006a1

lime_release_bot

lime_release_bot

2019-11-18 13:53

administrator   ~54646

Fixed in Release 4.0.0-RC8+191118

Related Changesets

LimeSurvey: master 05eb1172

2019-11-14 18:08:56

DenisChenu

Details Diff
Fixed issue 15564: Warnings shown for valid comparaison
Dev: remove warnings for ==
Dev: add warnings for bMismatchType only if there forced string
Affected Issues
15564
mod - application/helpers/expressions/em_core_helper.php Diff File

Issue History

Date Modified Username Field Change
2019-11-14 17:34 DenisChenu New Issue
2019-11-14 17:34 DenisChenu File Added: Capture d’écran du 2019-11-14 17-28-23.png
2019-11-14 17:34 DenisChenu File Added: limesurvey_survey_MultiNum.lss
2019-11-14 17:34 DenisChenu Assigned To => DenisChenu
2019-11-14 17:34 DenisChenu Status new => assigned
2019-11-14 17:34 DenisChenu Relationship added child of 15532
2019-11-14 18:00 DenisChenu Summary Warnings shown for Expression can be to wide => Warnings shown for valid comparaison
2019-11-14 18:09 DenisChenu Changeset attached => LimeSurvey master 05eb1172
2019-11-14 18:09 DenisChenu Note Added: 54590
2019-11-14 18:09 DenisChenu Resolution open => fixed
2019-11-14 18:10 DenisChenu Status assigned => resolved
2019-11-14 18:10 DenisChenu Fixed in Version => 3.20.x
2019-11-14 18:10 DenisChenu Note Added: 54591
2019-11-18 13:53 lime_release_bot Note Added: 54646
2019-11-18 13:53 lime_release_bot Status resolved => closed