Only for comparison ?
Warning on comparison or on forced string ?

Warning on operators <, >, <= and >= where at least one argument is a string. If both are numbers (e.g. by using intval before), there is no warning.

OK, then DS_STRING,DQ_STRING,STRING or WORD : right ?

Yeah, sounds right. +1

Arg …

Q00_SQ001.NAOK >= 2 : OK find WORD and NUMBER
Q00_SQ001.NAOK >= '2' : OK find WORD and DS_STRING
intval(Q00_SQ001.NAOK) >= 2 : … previuous token is RP/° … i check if i can get the function type …

Hm, shouldn't you send us an offer before you start?

Too hard for me …
Don't find how to find
(Q2.NAOK + "broke" + intval(Q00_SQ001.NAOK)) >= 2
for example …

Don't find where i get the result of a function (NUMBER or not)
https://github.com/LimeSurvey/LimeSurvey/blob/0b7ba655618bbea80dcc72294fb6dc8fcadf47e5/application/helpers/expressions/em_core_helper.php#L1858
but
https://github.com/LimeSurvey/LimeSurvey/blob/0b7ba655618bbea80dcc72294fb6dc8fcadf47e5/application/helpers/expressions/em_core_helper.php#L1978

gloups …

I always check if i was able to do it in XX hour before starting :).

Here : clearly : need more than one day … and maybe more than one week (rewriting EM).

I hoped it would be enough to add code in https://github.com/LimeSurvey/LimeSurvey/blob/0b7ba655618bbea80dcc72294fb6dc8fcadf47e5/application/helpers/expressions/em_core_helper.php#L309?

Then check $bBothString

No : it need to be in public function GetPrettyPrintString()

RDP_EvaluateBinary is only top do the final PHP part
see https://github.com/LimeSurvey/LimeSurvey/pull/1335

Adding a warning for '[0-9 ]' is really more easy … i make a pull request (free one)

Maybe i have something , you're right : RDP_EvaluateBinary we ca,n create a new warnings array.

Tomorrow :)

+1

GetPrettyPrintString will collect warnings, but warnings are created in RDP_EvalBinary, same way as with the errors BUT does not halt execution. Also, warnings shown in yellow, not red. Etc etc.

Yes,

I think i work on such system, tomorrow, can send pull request Friday.

The manual entry should recommend users to use strcmp

… no link in title …

No link to where in which title?

Since the warning is added here : https://github.com/LimeSurvey/LimeSurvey/blob/0b7ba655618bbea80dcc72294fb6dc8fcadf47e5/application/helpers/expressions/em_core_helper.php#L1333
No real way to add a link to the manual.

Can check to add a link inside the tooltip but … hard to click …

Only solution : rewrite ShowSurveyLogicFile. But its start to make a lot of update for a single warning …

OK, so maybe like this: A warning is an object, class EMWarning. Subclass warning into CompareEMWarning. If $em->warnings[] contains any CompareEMWarning, then add admin flash message about compare with link to manual.

E.g. like $bHaveError, could be $bHaveCompareWarning = true, then bla bla bla: https://github.com/LimeSurvey/LimeSurvey/blob/0b7ba655618bbea80dcc72294fb6dc8fcadf47e5/application/helpers/expressions/em_core_helper.php#L1306

8-|

A flash even if the user WANT this compare ????

My opinion SurveyLogicFile is the best (except warning css in core admin theme is awfull …)

A flash in survey logic file check, I mean.

I think of adding a line "wrning : blah blah" on question part …
If you have 30 warnings and 30 flash … 8-\

I push 1st part in some minutes

Warnings should be visible on every faulty equation like errors, I think. For flash: Definitely only one!

Maybe best solution : https://github.com/LimeSurvey/LimeSurvey/pull/1341

But have the animation is not the best …

I added a warning with + https://github.com/LimeSurvey/LimeSurvey/pull/1341/commits/b7cd1c43c330c6211164c6a23e7248e4489c2d8c

https://github.com/LimeSurvey/LimeSurvey/pull/1341

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29222

Fixed in Release 3.20.0+191112