Missing mime types in the code base?

ollehar: Sorry, what should i do?

The 500 error are only here with debug>1 and for super-admin.
Can you upload jpg file ?

The file list is here : https://github.com/LimeSurvey/LimeSurvey/blob/e749eddfea5cebf86a72e408d1c4dafdaf7fd5ae/framework/utils/fileExtensions.php#L14
Maybe we need to allow update in config.php ?

PS : code to get mime : https://github.com/LimeSurvey/LimeSurvey/blob/e749eddfea5cebf86a72e408d1c4dafdaf7fd5ae/framework/utils/CFileHelper.php#L328
Used by LimeSurvey : https://github.com/LimeSurvey/LimeSurvey/blob/e749eddfea5cebf86a72e408d1c4dafdaf7fd5ae/application/controllers/UploaderController.php#L179

Maybe … potential big issue , quick solution is to allow disable mime type checking …

Can you upload here 3 light file aac, 3gp and amr ?

And can you check locally on your server with file --mime-type ?

Hello sear DenisChenu: I´ll attaching sample Audio Files,

'debug'=>1,

Uploading an ACC file:

https://pastebin.com/FJY4SyFM

Uploading a m4a file:

https://pastebin.com/nFXRrvaz

Uploading an AMR file:

• Sorry, file type application/octet-stream (extension : bin) is not allowed!*

Uploading 3gp file:

• Sorry, file type application/octet-stream (extension : bin) is not allowed! *

Uploading 3gpp file

• Sorry, file type application/octet-stream (extension : bin) is not allowed!*

In https://github.com/LimeSurvey/LimeSurvey/blob/e749eddfea5cebf86a72e408d1c4dafdaf7fd5ae/framework/utils/fileExtensions.php#L14 we can find aac and 3gp

'audio/x-aac'=>'aac',
'video/3gpp'=>'3gp',

mime types:

1.amr 2.aac 3.m4a 4.3gp 5.3gpp

file 1.amr --mime-type

1.amr: application/octet-stream

#file 2.aac --mime-type
2.aac: audio/x-hx-aac-adts

#file 3.m4a --mime-type
3.m4a: audio/mp4

file 4.3gp --mime-type

4.3gp: application/octet-stream

file 5.3gpp --mime-type

5.3gpp: video/3gpp

Thanks in advanced.

Best regards a FreshLemonUser

2.aac: audio/x-hx-aac-adts are not inside fileExtensions.php …

But the most strange are 5.3gpp: video/3gpp : it know by your server, in fileExtensions …

Send a png or jpg file work or not ? And can you check an .ico file (maybe this one) to upload (and to file --mimetype)

About fileInfo : can you send phpinfo as html file ?

OK,

Your fileinfo is OK …
Error on check .ico file : https://github.com/LimeSurvey/LimeSurvey/commit/ab4bd5180958fd31f2dc2408ec0fffe7dc952b1c

quick solution is to allow disable mime type checking …

Too insecure IMO.

Looks like this is an issue for the Yii team? They need to add the missing mime types in their file.

@ollehar : no

1. We can use CFileHelper::getExtensionByMimeType params to use the php file from config
2. We can use $_ENV MAGIC for mime_type file

Alternate resolution :
1 : we must update call of getExtensionByMimeType : not diffcult.

2. Tell user to use setenv('MAGIC=isgreatmagicfile'); in manual

It's the reason i make a pull request and not a commit.

for the alternative fileInfo file
https://framabin.org/p/?04d0ac3af1a2933f#Uu3KTx+wWvCH5+6fdy4KG8iAAhVROeq0uWIyJ4z7Nco=

@FreshLemonUser
Can you, check with https://github.com/LimeSurvey/LimeSurvey/pull/1318#partial-pull-merging

And

        'magic_database' => '/usr/share/misc/magic.mgc',
        'magic_file' => '/whereyouputthisfile/fileExtensionsBis.php',

'/usr/share/misc/magic.mgc', ius for fedora, then i think can be same in CentOs

Correct, CentOS7 "file-libs" uses /usr/share/misc/magic.mgc as well.

For reference the current package of "file-libs".
https://centos.pkgs.org/7/centos-x86_64/file-libs-5.11-35.el7.x86_64.rpm.html

How is the OS magic file relevant if Yii has a hardcoded list anyway?

@ollehar: I had the impression that Denis wants to implement a override via this pullrequest.
https://github.com/LimeSurvey/LimeSurvey/pull/1318/files

How is the OS magic file relevant if Yii has a hardcoded list anyway?

PHP7.3 (on Fedora) using PHP7 mimetype file VS /usr/share/misc/magic.mgc (on same fedora)

amr file
application/octet-stream VS audio/amr
aac file : OK for both
m4a : ok for both
3gp:
application/octet-stream VS audio/amr
3gpp OK for both

@jelo : need 2 override:

1. MAGIC database for https://www.php.net/manual/en/function.finfo-open.php
2. fileinfo array (mime type to extension) for https://github.com/LimeSurvey/LimeSurvey/blob/7aaebcbbfc33f9cb532e695f358b416a53fb0a1e/framework/utils/CFileHelper.php#L301

Not the same for both

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=29098

OK,

Now need updating manual …

Manual updated
https://manual.limesurvey.org/QS:Allowed_filetypes
https://manual.limesurvey.org/Optional_settings#Upload_files

@cdorin : unsure of the best place for config ? Good page, but maybe didn't need a specific title ?

Fixed in Release 3.17.17+190918