I think it's already resolved in 3.17 : Please send a sample lss

https://github.com/LimeSurvey/LimeSurvey/blob/c058ddae78ef5c4ae95e9531a1aa8a9aaa7a2265/docs/release_notes.txt#L294
https://github.com/LimeSurvey/LimeSurvey/commit/24b57b56847d205fd42d3171a1955420a1576979

Please find attached sample.
Retested with Version 3.17.4+190529

I saw the github change.
I believe the relevance of child questions should be reevaluated when its group is shown (relevance: on).
At least, i believve that's the issue here.

Thanks!

Yes, confirm the issue … it's not the same but is near https://bugs.limesurvey.org/view.php?id=14467 … meaning : order of expression have an importance .

I mean : the function to hide/show Question happen before the function hide/show group …

Can be fixed adding group relevance to question .

Or to check all condition when group appear …

There are surely othis issue with such things like that:

G2Q1 : Show G2Q2 (Yes/No) Default value to Y
G2Q2 : relevance set to G2Q1 == "Y" (must be shown by default)

PS : seems there are a «start point of checking for All in one survey» here : https://github.com/LimeSurvey/LimeSurvey/blob/5ff4910ea13e97a057bd6ab784b1ab1902ffe622/application/helpers/expressions/em_manager_helper.php#L7824-L7826

But like the other : only for equation …

Ou … better solution :

When checking of question must be shown : current JS test relevanceOfQuestion && relevanceOfGroup BUT : it muts test only relevanceOfQuestion because we can show question inside a hidden group

But : it seems to be …

if ((LEMval('showQuestion.NAOK')  == 'Y'))
{
  $('#question10967').trigger('relevance:on');
  relChange10967=true;
  $('#relevance10967').val('1');
}
else {
  $('#question10967').trigger('relevance:off');
  if ($('#relevance10967').val()=='1') { relChange10967=true; }
  $('#relevance10967').val('0');
}

Not sure if I should reply something.
I think I agree with you :)

As per this line:

$('#relevance10967').val('1');

Not sure why is that set

#relevance10967 is used to check QCODE.relevanceStatus , if it's 0 : QCODE.NAOK send null in all condition.

In fact : checking group.relevance && question.relevance is needed if the question is used in another question …

Recheck all question relevance when a group is shown can be done BUT :
JS relevance system is linked to an update of another question : https://github.com/LimeSurvey/LimeSurvey/blob/5ff4910ea13e97a057bd6ab784b1ab1902ffe622/application/helpers/expressions/em_manager_helper.php#L7839-L7840 (sgqa)

This is needed to check if sgqa is used in this function …

Else : you get JS loop : https://bugs.limesurvey.org/view.php?id=14958

OK : issue in JS of expression manager : must continue if group of current question are updated.

best way to check

1. launch survey
2. Click on show question Yes
3. Click on show group Yes
4. Only one question shown
5. Click on show question No
6. Click on show question Yes
   7.two questions shown

3LTS : https://github.com/LimeSurvey/LimeSurvey/pull/2119
5master : https://github.com/LimeSurvey/LimeSurvey/pull/2121

Fix committed to 3.x-LTS branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32858

Fix committed to master branch: http://bugs.limesurvey.org/plugin.php?page=Source/view&id=32859

Fixed in Release 5.2.0+211110