View Issue Details

Jump to NotesJump to History
This bug affects 1 person(s).
 2
IDProjectCategoryView StatusDate SubmittedLast Update
13889Feature requestsPluginspublic2018-07-20 16:352018-07-21 10:45
ReporterDenisChenu Assigned To 
PrioritynoneSeverityfeature 
Status newResolutionopen 
Summary13889: Allow plugin to extend twig file
Description

With beforeCloseHtml event : we can add html just before body is closed : OK
With getPluginTwigPath : we can add or replace existing twig file

But currently : there are no way to extend twig file (or add HTML generated with twig at end)

Additional Information

I think renderPartial allow to use twig file : but it's broke https://github.com/LimeSurvey/LimeSurvey/commit/46c9f532ecc8cbb0bd5467b42128773d4de25bd3
Event with Yii::app()->getController()->renderParial : brok (white page)
Then a plugin have 2 solution

  • Replace twig file : but no other plugin can do something (or this can be replaced by another plugin)
  • Construct html manually : less updatable by final user (and dirty …)
TagsNo tags attached.
Bug heat2
Story point estimate
Users affected %

Relationships

Relationship GraphDependency Graph
related to 13702 closedDenisChenu Bug reports beforeCloseHtml event removed 

Users monitoring this issue

There are no users monitoring this issue.

Activities

DenisChenu

DenisChenu

2018-07-20 17:41

developer   ~48544

Last edited: 2018-07-20 17:51

With beforeCloseHtml and Yii::app()->twigRenderer->renderPartial :

[Fri Jul 20 17:40:46 2018] [error] [client 82.233.193.172] PHP Fatal error: Cannot destroy active lambda function in ./LimeSurvey/application/third_party/Twig/Template.php on line 415, referer: ./LimeSurvey/index.php/admin/survey/sa/view/surveyid/374886

Solution : move beforeCloseHtml in twig ?
DenisChenu

DenisChenu

2018-07-21 10:45

developer   ~48546

I need to look https://github.com/LimeSurvey/LimeSurvey/blob/master/application/core/LSETwigViewRenderer.php#L415 and make a demo survey for all of this …

Issue History

Date Modified Username Field Change
2018-07-20 16:35 DenisChenu New Issue
2018-07-20 16:35 DenisChenu Relationship added related to 13702
2018-07-20 17:41 DenisChenu Note Added: 48544
2018-07-20 17:51 DenisChenu Note Edited: 48544
2018-07-21 10:45 DenisChenu Note Added: 48546