View Issue Details
ID | Project | Category | View Status | Date Submitted | Last Update |
---|---|---|---|---|---|
13180 | Bug reports | Survey taking | public | 2018-01-15 10:41 | 2018-02-22 14:18 |
Reporter | cookiemonster | Assigned To | |||
Priority | none | Severity | minor | ||
Status | closed | Resolution | fixed | ||
Fixed in Version | 3.1.x | ||||
Summary | 13180: Variables don't work in END_URL | ||||
Description | Variables don't work in END_URL | ||||
Steps To Reproduce | use a variable in END_URL | ||||
Additional Information | I raised this ticket as https://bugs.limesurvey.org/view.php?id=13156 was closed with fixed in 3.0.3, but this affected variables in general, not the end_url vars - definitely not fixed in 3.03. | ||||
Tags | No tags attached. | ||||
Attached Files | |||||
Bug heat | 8 | ||||
Complete LimeSurvey version number (& build) | Version 3.0.3+180112 | ||||
I will donate to the project if issue is resolved | No | ||||
Browser | Firefox 57.0.4 (64-Bit) | ||||
Database type & version | libmysql - 5.5.54 | ||||
Server OS (if known) | Ubuntu | ||||
Webserver software & version (if known) | Apache/2.4.7 | ||||
PHP Version | 5.5.9 | ||||
related to | 13156 | closed | Some Variables are not working in ongoing survey: ASSESSMENT_CURRENT_TOTAL and TOKEN:TOKEN |
markus, have a look how I fixed it for question text: First we check if the srting contains a '{' to avoid useless logic: So you can move this test in a function out of surveyRuntime Then, if it has a '{', it will call the function getStandardsReplacementFields to generate the Standard Replacement Fields and their current value: The function getStandardsReplacementFields is defined here, based on the old templatereplace (so if some standard variables are missing, you should find them in templatereplace): THen finally the replacement is done via the EM here: So globally, getStandardsReplacementFields should be called only once (or it should use a cache), and then you can apply it doing: LimeExpressionManager::ProcessString("HERE THE STRING WHITHT SOME VARIABLES ", $qa[4], $aStandardsReplacementFields, 3, 1, false, true, false); |
|
{# NOTE: not very clear what the old replacement keyword {URL} was doing #} Now I know ^^ |
|
https://github.com/LimeSurvey/LimeSurvey/commit/4a8c0285161aa56c5dcec9f72e3bb9467d0e1b9a |
|
Fixed in 3.1.1. |
|
still not fixed in Version 3.1.1+180130 |
|
LSS attached (LSA doesn't work, will create another bug report for that) |
|
I raised a new ticket as I'm not sure if you're following "closed" bugs :) |
|
Date Modified | Username | Field | Change |
---|---|---|---|
2018-01-15 10:41 | cookiemonster | New Issue | |
2018-01-15 11:28 |
|
Relationship added | related to 13156 |
2018-01-23 10:13 | jelo | Issue Monitored: jelo | |
2018-01-23 10:28 |
|
Assigned To | => markusfluer |
2018-01-23 10:28 |
|
Status | new => assigned |
2018-01-23 10:33 |
|
Note Added: 45961 | |
2018-01-23 10:35 |
|
Note Edited: 45961 | |
2018-01-26 14:14 |
|
Sticky Issue | No => Yes |
2018-01-26 14:35 |
|
Note Added: 46111 | |
2018-01-26 17:35 |
|
Note Added: 46116 | |
2018-01-26 17:35 |
|
Status | assigned => resolved |
2018-01-26 17:35 |
|
Resolution | open => fixed |
2018-01-26 17:35 |
|
Fixed in Version | => 3.1.x |
2018-01-30 14:27 | ollehar | Status | resolved => closed |
2018-01-30 14:27 | ollehar | Note Added: 46149 | |
2018-01-31 13:10 | cookiemonster | Note Added: 46177 | |
2018-01-31 13:17 | cookiemonster | File Added: limesurvey_survey_498847.lss | |
2018-01-31 13:17 | cookiemonster | Note Added: 46178 | |
2018-02-01 08:37 | cookiemonster | Note Added: 46190 | |
2018-02-22 14:18 | c_schmitz | Sticky Issue | Yes => No |
2021-08-02 17:53 | guest | Bug heat | 6 => 8 |